Bug 1625927 - Enable multi-value on nightly r=lth
authorAndy Wingo <wingo@igalia.com>
Tue, 07 Apr 2020 09:01:18 +0000 (2020-04-07)
changeset 522537 8e655f8db1fb8421f2f616de95b69e214fae106f
parent 522536 34ebd6260867364e46f95de72538e4c655aa8869
child 522538 62511d16935e2127774068753f46fa7005f69ab8
push id37292
push userccoroiu@mozilla.com
push dateTue, 07 Apr 2020 16:05:40 +0000 (2020-04-07)
treeherdermozilla-central@6c6c67870c37 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslth
bugs1625927
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1625927 - Enable multi-value on nightly r=lth Now that multi-value is code-complete, we enable it on nightly browsers in addition to shell builds. Differential Revision: https://phabricator.services.mozilla.com/D68791
js/moz.configure
testing/web-platform/meta/wasm/jsapi/constructor/multi-value.any.js.ini
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -589,19 +589,19 @@ js_option('--enable-wasm-private-reftype
 set_config('WASM_PRIVATE_REFTYPES', depends_if('--enable-wasm-private-reftypes')(lambda x: True))
 set_define('WASM_PRIVATE_REFTYPES', depends_if('--enable-wasm-private-reftypes')(lambda x: True))
 
 
 # Support for the WebAssembly multi-value proposal.
 # Do not remove until Cranelift supports multi-value.
 # =====================================================
 
-@depends(milestone.is_nightly, building_js)
-def default_wasm_multi_value(is_nightly, building_js):
-    return is_nightly and building_js
+@depends(milestone.is_nightly)
+def default_wasm_multi_value(is_nightly):
+    return is_nightly
 
 js_option('--enable-wasm-multi-value',
           default=default_wasm_multi_value,
           help='{Enable|Disable} support for the experimental WebAssembly '
                'multi-value proposal')
 
 set_config('ENABLE_WASM_MULTI_VALUE', depends_if('--enable-wasm-multi-value')(lambda x: True))
 set_define('ENABLE_WASM_MULTI_VALUE', depends_if('--enable-wasm-multi-value')(lambda x: True))
--- a/testing/web-platform/meta/wasm/jsapi/constructor/multi-value.any.js.ini
+++ b/testing/web-platform/meta/wasm/jsapi/constructor/multi-value.any.js.ini
@@ -1,17 +1,20 @@
 [multi-value.any.html]
   [multiple return values from wasm to js]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL
 
   [multiple return values inside wasm]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL
 
   [multiple return values from js to wasm]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL
 
 
 [multi-value.any.js]
   [multiple return values from wasm to js]
     expected:
       if not nightly_build: FAIL
 
   [multiple return values inside wasm]
@@ -20,16 +23,19 @@
 
   [multiple return values from js to wasm]
     expected:
       if not nightly_build: FAIL
 
 
 [multi-value.any.worker.html]
   [multiple return values from wasm to js]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL
 
   [multiple return values inside wasm]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL
 
   [multiple return values from js to wasm]
-    expected: FAIL
+    expected:
+      if not nightly_build: FAIL