Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck
Before this patch, `rsclientcerts::manager` would rate-limit calls to
`find_objects` to once every 3 seconds because the underlying operation can be
time-consuming (in particular, on macOS and Windows, if there are many
certificates/keys available). On Android, keys aren't available until the user
selects one, which means that if a call to `find_objects` happened before the
selection prompt was shown (which is what happens) and the user chose one in
less than 3 seconds, the backend wouldn't search again, thus making it seem like
no keys were available, which would cause Firefox to not send a client
certificate. This patch makes each backend implementation responsible for this
rate-limiting, because only they know if it's appropriate to do so (in particular,
on Android, `find_objects` doesn't have the same performance concern as
on macOS and Windows because rather than searching for certificates and
keys, it asks `ClientAuthCertificateManager` for the cached list of certificates
and keys that have already been approved for use by the user).
Differential Revision: https://phabricator.services.mozilla.com/D257065
<!DOCTYPE html><html><head><title> Test Scheduled Sources with Huge Time Limits</title><scriptsrc="/resources/testharness.js"></script><scriptsrc="/resources/testharnessreport.js"></script><scriptsrc="/webaudio/resources/audit-util.js"></script><scriptsrc="/webaudio/resources/audit.js"></script><scriptsrc="/webaudio/resources/audioparam-testing.js"></script></head><body><scriptid="layout-test-code">letsampleRate=48000;letrenderFrames=1000;letaudit=Audit.createTaskRunner();audit.define('buffersource: huge stop time',(task,should)=>{// We only need to generate a small number of frames for this test.letcontext=newOfflineAudioContext(1,renderFrames,sampleRate);letsrc=context.createBufferSource();// Constant source of amplitude 1, looping.src.buffer=createConstantBuffer(context,1,1);src.loop=true;// Create the graph and go!letendTime=1e300;src.connect(context.destination);src.start();src.stop(endTime);context.startRendering().then(function(resultBuffer){letresult=resultBuffer.getChannelData(0);should(result,'Output from AudioBufferSource.stop('+endTime+')').beConstantValueOf(1);}).then(()=>task.done());});audit.define('oscillator: huge stop time',(task,should)=>{// We only need to generate a small number of frames for this test.letcontext=newOfflineAudioContext(1,renderFrames,sampleRate);letsrc=context.createOscillator();// Create the graph and go!letendTime=1e300;src.connect(context.destination);src.start();src.stop(endTime);context.startRendering().then(function(resultBuffer){letresult=resultBuffer.getChannelData(0);// The buffer should not be empty. Just find the max and verify// that it's not zero.letmax=Math.max.apply(null,result);should(max,'Peak amplitude from oscillator.stop('+endTime+')').beGreaterThan(0);}).then(()=>task.done());});audit.run();</script></body></html>