Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck
Before this patch, `rsclientcerts::manager` would rate-limit calls to
`find_objects` to once every 3 seconds because the underlying operation can be
time-consuming (in particular, on macOS and Windows, if there are many
certificates/keys available). On Android, keys aren't available until the user
selects one, which means that if a call to `find_objects` happened before the
selection prompt was shown (which is what happens) and the user chose one in
less than 3 seconds, the backend wouldn't search again, thus making it seem like
no keys were available, which would cause Firefox to not send a client
certificate. This patch makes each backend implementation responsible for this
rate-limiting, because only they know if it's appropriate to do so (in particular,
on Android, `find_objects` doesn't have the same performance concern as
on macOS and Windows because rather than searching for certificates and
keys, it asks `ClientAuthCertificateManager` for the cached list of certificates
and keys that have already been approved for use by the user).
Differential Revision: https://phabricator.services.mozilla.com/D257065
<!DOCTYPE html><htmllang="en-GB"><head><metacharset="utf-8"/><title>EUC-KR decoding errors</title><metaname="timeout"content="long"><scriptsrc="/resources/testharness.js"></script><scriptsrc="/resources/testharnessreport.js"></script><linkrel="author"title="Richard Ishida"href="mailto:ishida@w3.org"><linkrel="help"href="https://encoding.spec.whatwg.org/#euc-kr"><metaname="assert"content="The browser decodes characters that are not recognised from the euc-kr encoding as replacement characters."><style>iframe{display:none}</style></head><bodyonload="showNodes();"><iframesrc="euckr_errors.html"name="scriptWindow"id="scrwin"></iframe><divid="log"></div><script>vartests=[];functioniframeRef(frameRef){returnframeRef.contentWindow?frameRef.contentWindow.document:frameRef.contentDocument;}functionshowNodes(){variframe=iframeRef(document.getElementById("scrwin"));nodes=iframe.querySelectorAll("span");t=-1;t++;tests[t]=async_test("lead not 0x00 and no more bytes: B0");t++;tests[t]=async_test("lead not 0x00 and no more bytes: B0 B5 B0");t++;tests[t]=async_test("lead not 0x00 and no more bytes: B0 B0 B0");t++;tests[t]=async_test("lead byte outside 0x81-0xFE: FF");t++;tests[t]=async_test("lead byte outside 0x81-0xFE: B0 B0 FF");t++;tests[t]=async_test("trail byte outside 0x41-0xFE: B0 31");t++;tests[t]=async_test("trail byte outside 0x41-0xFE: B0 FF");t++;tests[t]=async_test("pointer is null: 81 5B");t=-1;t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"갠�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"같�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"갠�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"�1");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"�");});tests[t].done();t++;tests[t].step(function(){assert_equals(nodes[t].textContent,"�[");});tests[t].done();}</script></body></html>