Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck
Before this patch, `rsclientcerts::manager` would rate-limit calls to
`find_objects` to once every 3 seconds because the underlying operation can be
time-consuming (in particular, on macOS and Windows, if there are many
certificates/keys available). On Android, keys aren't available until the user
selects one, which means that if a call to `find_objects` happened before the
selection prompt was shown (which is what happens) and the user chose one in
less than 3 seconds, the backend wouldn't search again, thus making it seem like
no keys were available, which would cause Firefox to not send a client
certificate. This patch makes each backend implementation responsible for this
rate-limiting, because only they know if it's appropriate to do so (in particular,
on Android, `find_objects` doesn't have the same performance concern as
on macOS and Windows because rather than searching for certificates and
keys, it asks `ClientAuthCertificateManager` for the cached list of certificates
and keys that have already been approved for use by the user).
Differential Revision: https://phabricator.services.mozilla.com/D257065
<!DOCTYPE html><linkrel="author"title="Morten Stenshorne"href="mstensho@chromium.org"><linkrel="help"href="https://www.w3.org/TR/cssom-view-1/#extensions-to-the-document-interface"><divid="container"style="width:200px; height:200px; writing-mode:horizontal-tb; direction:ltr;"><spanid="target">target</span></div><scriptsrc="/resources/testharness.js"></script><scriptsrc="/resources/testharnessreport.js"></script><script>test(()=>{varelements=document.elementsFromPoint(15,15);assert_equals(elements.length,4);assert_equals(elements[0].id,"target");assert_equals(elements[1].id,"container");assert_equals(elements[2].nodeName,"BODY");assert_equals(elements[3].nodeName,"HTML");},"elementsFromPoint should return all elements under a point");</script>
