Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck
Before this patch, `rsclientcerts::manager` would rate-limit calls to
`find_objects` to once every 3 seconds because the underlying operation can be
time-consuming (in particular, on macOS and Windows, if there are many
certificates/keys available). On Android, keys aren't available until the user
selects one, which means that if a call to `find_objects` happened before the
selection prompt was shown (which is what happens) and the user chose one in
less than 3 seconds, the backend wouldn't search again, thus making it seem like
no keys were available, which would cause Firefox to not send a client
certificate. This patch makes each backend implementation responsible for this
rate-limiting, because only they know if it's appropriate to do so (in particular,
on Android, `find_objects` doesn't have the same performance concern as
on macOS and Windows because rather than searching for certificates and
keys, it asks `ClientAuthCertificateManager` for the cached list of certificates
and keys that have already been approved for use by the user).
Differential Revision: https://phabricator.services.mozilla.com/D257065
<!DOCTYPE HTML><html><!--https://bugzilla.mozilla.org/show_bug.cgi?id=391034--><head><title>Test for Bug 391034</title><scriptsrc="/tests/SimpleTest/SimpleTest.js"></script><linkrel="stylesheet"type="text/css"href="/tests/SimpleTest/test.css"/></head><body><atarget="_blank"href="https://bugzilla.mozilla.org/show_bug.cgi?id=391034">Mozilla Bug 391034</a><divid="display"style="width: 90px; height: 80px"><divid="width-ref"style="width: 2ch"></div><divid="width-ref2"style="width: 5ch"></div><divid="one"style="position: relative; left: 2ch; bottom: 5ch"></div><divid="two"style="position: relative; left: 10%; bottom: 20%"></div><divid="three"style="position: relative; left: 10px; bottom: 6px"></div></div><divid="content"style="display: none"><divid="four"style="position: relative; left: 10%; bottom: 20%"></div></div><preid="test"><scriptclass="testbody"type="text/javascript">/** Test for Bug 391034 **/functiongetComp(id){returndocument.defaultView.getComputedStyle($(id));}is(getComp("one").top,"-"+getComp("width-ref2").width,"Incorrect computed top offset if specified in ch")is(getComp("one").right,"-"+getComp("width-ref").width,"Incorrect computed right offset if specified in ch")is(getComp("one").bottom,getComp("width-ref2").width,"Incorrect computed bottom offset if specified in ch")is(getComp("one").left,getComp("width-ref").width,"Incorrect computed left offset if specified in ch")is(getComp("two").top,"-16px","Incorrect computed top offset if specified in %")is(getComp("two").right,"-9px","Incorrect computed right offset if specified in %")is(getComp("two").bottom,"16px","Incorrect computed bottom offset if specified in %")is(getComp("two").left,"9px","Incorrect computed left offset if specified in %")is(getComp("three").top,"-6px","Incorrect computed top offset if specified in %")is(getComp("three").right,"-10px","Incorrect computed right offset if specified in %")is(getComp("three").bottom,"6px","Incorrect computed bottom offset if specified in %")is(getComp("three").left,"10px","Incorrect computed left offset if specified in %")is(getComp("four").top,"auto","Incorrect undisplayed computed top offset if specified in %")is(getComp("four").right,"auto","Incorrect undisplayed computed right offset if specified in %")is(getComp("four").bottom,"20%","Incorrect undisplayed computed bottom offset if specified in %")is(getComp("four").left,"10%","Incorrect undisplayed computed left offset if specified in %")</script></pre></body></html>
