dom/media/webrtc/tests/mochitests/test_peerConnection_setParametersCompatMode.html
author Dana Keeler <dkeeler@mozilla.com>
Sat, 12 Jul 2025 15:57:37 +0000 (16 hours ago)
changeset 796342 3a804f83c6b282c3c6b6ed9b67bacbc277bfb300
parent 741476 cb4b7c033ca55d73f177ef925703c1af046dd099
permissions -rw-r--r--
Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck Before this patch, `rsclientcerts::manager` would rate-limit calls to `find_objects` to once every 3 seconds because the underlying operation can be time-consuming (in particular, on macOS and Windows, if there are many certificates/keys available). On Android, keys aren't available until the user selects one, which means that if a call to `find_objects` happened before the selection prompt was shown (which is what happens) and the user chose one in less than 3 seconds, the backend wouldn't search again, thus making it seem like no keys were available, which would cause Firefox to not send a client certificate. This patch makes each backend implementation responsible for this rate-limiting, because only they know if it's appropriate to do so (in particular, on Android, `find_objects` doesn't have the same performance concern as on macOS and Windows because rather than searching for certificates and keys, it asks `ClientAuthCertificateManager` for the cached list of certificates and keys that have already been approved for use by the user). Differential Revision: https://phabricator.services.mozilla.com/D257065
<!DOCTYPE HTML>
<html>

<head>
  <script type="application/javascript" src="pc.js"></script>
  <script type="application/javascript" src="sdpUtils.js"></script>
</head>

<body>
  <pre id="test">
<script type="application/javascript">
  createHTML({
    bug: "1401592",
    title: "Test that setParameters compat mode works",
    visible: true
  });

  function compareCodecParam(observed, expected) {
    info(`Comparing ${JSON.stringify(observed)} to ${JSON.stringify(expected)}`);
    is(observed.payloadType, expected.payloadType);
    is(observed.clockRate, expected.clockRate);
    is(observed.channels, expected.channels);
    is(observed.mimeType.toLowerCase(), expected.mimeType.toLowerCase());
    if (expected.hasOwnProperty('sdpFmtpLine')) {
      is(observed.sdpFmtpLine, expected.sdpFmtpLine);
    }
  }

  function compareCodecParams(observed, expected) {
    is(observed.length, expected.length);
    if (observed.length == expected.length) {
      for (let i = 0; i < observed.length; ++i) {
        compareCodecParam(observed[i], expected[i]);
      }
    }
  }

  const tests = [
    async function checkNoGetParameters() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc = new RTCPeerConnection();
          const { sender } = pc.addTransceiver('video', {
            sendEncodings: [{ rid: "0" }, { rid: "1" }, { rid: "2" }]
          });
          await sender.setParameters({ encodings: [{ rid: "0" }, { rid: "1" }, { rid: "2" }] });
        }
      );
    },

    async function checkStaleGetParameters() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc = new RTCPeerConnection();
          const { sender } = pc.addTransceiver('video', {
            sendEncodings: [{ rid: "0" }, { rid: "1" }, { rid: "2" }]
          });
          const params = sender.getParameters();
          await new Promise(r => setTimeout(r, 10));
          await sender.setParameters(params);
        }
      );
    },

    async function checkLengthChanged() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc = new RTCPeerConnection();
          const { sender } = pc.addTransceiver('video', {
            sendEncodings: [{ rid: "0" }, { rid: "1" }, { rid: "2" }]
          });

          const params = sender.getParameters();
          params.encodings.pop();
          await sender.setParameters(params);
        }
      );
    },

    async function checkNoTransactionId() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc = new RTCPeerConnection();
          const { sender } = pc.addTransceiver('video', {
            sendEncodings: [{ rid: "0" }, { rid: "1" }, { rid: "2" }]
          });

          const params = sender.getParameters();
          delete params.transactionId;
          await sender.setParameters(params);
        }
      );
    },

    async function checkCodecsUndefined() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc1 = new RTCPeerConnection();
          const pc2 = new RTCPeerConnection();
          const { sender } = pc1.addTransceiver('video');
          await pc1.setLocalDescription();
          await pc2.setRemoteDescription(pc1.localDescription);
          await pc1.setRemoteDescription(await pc2.createAnswer());
          let params = sender.getParameters();
          const codecsCopy = [...params.codecs];
          delete params.codecs;
          await sender.setParameters(params);
          params = sender.getParameters();
          compareCodecParams(params.codecs, codecsCopy);
        }
      );
    },

    async function checkCodecsExtended() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc1 = new RTCPeerConnection();
          const pc2 = new RTCPeerConnection();
          const { sender } = pc1.addTransceiver('video');
          await pc1.setLocalDescription();
          await pc2.setRemoteDescription(pc1.localDescription);
          await pc1.setRemoteDescription(await pc2.createAnswer());
          let params = sender.getParameters();
          const codecsCopy = [...params.codecs];
          params.codecs.push({payloadType: 2, mimeType: 'video/flarglblurp', clockRate: 1000});
          await sender.setParameters(params);
          params = sender.getParameters();
          compareCodecParams(params.codecs, codecsCopy);
        }
      );
    },

    async function checkCodecsTruncated() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc1 = new RTCPeerConnection();
          const pc2 = new RTCPeerConnection();
          const { sender } = pc1.addTransceiver('video');
          await pc1.setLocalDescription();
          await pc2.setRemoteDescription(pc1.localDescription);
          await pc1.setRemoteDescription(await pc2.createAnswer());
          let params = sender.getParameters();
          const codecsCopy = [...params.codecs];
          params.codecs.pop();
          await sender.setParameters(params);
          params = sender.getParameters();
          compareCodecParams(params.codecs, codecsCopy);
        }
      );
    },

    async function checkCodecsReordered() {
      await withPrefs([["media.peerconnection.allow_old_setParameters", true]],
        async () => {
          const pc1 = new RTCPeerConnection();
          const pc2 = new RTCPeerConnection();
          const { sender } = pc1.addTransceiver('video');
          await pc1.setLocalDescription();
          await pc2.setRemoteDescription(pc1.localDescription);
          await pc1.setRemoteDescription(await pc2.createAnswer());
          let params = sender.getParameters();
          const codecsCopy = [...params.codecs];
          params.codecs.reverse();
          await sender.setParameters(params);
          params = sender.getParameters();
          compareCodecParams(params.codecs, codecsCopy);
        }
      );
    },
  ];

  runNetworkTest(async () => {
    for (const test of tests) {
      info(`Running test: ${test.name}`);
      await test();
      info(`Done running test: ${test.name}`);
    }
  });

</script>
</pre>
</body>
</html>