Mercurial > mozilla-central / file revision / dom/canvas/test/webgl-conf/checkout/conformance2/buffers/get-buffer-sub-data-validity.html@3a804f83c6b282c3c6b6ed9b67bacbc277bfb300
summary | shortlog | changelog | pushlog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
dom/canvas/test/webgl-conf/checkout/conformance2/buffers/get-buffer-sub-data-validity.html
author Dana Keeler <dkeeler@mozilla.com>
Sat, 12 Jul 2025 15:57:37 +0000 (11 hours ago)
changeset 796342 3a804f83c6b282c3c6b6ed9b67bacbc277bfb300
parent 635091 b30f215b5cb5e214af80273e907486dcd7bf8499
permissions -rw-r--r--
Bug 1976779 - rsclientcerts: make each backend responsible for rate-limiting calls to find_objects r=jschanck Before this patch, `rsclientcerts::manager` would rate-limit calls to `find_objects` to once every 3 seconds because the underlying operation can be time-consuming (in particular, on macOS and Windows, if there are many certificates/keys available). On Android, keys aren't available until the user selects one, which means that if a call to `find_objects` happened before the selection prompt was shown (which is what happens) and the user chose one in less than 3 seconds, the backend wouldn't search again, thus making it seem like no keys were available, which would cause Firefox to not send a client certificate. This patch makes each backend implementation responsible for this rate-limiting, because only they know if it's appropriate to do so (in particular, on Android, `find_objects` doesn't have the same performance concern as on macOS and Windows because rather than searching for certificates and keys, it asks `ClientAuthCertificateManager` for the cached list of certificates and keys that have already been approved for use by the user). Differential Revision: https://phabricator.services.mozilla.com/D257065
<!--
Copyright (c) 2019 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>WebGL2 getBufferSubData validity tests</title>
<link rel="stylesheet" href="../../resources/js-test-style.css"/>
<script src="../../js/js-test-pre.js"></script>
<script src="../../js/webgl-test-utils.js"> </script>
</head>
<body>
<div id="description"></div>
<div id="console"></div>

<script id="vshader" type="x-shader/x-vertex">#version 300 es
in uint in_data;
flat out uint out_data;
void main() {
    out_data = in_data;
}
</script>
<script id="fshader" type="x-shader/x-fragment">#version 300 es
void main() {}
</script>

<script>
"use strict";
description("Test that getBufferSubData returns valid data in edge cases");

var wtu = WebGLTestUtils;

var gl = wtu.create3DContext(undefined, undefined, 2);

const srcData = new Uint8Array([ 1, 2, 3, 4, 5, 6, 7, 8 ]);
const noData = new Uint8Array(8);

const srcBuffer = gl.createBuffer();
gl.bindBuffer(gl.COPY_READ_BUFFER, srcBuffer);
gl.bufferData(gl.COPY_READ_BUFFER, srcData, gl.STATIC_DRAW);

const badBuffer = gl.createBuffer();
gl.bindBuffer(gl.ARRAY_BUFFER, badBuffer);
gl.bufferData(gl.ARRAY_BUFFER, 8, gl.STATIC_DRAW);

let readbackBuffer;
function deleteReadbackBuffer() {
    gl.deleteBuffer(readbackBuffer);
}
function recreateReadbackBuffer() {
    readbackBuffer = gl.createBuffer();
    gl.bindBuffer(gl.COPY_WRITE_BUFFER, readbackBuffer);
    gl.bufferData(gl.COPY_WRITE_BUFFER, 8, gl.STREAM_READ);
}
recreateReadbackBuffer();

const dest = new Uint8Array(8);

// Makes a new "resolvable" Promise
function resolvable() {
    let resolve;
    const promise = new Promise(res => { resolve = res; });
    promise.resolve = resolve;
    return promise;
}

function wait() {
    return new Promise(res => {
        setTimeout(res, 0);
    });
}

async function fence() {
    const sync = gl.fenceSync(gl.SYNC_GPU_COMMANDS_COMPLETE, 0);
    gl.flush();

    let status;
    do {
        await wait();
        status = gl.clientWaitSync(sync, 0, 0);
    } while (status != gl.ALREADY_SIGNALED && status != gl.CONDITION_SATISFIED);
    gl.deleteSync(sync);
}

function checkGetBufferSubData(err, data) {
    dest.fill(0);
    wtu.shouldGenerateGLError(gl, err, "gl.getBufferSubData(gl.COPY_WRITE_BUFFER, 0, dest)");
    if (!err) {
        shouldBeTrue(`areArraysEqual(dest, ${data})`);
    }
}

const tfProgram = wtu.setupTransformFeedbackProgram(gl, ["vshader", "fshader"],
        ["out_data"], gl.SEPARATE_ATTRIBS,
        ["in_data"]);
wtu.glErrorShouldBe(gl, gl.NO_ERROR, "linking transform feedback shader should not set an error");
shouldBeNonNull("tfProgram");
const tf = gl.createTransformFeedback();

function copyBufferUsingTransformFeedback(src, dst) {
    gl.enableVertexAttribArray(0);
    gl.bindBuffer(gl.ARRAY_BUFFER, src);
    gl.vertexAttribIPointer(0, 1, gl.UNSIGNED_INT, 0, 0);

    gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, tf);
    gl.bindBufferBase(gl.TRANSFORM_FEEDBACK_BUFFER, 0, dst);

    gl.drawBuffers([gl.NONE]);

    gl.enable(gl.RASTERIZER_DISCARD);
    gl.beginTransformFeedback(gl.POINTS);
    // treats the input and output data as two uint32s
    gl.drawArrays(gl.POINTS, 0, 2);
    gl.endTransformFeedback();
    gl.disable(gl.RASTERIZER_DISCARD);

    gl.bindBuffer(gl.ARRAY_BUFFER, badBuffer);
    gl.bindBufferBase(gl.TRANSFORM_FEEDBACK_BUFFER, 0, null);
    gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK, null);
}

(async () => {
    debug("");
    debug("write-read");
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("fence-wait-write-read");
    await fence();
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-read-fence-wait");
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    checkGetBufferSubData(gl.NO_ERROR, "srcData");
    await fence();

    debug("");
    debug("write-fence-fence-wait-read");
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    fence(); // no await
    await fence();
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-fence-wait-read");
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    await fence();
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-fence-wait-write-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    await fence();
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-fence-write-wait-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    {
        const p = fence();
        gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
        await p;
    }
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-fence-transformfeedback-wait-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    {
        const p = fence();
        gl.bindBuffer(gl.COPY_WRITE_BUFFER, null);
        copyBufferUsingTransformFeedback(srcBuffer, readbackBuffer);
        gl.bindBuffer(gl.COPY_WRITE_BUFFER, readbackBuffer);
        await p;
    }
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-unbind-fence-wait-bind-read");
    gl.bindBuffer(gl.COPY_WRITE_BUFFER, null);
    gl.bindBuffer(gl.ARRAY_BUFFER, readbackBuffer);
    gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.ARRAY_BUFFER, 0, 0, 8);
    gl.bindBuffer(gl.ARRAY_BUFFER, badBuffer);
    await fence();
    gl.bindBuffer(gl.COPY_WRITE_BUFFER, readbackBuffer);
    checkGetBufferSubData(gl.NO_ERROR, "srcData");

    debug("");
    debug("write-fence-wait-delete-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    await fence();
    deleteReadbackBuffer();
    checkGetBufferSubData(gl.INVALID_OPERATION, "noData");
    recreateReadbackBuffer();

    debug("");
    debug("write-fence-delete-wait-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    {
        const p = fence();
        deleteReadbackBuffer();
        await p;
    }
    checkGetBufferSubData(gl.INVALID_OPERATION, "noData");
    recreateReadbackBuffer();

    debug("");
    debug("write-fence-delete-wait-read");
    gl.copyBufferSubData(gl.ARRAY_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
    deleteReadbackBuffer();
    await fence();
    checkGetBufferSubData(gl.INVALID_OPERATION, "noData");
    recreateReadbackBuffer();

    // crbug.com/941930
    {
        debug("");
        debug("write-delete-recreate-fence-wait-read");
        gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
        deleteReadbackBuffer();
        recreateReadbackBuffer();
        await fence();
        checkGetBufferSubData(gl.NO_ERROR, "noData");

        debug("");
        debug("write-delete-fence-wait-read");
        gl.copyBufferSubData(gl.COPY_READ_BUFFER, gl.COPY_WRITE_BUFFER, 0, 0, 8);
        {
            const p = fence();
            deleteReadbackBuffer();
            await p;
        }
        wtu.glErrorShouldBe(gl, gl.NO_ERROR);
    }

    finishTest();
})();

var successfullyParsed = true;
</script>
</body>
</html>
mozilla-central
Deployed from 0549d7aefb93 at 2025-06-12T15:23:35Z.