Bug 1135756 - Re-enable errors for TC uploads; r=jlund
authorMike Shal <mshal@mozilla.com>
Mon, 23 Mar 2015 09:38:59 -0400 (2015-03-23)
changeset 3804 74b1d686c7031a64e8d09489ab672cc25e198042
parent 3803 7613bfa3aaedcbcf6ca02af152c0b3182b246ef5
child 3805 48f4d9e391ead6dcc2088bc8caa35187dd514b93
push id3000
push usermshal@mozilla.com
push dateMon, 23 Mar 2015 13:40:43 +0000 (2015-03-23)
reviewersjlund
bugs1135756
Bug 1135756 - Re-enable errors for TC uploads; r=jlund
mozharness/mozilla/building/buildbase.py
--- a/mozharness/mozilla/building/buildbase.py
+++ b/mozharness/mozilla/building/buildbase.py
@@ -1487,25 +1487,17 @@ or run without that action (ie: --no-{ac
                        "log for errors.")
 
     def postflight_build(self, console_output=True):
         """grabs properties from post build and calls ccache -s"""
         c = self.config
         self.generate_build_props(console_output=console_output,
                                   halt_on_failure=True)
 
-        # TODO: Bug 1135756
-        # We ignore all exceptions from upload_files while the TC queue re-write
-        # is ongoing, but we need to remove that before switching testers to
-        # pull from S3.
-        try:
-            self.upload_files()
-        except:
-            self.warning('Temporarily ignoring S3 upload exception:')
-            self.exception(level=WARNING)
+        self.upload_files()
 
         if c.get('enable_talos_sendchange'):
             self._do_sendchange('talos')
 
         if c.get('enable_unittest_sendchange'):
             self._do_sendchange('unittest')
 
         if self.config.get('enable_check_test'):