Bug 1241336 - Add LastPass 3.* in the filter function for the experiment. r=billm
authorFelipe Gomes <felipc@gmail.com>
Wed, 27 Jan 2016 16:44:03 -0200
changeset 70 73b05e4d57c604813d5b16f8f62e40ce3f254678
parent 69 b5ddc65fd53618c2bc5758c8c8c64238d831a75b
child 71 31f3366595833f424a09313ba79a6711114f93a1
push id54
push userfelipc@gmail.com
push dateThu, 28 Jan 2016 18:33:59 +0000
reviewersbillm
bugs1241336
Bug 1241336 - Add LastPass 3.* in the filter function for the experiment. r=billm The patch also updates the manifest with the correct bug number
experiments/e10s-beta45-withaddons/filter.js
experiments/e10s-beta45-withaddons/manifest.json
--- a/experiments/e10s-beta45-withaddons/filter.js
+++ b/experiments/e10s-beta45-withaddons/filter.js
@@ -1,3 +1,21 @@
 function filter(c) {
+  let activeAddons = {};
+  try {
+    activeAddons = c.telemetryEnvironment.addons.activeAddons;
+  } catch (e) {
+    return false;
+  }
+
+  for (let addon of Object.keys(activeAddons)) {
+    if (addon == "support@lastpass.com") {
+      let version = new String(activeAddons[addon].version);
+      // LastPass versions 3.* are known to have problems
+      // with e10s, so let's skip the experiment for these users
+      if (version.startsWith("3")) {
+        return false;
+      }
+    }
+  }
+
   return c.telemetryEnvironment.settings.telemetryEnabled;
 }
--- a/experiments/e10s-beta45-withaddons/manifest.json
+++ b/experiments/e10s-beta45-withaddons/manifest.json
@@ -1,14 +1,14 @@
 {
   "publish"     : true,
   "priority"    : 1,
   "name"        : "Multi-process Firefox A/B test",
   "description" : "Measure the effect of multi-process Firefox",
-  "info"        : "<p><a href=\"https://bugzilla.mozilla.org/show_bug.cgi?id=1229104\">Related bug</a></p>",
+  "info"        : "<p><a href=\"https://bugzilla.mozilla.org/show_bug.cgi?id=1241336\">Related bug</a></p>",
   "manifest"    : {
     "id"               : "e10s-beta45-withaddons@experiments.mozilla.org",
     "startTime"        : 1453680001,
     "endTime"          : 1455148801,
     "maxActiveSeconds" : 1296000,
     "appName"          : ["Firefox"],
     "channel"          : ["beta"],
     "minVersion"       : "45.0",