Bug 1148915 - Make htaccess comment clearer
authorEd Morley <emorley@mozilla.com>
Sun, 29 Mar 2015 20:48:49 +0400
changeset 1517 44054a6338ae
parent 1516 73ad7a52c30e
child 1518 7a5a6eeaf0e0
push id878
push useremorley@mozilla.com
push dateTue, 31 Mar 2015 12:09:28 +0000
bugs1148915
Bug 1148915 - Make htaccess comment clearer
.htaccess
--- a/.htaccess
+++ b/.htaccess
@@ -60,19 +60,22 @@
   RewriteRule ^(.*)$ $1?%1repo=comm-aurora%2
 
   RewriteCond %{QUERY_STRING} ^(.*)tree=Thunderbird-Beta(.*)$
   RewriteRule ^(.*)$ $1?%1repo=comm-beta%2
 
   RewriteCond %{QUERY_STRING} ^(.*)tree=Jetpack(.*)$
   RewriteRule ^(.*)$ $1?%1repo=addon-sdk%2
 
-  # In addition, Treeherder's query params are different in virtually all cases.
+  # Next problem: Treeherder's query params are different in virtually all cases.
   # The repo name mappings above have already converted 'tree' to 'repo', but we
-  # still have to handle pusher/rev. Any other params will be discarded for simplicity.
+  # still have to handle pusher/rev. Any other params will be discarded for
+  # simplicity. In addition, if the params are specified in an order different to
+  # the one used by the UI, we don't match and so hit the catch-all, but it's not
+  # worth the added complexity to handle this, since it should be rare.
   # The [NE] flag is required to prevent Apache escaping the '#' to '%23'.
 
   # Filtered by pusher:
   # eg: https://tbpl.mozilla.org/?tree=Try&pusher=email@mozilla.com
   # Any params other than the repo and pusher are discarded.
   RewriteCond %{QUERY_STRING} repo=([^&]+).*&pusher=([^&]+)
   RewriteRule ^(.*)$ https://treeherder.mozilla.org/#/jobs?repo=%1&author=%2 [NE,R=302,L]