Move the error once the retry failed FIREFOX_34_0b1_BUILD1 FIREFOX_34_0b1_RELEASE
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 04 Dec 2014 18:13:05 -0800
changeset 5246 1876365dfd6dd541d83b0ea860ab84d3c5dc74ab
parent 5245 96f00554eaf43a20e3c431a3f8f89569e5b8778e
child 5247 2fccc371de95e8aec24d42251445aa7e698020cd
push id10
push usersledru@mozilla.com
push dateFri, 05 Dec 2014 02:13:09 +0000
Move the error once the retry failed
buildbot-helpers/release_sanity.py
--- a/buildbot-helpers/release_sanity.py
+++ b/buildbot-helpers/release_sanity.py
@@ -122,17 +122,16 @@ def get_l10n_changesets(locale_url):
         urllib2.urlopen(locale_url)
         return True
     except urllib2.HTTPError, e:
         reason = ""
         if hasattr(e, 'reason'):
             # Python 2.6 does not have reason
             reason = e.reason
         log.error("error checking l10n changeset %s: %d %s" % (locale_url, e.code, reason))
-        error_tally.add('verify_l10n')
         raise
 
 
 def verify_l10n_changesets(hgHost, l10n_changesets):
     """Checks for the existance of all l10n changesets"""
     success = True
     locales = query_locale_revisions(l10n_changesets)
     for locale in sorted(locales.keys()):
@@ -142,16 +141,18 @@ def verify_l10n_changesets(hgHost, l10n_
             'locale': locale,
             'revision': revision,
         }
         locale_url = make_hg_url(hgHost, localePath, protocol='https')
         log.info("Checking for existence l10n changeset %s %s in repo %s ..."
                  % (locale, revision, locale_url))
 
         success = retry(get_l10n_changesets, kwargs=dict(locale_url=locale_url), attempts=3, sleeptime=1)
+        if success == False:
+            error_tally.add('verify_l10n')
     return success
 
 
 def verify_l10n_dashboard(l10n_changesets, l10n_dashboard_version=None):
     """Checks the l10n-changesets against the l10n dashboard"""
     success = True
     locales = query_locale_revisions(l10n_changesets)
     if l10n_dashboard_version: