Bug 803236: Reorder nsSTSHostEntry constructors' init lists to fix build warning, and mark that directory & its sibling 'pki' as warning-free. r=bsmith
authorDaniel Holbert <dholbert@cs.stanford.edu>
Thu, 18 Oct 2012 15:42:10 -0700
changeset 110851 c14d2bf709ca36b07453a927c1aa59a8f6d5f764
parent 110850 47a36175f4a5d47f91a7319536537c6e382e783b
child 110852 fa53bf0326fbe6a503ebf875fc368db27da09c1a
push id93
push usernmatsakis@mozilla.com
push dateWed, 31 Oct 2012 21:26:57 +0000
reviewersbsmith
bugs803236
milestone19.0a1
Bug 803236: Reorder nsSTSHostEntry constructors' init lists to fix build warning, and mark that directory & its sibling 'pki' as warning-free. r=bsmith
security/manager/boot/src/Makefile.in
security/manager/boot/src/nsStrictTransportSecurityService.cpp
security/manager/pki/src/Makefile.in
--- a/security/manager/boot/src/Makefile.in
+++ b/security/manager/boot/src/Makefile.in
@@ -11,16 +11,17 @@ include $(DEPTH)/config/autoconf.mk
 
 MODULE		= pipboot
 LIBRARY_NAME	= pipboot
 IS_COMPONENT	= 1
 MODULE_NAME	= BOOT
 EXPORT_LIBRARY	= 1
 GRE_MODULE	= 1
 LIBXUL_LIBRARY	= 1
+FAIL_ON_WARNINGS = 1
 
 CPPSRCS = \
 	nsEntropyCollector.cpp \
 	nsSecureBrowserUIImpl.cpp \
 	nsBOOTModule.cpp \
 	nsSecurityWarningDialogs.cpp \
 	nsStrictTransportSecurityService.cpp \
 	$(NULL)
--- a/security/manager/boot/src/nsStrictTransportSecurityService.cpp
+++ b/security/manager/boot/src/nsStrictTransportSecurityService.cpp
@@ -44,27 +44,27 @@ PRLogModuleInfo *gSTSLog = PR_NewLogModu
     return NS_ERROR_FAILURE; \
   }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 nsSTSHostEntry::nsSTSHostEntry(const char* aHost)
   : mHost(aHost)
   , mExpireTime(0)
+  , mStsPermission(STS_UNSET)
   , mExpired(false)
-  , mStsPermission(STS_UNSET)
   , mIncludeSubdomains(false)
 {
 }
 
 nsSTSHostEntry::nsSTSHostEntry(const nsSTSHostEntry& toCopy)
   : mHost(toCopy.mHost)
   , mExpireTime(toCopy.mExpireTime)
+  , mStsPermission(toCopy.mStsPermission)
   , mExpired(toCopy.mExpired)
-  , mStsPermission(toCopy.mStsPermission)
   , mIncludeSubdomains(toCopy.mIncludeSubdomains)
 {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 
 nsStrictTransportSecurityService::nsStrictTransportSecurityService()
--- a/security/manager/pki/src/Makefile.in
+++ b/security/manager/pki/src/Makefile.in
@@ -13,16 +13,17 @@ include $(DEPTH)/config/autoconf.mk
 
 MODULE		= pippki
 LIBRARY_NAME	= pippki
 IS_COMPONENT	= 1
 MODULE_NAME	= PKI
 EXPORT_LIBRARY	= 1
 GRE_MODULE	= 1
 LIBXUL_LIBRARY	= 1
+FAIL_ON_WARNINGS = 1
 
 CPPSRCS = \
 	nsNSSDialogs.cpp \
 	nsPKIModule.cpp \
 	nsPKIParamBlock.cpp \
         nsASN1Tree.cpp \
         nsNSSDialogHelper.cpp \
 	nsFormSigningDialog.cpp \