Bug 696305 - Add more comments and try removing suppression for bug 793539 since the patch to disable GnomeVFS by default has landed on m-c. DONTBUILD
authorGary Kwong <gary@rumblingedge.com>
Thu, 27 Sep 2012 23:25:31 -0700
changeset 108447 bd2349429495a48b29b0eeefa4d1de21333b8cb4
parent 108446 64558e8ed7235e7284b17568832f44a9eb24c7ed
child 108448 895f66c4eadacee626cb0af56e009920fa64be23
push id82
push usershu@rfrn.org
push dateFri, 05 Oct 2012 13:20:22 +0000
bugs696305, 793539
milestone18.0a1
Bug 696305 - Add more comments and try removing suppression for bug 793539 since the patch to disable GnomeVFS by default has landed on m-c. DONTBUILD
build/valgrind/cross-architecture.sup
build/valgrind/i386-redhat-linux-gnu.sup
build/valgrind/x86_64-redhat-linux-gnu.sup
--- a/build/valgrind/cross-architecture.sup
+++ b/build/valgrind/cross-architecture.sup
@@ -1,8 +1,10 @@
+# Full list is tracked through meta bug 793882
+
 ####################
 #  Intended leaks  #
 ####################
 
 {
    PR_SetEnv requires its argument to be leaked, but does not appear on stacks. (See bug 793534 and see bug 793549.)
    Memcheck:Leak
    ...
--- a/build/valgrind/i386-redhat-linux-gnu.sup
+++ b/build/valgrind/i386-redhat-linux-gnu.sup
@@ -1,25 +1,29 @@
+# Full list is tracked through meta bug 793882
+
 ####################################
 #  Leaks in third party libraries  #
 ####################################
+
 {
    Bug 793537
    Memcheck:Leak
    ...
    obj:/usr/lib/libpango-1.0.so.0.2800.1
    ...
 }
-{
-   Bug 793539 which may be fixed or change when bug 713802 is fixed
-   Memcheck:Leak
-   ...
-   obj:/usr/lib/libgnomevfs-2.so.0.2400.2
-   ...
-}
+#{
+#   Bug 713802 now seems fixed, commenting out suppression to verify that bug 793539 is also gone
+#   Bug 793539 which may be fixed or change when bug 713802 is fixed
+#   Memcheck:Leak
+#   ...
+#   obj:/usr/lib/libgnomevfs-2.so.0.2400.2
+#   ...
+#}
 {
    Bug 793598
    Memcheck:Leak
    ...
    obj:/lib/libdbus-1.so.3.4.0
    ...
 }
 {
--- a/build/valgrind/x86_64-redhat-linux-gnu.sup
+++ b/build/valgrind/x86_64-redhat-linux-gnu.sup
@@ -1,25 +1,29 @@
+# Full list is tracked through meta bug 793882
+
 ####################################
 #  Leaks in third party libraries  #
 ####################################
+
 {
    Bug 793537
    Memcheck:Leak
    ...
    obj:/usr/lib64/libpango-1.0.so.0.2800.1
    ...
 }
-{
-   Bug 793539 which may be fixed or change when bug 713802 is fixed
-   Memcheck:Leak
-   ...
-   obj:/usr/lib64/libgnomevfs-2.so.0.2400.2
-   ...
-}
+#{
+#   Bug 713802 now seems fixed, commenting out suppression to verify that bug 793539 is also gone
+#   Bug 793539 which may be fixed or change when bug 713802 is fixed
+#   Memcheck:Leak
+#   ...
+#   obj:/usr/lib64/libgnomevfs-2.so.0.2400.2
+#   ...
+#}
 {
    Bug 793598
    Memcheck:Leak
    ...
    obj:/lib64/libdbus-1.so.3.4.0
    ...
 }
 {