Bug 803695: Remove "myRawPtr == myRawPtr" comparisons in TestCOMPtrEq.cpp, to fix clang "-Wtautological-compare" warning, and mark dir as warning-free. r=dbaron
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 19 Oct 2012 16:21:02 -0700
changeset 110968 4ae3fd8d62f477b4a8ce0c5bf52ad661d5525846
parent 110967 9af9ca79f02667fa7e4927f33283a3e1666ae366
child 110969 54af2c396f5fa7442b5dfe24e6e90e88fa60044e
push id93
push usernmatsakis@mozilla.com
push dateWed, 31 Oct 2012 21:26:57 +0000
reviewersdbaron
bugs803695
milestone19.0a1
Bug 803695: Remove "myRawPtr == myRawPtr" comparisons in TestCOMPtrEq.cpp, to fix clang "-Wtautological-compare" warning, and mark dir as warning-free. r=dbaron
xpcom/tests/Makefile.in
xpcom/tests/TestCOMPtrEq.cpp
--- a/xpcom/tests/Makefile.in
+++ b/xpcom/tests/Makefile.in
@@ -7,16 +7,17 @@ DEPTH		= @DEPTH@
 topsrcdir	= @top_srcdir@
 srcdir		= @srcdir@
 VPATH		= @srcdir@
 relativesrcdir = @relativesrcdir@
 
 include $(DEPTH)/config/autoconf.mk
 
 MODULE		= xpcom
+FAIL_ON_WARNINGS = 1
 
 DIRS		= \
   external \
   component \
   bug656331_component \
   component_no_aslr \
   $(NULL)
 
--- a/xpcom/tests/TestCOMPtrEq.cpp
+++ b/xpcom/tests/TestCOMPtrEq.cpp
@@ -70,57 +70,52 @@ main()
               (s == s) &&
               (s == r) &&
               (s == sc) &&
               (s == rc) &&
               (s == rk) &&
               (s == rkc) &&
               (s == d) &&
               (r == s) &&
-              (r == r) &&
               (r == sc) &&
               (r == rc) &&
               (r == rk) &&
               (r == rkc) &&
               (r == d) &&
               (sc == s) &&
               (sc == r) &&
               (sc == sc) &&
               (sc == rc) &&
               (sc == rk) &&
               (sc == rkc) &&
               (sc == d) &&
               (rc == s) &&
               (rc == r) &&
               (rc == sc) &&
-              (rc == rc) &&
               (rc == rk) &&
               (rc == rkc) &&
               (rc == d) &&
               (rk == s) &&
               (rk == r) &&
               (rk == sc) &&
               (rk == rc) &&
-              (rk == rk) &&
               (rk == rkc) &&
               (rk == d) &&
               (rkc == s) &&
               (rkc == r) &&
               (rkc == sc) &&
               (rkc == rc) &&
               (rkc == rk) &&
-              (rkc == rkc) &&
               (rkc == d) &&
               (d == s) &&
               (d == r) &&
               (d == sc) &&
               (d == rc) &&
               (d == rk) &&
               (d == rkc) &&
-              (d == d) &&
 #ifdef NSCAP_EQTEST_TEST_ACROSS_TYPES
               (s == s2) &&
               (s == r2) &&
               (s == sc2) &&
               (s == rc2) &&
               (s == rk2) &&
               (s == rkc2) &&
               (s == d2) &&