Bug 777122 - Add telemetry reporting of late writes. r=jlebar.
☠☠ backed out by 791d6f9b8ec8 ☠ ☠
authorRafael Ávila de Espíndola <respindola@mozilla.com>
Wed, 24 Oct 2012 09:30:41 -0400
changeset 111376 46e58a7ec55e927fde50b1dcff0382039c23724c
parent 111375 6ae1d0d7b33c6978272e814344c2d04e75c4d0b0
child 111377 164d7dd54ee0864f9b9acff4de9448bf7e0a1256
push id93
push usernmatsakis@mozilla.com
push dateWed, 31 Oct 2012 21:26:57 +0000
reviewersjlebar
bugs777122
milestone19.0a1
Bug 777122 - Add telemetry reporting of late writes. r=jlebar. Nit missing from the previous patch. DONTBUILD.
xpcom/build/mozPoisonWriteMac.cpp
--- a/xpcom/build/mozPoisonWriteMac.cpp
+++ b/xpcom/build/mozPoisonWriteMac.cpp
@@ -99,17 +99,17 @@ bool ValidWriteAssert(bool ok)
     Telemetry::ProcessedStack stack = Telemetry::GetStackAndModules(rawStack, true);
 
     nsPrintfCString nameAux("%s%s", sProfileDirectory,
                             "/Telemetry.LateWriteTmpXXXXXX");
     char *name;
     nameAux.GetMutableData(&name);
 
     // We want the sha1 of the entire file, so please don't write to fd
-    // directly, use sha1Stream.
+    // directly; use sha1Stream.
     int fd = mkstemp(name);
     SHA1Stream sha1Stream(fd);
     fd = 0;
 
     size_t numModules = stack.GetNumModules();
     sha1Stream.Printf("%u\n", (unsigned)numModules);
     for (int i = 0; i < numModules; ++i) {
         Telemetry::ProcessedStack::Module module = stack.GetModule(i);