Bug 802456. Make all popup type windows on Windows have the composited style to work around a bug in Windows. r=jimm
authorTimothy Nikkel <tnikkel@gmail.com>
Sat, 20 Oct 2012 16:05:14 -0500
changeset 111023 30dd8e889317bdd9ed56101d57f88ae87e9b5bf4
parent 111022 d1fd1af08f2f4c64d59ab9514ec79a7549278d4b
child 111024 ddca56ec6bfcec57c6739f49f5eee3796ab91e8e
push id93
push usernmatsakis@mozilla.com
push dateWed, 31 Oct 2012 21:26:57 +0000
reviewersjimm
bugs802456
milestone19.0a1
Bug 802456. Make all popup type windows on Windows have the composited style to work around a bug in Windows. r=jimm
widget/windows/nsWindow.cpp
--- a/widget/windows/nsWindow.cpp
+++ b/widget/windows/nsWindow.cpp
@@ -483,18 +483,17 @@ nsWindow::Create(nsIWidget *aParent,
   DWORD style = WindowStyle();
   DWORD extendedStyle = WindowExStyle();
 
   if (mWindowType == eWindowType_popup) {
     if (!aParent) {
       parent = NULL;
     }
 
-    if (WinUtils::GetWindowsVersion() >= WinUtils::VISTA_VERSION &&
-        mPopupType == ePopupTypeMenu && aInitData->mDropShadow) {
+    if (WinUtils::GetWindowsVersion() >= WinUtils::VISTA_VERSION) {
       extendedStyle |= WS_EX_COMPOSITED;
     }
 
     if (aInitData->mIsDragPopup) {
       // This flag makes the window transparent to mouse events
       extendedStyle |= WS_EX_TRANSPARENT;
     }
   } else if (mWindowType == eWindowType_invisible) {