Bug 618800 MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches
authortimeless@mozdev.org
Mon, 28 Mar 2011 17:18:21 -0400
changeset 64111 13370fb7a65a569ac207fa15f77d61bf5b19b060
parent 64110 53c333d9961f88e320c021146281a679a9cde856
child 64112 0c3b638b497779a5570acd1f313b34f2929e7ab9
push idunknown
push userunknown
push dateunknown
bugs618800
milestone2.2a1pre
Bug 618800 MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches r=sicking
parser/expat/lib/moz_extensions.c
--- a/parser/expat/lib/moz_extensions.c
+++ b/parser/expat/lib/moz_extensions.c
@@ -114,31 +114,33 @@ int MOZ_XMLCheckQName(const char* ptr, c
 
 int MOZ_XMLIsLetter(const char* ptr)
 {
   switch (BYTE_TYPE(ptr)) {
   case BT_NONASCII:
     if (!IS_NMSTRT_CHAR_MINBPC(ptr)) {
       return 0;
     }
+    /* fall through */
   case BT_NMSTRT:
   case BT_HEX:
     return 1;
   default:
     return 0;
   }
 }
 
 int MOZ_XMLIsNCNameChar(const char* ptr)
 {
   switch (BYTE_TYPE(ptr)) {
   case BT_NONASCII:
     if (!IS_NAME_CHAR_MINBPC(ptr)) {
       return 0;
     }
+    /* fall through */
   case BT_NMSTRT:
   case BT_HEX:
   case BT_DIGIT:
   case BT_NAME:
   case BT_MINUS:
     return 1;
   default:
     return 0;