Bug 595530 - Searching Places is slower after SQLite 3.7.x upgrade. Remove LENGTH check.
authorMarco Bonardo <mbonardo@mozilla.com>
Thu, 21 Oct 2010 02:27:07 +0200
changeset 59310 5c484855cda4df872422c7f8fa57e40903268e80
parent 59309 ccef12b1fe7eec108b2c0d744e84a5f460969136
child 59311 68616dfb2bc9dc9a77f4f0e8cef551539e2f4958
push id1
push usershaver@mozilla.com
push dateTue, 04 Jan 2011 17:58:04 +0000
bugs595530
milestone2.0b8pre
Bug 595530 - Searching Places is slower after SQLite 3.7.x upgrade. Remove LENGTH check. r=sdwilsh a=blocking
toolkit/components/places/src/nsNavHistory.cpp
--- a/toolkit/components/places/src/nsNavHistory.cpp
+++ b/toolkit/components/places/src/nsNavHistory.cpp
@@ -294,17 +294,16 @@ namespace mozilla {
         _sqlFragment.Assign(NS_LITERAL_CSTRING(
              "(SELECT GROUP_CONCAT(tag_title, ', ') "
               "FROM ( "
                 "SELECT t_t.title AS tag_title "
                 "FROM moz_bookmarks b_t "
                 "JOIN moz_bookmarks t_t ON t_t.id = b_t.parent  "
                 "WHERE b_t.fk = ") +
                 aRelation + NS_LITERAL_CSTRING(" "
-                "AND LENGTH(t_t.title) > 0 "
                 "AND t_t.parent = ") +
                 nsPrintfCString("%lld", aTagsFolder) + NS_LITERAL_CSTRING(" "
                 "ORDER BY t_t.title COLLATE NOCASE ASC "
               ") "
              ")"));
       }
 
       _sqlFragment.AppendLiteral(" AS tags ");