Bug 617804, part 1: Change bogus NOTREACHED() assertions. r=bsmedberg a=a
authorChris Jones <jones.chris.g@gmail.com>
Tue, 04 Jan 2011 10:40:54 -0600
changeset 59843 53958cd8b5284d887f71b459dc024d25407ae5bf
parent 59842 6e9e376c146bb6c7e0d837595f7297a37f592fbd
child 59844 94d5e1a68f55b8d698677a6b86c7eb816a6dbc8a
push id1
push usershaver@mozilla.com
push dateTue, 04 Jan 2011 17:58:04 +0000
reviewersbsmedberg, a
bugs617804
milestone2.0b9pre
Bug 617804, part 1: Change bogus NOTREACHED() assertions. r=bsmedberg a=a
dom/ipc/TabChild.cpp
--- a/dom/ipc/TabChild.cpp
+++ b/dom/ipc/TabChild.cpp
@@ -157,19 +157,18 @@ NS_INTERFACE_MAP_BEGIN(TabChild)
 NS_INTERFACE_MAP_END
 
 NS_IMPL_ADDREF(TabChild)
 NS_IMPL_RELEASE(TabChild)
 
 NS_IMETHODIMP
 TabChild::SetStatus(PRUint32 aStatusType, const PRUnichar* aStatus)
 {
-  NS_NOTREACHED("TabChild::SetStatus not supported in TabChild");
-
-  return NS_ERROR_NOT_IMPLEMENTED;
+  // FIXME/bug 617804: should the platform support this?
+  return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::GetWebBrowser(nsIWebBrowser** aWebBrowser)
 {
   NS_NOTREACHED("TabChild::GetWebBrowser not supported in TabChild");
 
   return NS_ERROR_NOT_IMPLEMENTED;
@@ -294,19 +293,18 @@ TabChild::GetTitle(PRUnichar** aTitle)
   NS_NOTREACHED("TabChild::GetTitle not supported in TabChild");
 
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetTitle(const PRUnichar* aTitle)
 {
-  NS_NOTREACHED("TabChild::SetTitle not supported in TabChild");
-
-  return NS_ERROR_NOT_IMPLEMENTED;
+  // FIXME/bug 617804: should the platform support this?
+  return NS_OK;
 }
 
 NS_IMETHODIMP
 TabChild::GetSiteWindow(void** aSiteWindow)
 {
   NS_NOTREACHED("TabChild::GetSiteWindow not supported in TabChild");
 
   return NS_ERROR_NOT_IMPLEMENTED;