Bug 617637 nsTableFrame::PushChildren imagines it can pass null to [@ nsFrameList::RemoveFrame] violating its preconditions
authortimeless@mozdev.org
Thu, 09 Dec 2010 11:57:03 +0100
changeset 58965 2fc586fe32509c4b2a9f28f2a01899960ba63290
parent 58964 d03bbf388b4c3d4f91a496e8cb574fcbded70c91
child 58966 bffd8632295e77ab94c3c41ceb0870cb8e9003fe
push id1
push usershaver@mozilla.com
push dateTue, 04 Jan 2011 17:58:04 +0000
bugs617637
milestone2.0b8pre
Bug 617637 nsTableFrame::PushChildren imagines it can pass null to [@ nsFrameList::RemoveFrame] violating its preconditions r=bz
layout/tables/nsTableFrame.cpp
--- a/layout/tables/nsTableFrame.cpp
+++ b/layout/tables/nsTableFrame.cpp
@@ -1948,17 +1948,17 @@ nsTableFrame::PushChildren(const RowGrou
 {
   NS_PRECONDITION(aPushFrom > 0, "pushing first child");
 
   // extract the frames from the array into a sibling list
   nsFrameList frames;
   PRUint32 childX;
   for (childX = aPushFrom; childX < aRowGroups.Length(); ++childX) {
     nsTableRowGroupFrame* rgFrame = aRowGroups[childX];
-    if (!rgFrame || !rgFrame->IsRepeatable()) {
+    if (!rgFrame->IsRepeatable()) {
       mFrames.RemoveFrame(rgFrame);
       frames.AppendFrame(nsnull, rgFrame);
     }
   }
 
   if (frames.IsEmpty()) {
     return;
   }