No bug - Fix comments to match code. DONTBUILD
authorDavid Major <dmajor@mozilla.com>
Tue, 29 Nov 2016 15:28:11 -0600
changeset 324733 f0d6ed7b1ebe5564332df5d0dcec9c3438f7a4f8
parent 324732 f1cb42c8da5b70ea5f5391c6c3a78af914426725
child 324734 cdff330f17a4922320f37bffb50109cbc9c0fc81
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
bugs995704
milestone53.0a1
No bug - Fix comments to match code. DONTBUILD This code has been moved around several times, but it originated in bug 995704. Comments 20 and later indicate that the value was changed from 1k to 4k per review, and the code comments weren't updated. MozReview-Commit-ID: JQjoWq1jGF9
js/src/jit/x64/MacroAssembler-x64.cpp
js/src/jit/x86/MacroAssembler-x86.cpp
--- a/js/src/jit/x64/MacroAssembler-x64.cpp
+++ b/js/src/jit/x64/MacroAssembler-x64.cpp
@@ -419,17 +419,17 @@ MacroAssemblerX64::asMasm() const
 
 void
 MacroAssembler::subFromStackPtr(Imm32 imm32)
 {
     if (imm32.value) {
         // On windows, we cannot skip very far down the stack without touching the
         // memory pages in-between.  This is a corner-case code for situations where the
         // Ion frame data for a piece of code is very large.  To handle this special case,
-        // for frames over 1k in size we allocate memory on the stack incrementally, touching
+        // for frames over 4k in size we allocate memory on the stack incrementally, touching
         // it as we go.
         //
         // When the amount is quite large, which it can be, we emit an actual loop, in order
         // to keep the function prologue compact.  Compactness is a requirement for eg
         // Wasm's CodeRange data structure, which can encode only 8-bit offsets.
         uint32_t amountLeft = imm32.value;
         uint32_t fullPages = amountLeft / 4096;
         if (fullPages <= 8) {
--- a/js/src/jit/x86/MacroAssembler-x86.cpp
+++ b/js/src/jit/x86/MacroAssembler-x86.cpp
@@ -326,17 +326,17 @@ MacroAssemblerX86::asMasm() const
 
 void
 MacroAssembler::subFromStackPtr(Imm32 imm32)
 {
     if (imm32.value) {
         // On windows, we cannot skip very far down the stack without touching the
         // memory pages in-between.  This is a corner-case code for situations where the
         // Ion frame data for a piece of code is very large.  To handle this special case,
-        // for frames over 1k in size we allocate memory on the stack incrementally, touching
+        // for frames over 4k in size we allocate memory on the stack incrementally, touching
         // it as we go.
         //
         // When the amount is quite large, which it can be, we emit an actual loop, in order
         // to keep the function prologue compact.  Compactness is a requirement for eg
         // Wasm's CodeRange data structure, which can encode only 8-bit offsets.
         uint32_t amountLeft = imm32.value;
         uint32_t fullPages = amountLeft / 4096;
         if (fullPages <= 8) {