Bug 1274503 part.1 AKEYCODE_ASSIST shouldn't be mapped to "Help" r=smaug
authorMasayuki Nakano <masayuki@d-toybox.com>
Fri, 04 Nov 2016 21:08:04 +0900
changeset 325100 bdc033e3624b30fb6af96a015f44ecf11bd022d9
parent 325099 46b896e481eb216c5410d0bc31ff7e1c5c30393a
child 325101 9b70d74e63f8b5c7f7d3b5aa7a4c3212fc5cd0ff
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewerssmaug
bugs1274503
milestone53.0a1
Bug 1274503 part.1 AKEYCODE_ASSIST shouldn't be mapped to "Help" r=smaug I mapped AKEYCODE_ASSIST to "Help". However, Chromium doesn't map the keycode to anything. Additionally, Android has a new keycode AKEYCODE_HELP and Chromium maps it to "Help". So, we should use Chromium's mapping for it. MozReview-Commit-ID: 19zTP0xclYI
widget/NativeKeyToDOMKeyName.h
--- a/widget/NativeKeyToDOMKeyName.h
+++ b/widget/NativeKeyToDOMKeyName.h
@@ -358,17 +358,16 @@ KEY_MAP_GTK     (Execute, GDK_Execute)
 KEY_MAP_WIN_CMD (Find, APPCOMMAND_FIND)
 KEY_MAP_GTK     (Find, GDK_Find)
 
 // Help
 KEY_MAP_WIN     (Help, VK_HELP)
 KEY_MAP_WIN_CMD (Help, APPCOMMAND_HELP)
 KEY_MAP_COCOA   (Help, kVK_Help)
 KEY_MAP_GTK     (Help, GDK_Help)
-KEY_MAP_ANDROID (Help, AKEYCODE_ASSIST)
 
 // Pause
 KEY_MAP_WIN     (Pause, VK_PAUSE)
 KEY_MAP_GTK     (Pause, GDK_Pause)
 // Break is typically mapped to Alt+Pause or Ctrl+Pause on GTK.
 KEY_MAP_GTK     (Pause, GDK_Break)
 KEY_MAP_ANDROID (Pause, AKEYCODE_BREAK)