Fix the access key conflict in the password manager prompt (bug 1279586). r=johannh
authorPanos Astithas <past@mozilla.com>
Wed, 23 Nov 2016 12:27:08 +0200
changeset 324000 966bed7e5627ebe5c165f202b62d90f285e78b27
parent 323999 5eb33f6f7c54a71062f94538fe5c15e08e350f0c
child 324001 d64d6d962c6712996f0c4f13f22ca7c50d62fbcb
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewersjohannh
bugs1279586
milestone53.0a1
Fix the access key conflict in the password manager prompt (bug 1279586). r=johannh MozReview-Commit-ID: 3XquO7Evzgb
toolkit/components/passwordmgr/nsLoginManagerPrompter.js
toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
--- a/toolkit/components/passwordmgr/nsLoginManagerPrompter.js
+++ b/toolkit/components/passwordmgr/nsLoginManagerPrompter.js
@@ -957,17 +957,17 @@ LoginManagerPrompter.prototype = {
           Services.logins.setLoginSavingEnabled(login.hostname, false);
           browser.focus();
         }
       });
     }
 
     let usernamePlaceholder = this._getLocalizedString("noUsernamePlaceholder");
     let togglePasswordLabel = this._getLocalizedString("togglePasswordLabel");
-    let togglePasswordAccessKey = this._getLocalizedString("togglePasswordAccessKey");
+    let togglePasswordAccessKey = this._getLocalizedString("togglePasswordAccessKey2");
 
     this._getPopupNote().show(
       browser,
       "password",
       promptMsg,
       "password-notification-icon",
       mainAction,
       secondaryActions,
--- a/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
+++ b/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
@@ -25,17 +25,17 @@ updateLoginButtonDeny.accesskey = D
 rememberPasswordMsg = Would you like to remember the password for ā€œ%1$Sā€ on %2$S?
 # LOCALIZATION NOTE (rememberPasswordMsgNoUsername):
 # String is the login's hostname.
 rememberPasswordMsgNoUsername = Would you like to remember the password on %S?
 # LOCALIZATION NOTE (noUsernamePlaceholder):
 # This is displayed in place of the username when it is missing.
 noUsernamePlaceholder=No username
 togglePasswordLabel=Show password
-togglePasswordAccessKey=S
+togglePasswordAccessKey2=h
 notNowButtonText = &Not Now
 notifyBarNotNowButtonText = Not Now
 notifyBarNotNowButtonAccessKey = N
 neverForSiteButtonText = Ne&ver for This Site
 notifyBarNeverRememberButtonText2 = Never Save
 notifyBarNeverRememberButtonAccessKey2 = e
 rememberButtonText = &Remember
 notifyBarRememberPasswordButtonText = Remember Password