Bug 1321509 - Remove unused parameters from node-highlight event;r=pbro
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 28 Nov 2016 22:47:02 +0100
changeset 325356 91e1d8b0cdeb577c888e1522996bc020e57961e7
parent 325355 e858457cd353e01efb0e717e081844d24f4569e6
child 325357 79b6b6ff9a1b07b2a1b76c933c38a4daebc40e42
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewerspbro
bugs1321509
milestone53.0a1
Bug 1321509 - Remove unused parameters from node-highlight event;r=pbro The last parameter sent with the node-highlight event is never used. Also toSource is a Firefox only API, in the context of devtools-html it would be nice to get rid of it. MozReview-Commit-ID: E80utdu80Sn
devtools/client/framework/toolbox-highlighter-utils.js
--- a/devtools/client/framework/toolbox-highlighter-utils.js
+++ b/devtools/client/framework/toolbox-highlighter-utils.js
@@ -235,17 +235,17 @@ exports.getHighlighterUtils = function (
     if (isRemoteHighlightable()) {
       yield toolbox.highlighter.showBoxModel(nodeFront, options);
     } else {
       // If the target doesn't have the highlighter actor, revert to the
       // walker's highlight method, which draws a simple outline
       yield toolbox.walker.highlight(nodeFront);
     }
 
-    toolbox.emit("node-highlight", nodeFront, options.toSource());
+    toolbox.emit("node-highlight", nodeFront);
   });
 
   /**
    * This is a convenience method in case you don't have a nodeFront but a
    * valueGrip. This is often the case with VariablesView properties.
    * This method will simply translate the grip into a nodeFront and call
    * highlightNodeFront, so it has the same signature.
    * @see highlightNodeFront