Bug 1319595, part 6 - Fix various IPDL tests. r=billm
authorAndrew McCreight <continuation@gmail.com>
Tue, 22 Nov 2016 15:26:08 -0800
changeset 324561 860dbe58e7f9694e5bcde96b8e38b3b4aa15e401
parent 324560 967d7be10d7a1ceea948a1b1e46d58ec76e8b07f
child 324562 229182531a7f214651358fba001dd15ff8862eb0
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewersbillm
bugs1319595
milestone53.0a1
Bug 1319595, part 6 - Fix various IPDL tests. r=billm managerNoCtor.ipdl: Add a message so that parsing doesn't just fail immediately with a syntax error. shmem_access_union.ipdl: Remove this test, which involves the semi-removed ACL feature for shmem. oldIncludesyntax.ipdl: To be safe, make the protocol more valid by adding a message. multimanNonexistentMgrs.ipdl: Make the name of the protocol match the name of the file. MozReview-Commit-ID: 9zx5fmAWIIc
ipc/ipdl/test/ipdl/error/managerNoCtor.ipdl
ipc/ipdl/test/ipdl/error/multimanNonexistentMgrs.ipdl
ipc/ipdl/test/ipdl/error/oldIncludeSyntax.ipdl
ipc/ipdl/test/ipdl/error/shmem_access_union.ipdl
--- a/ipc/ipdl/test/ipdl/error/managerNoCtor.ipdl
+++ b/ipc/ipdl/test/ipdl/error/managerNoCtor.ipdl
@@ -1,8 +1,10 @@
 include protocol managedNoCtor;
 
 protocol managerNoCtor {
     manages managedNoCtor;
 
 parent:
     // error: no ctor defined
+    async __delete__();
+    // We need at least one message declared so we don't just hit a syntax error.
 };
--- a/ipc/ipdl/test/ipdl/error/multimanNonexistentMgrs.ipdl
+++ b/ipc/ipdl/test/ipdl/error/multimanNonexistentMgrs.ipdl
@@ -1,7 +1,7 @@
-protocol multimanNonexistentManagers {
+protocol multimanNonexistentMgrs {
     manager Starsky or Hutch;
 
 child:
     async Dummy();
     async __delete__();
 };
--- a/ipc/ipdl/test/ipdl/error/oldIncludeSyntax.ipdl
+++ b/ipc/ipdl/test/ipdl/error/oldIncludeSyntax.ipdl
@@ -1,5 +1,5 @@
 include protocol "Foo.ipdl";
 
 protocol oldIncludeSyntax {
-
+child: async __delete__(X x);
 };
deleted file mode 100644
--- a/ipc/ipdl/test/ipdl/error/shmem_access_union.ipdl
+++ /dev/null
@@ -1,8 +0,0 @@
-union Union {
-    [-r-w|+r+w] Shmem;
-};
-
-protocol shmem_access_union {
-child:
-    async Msg(Union u);
-};