Bug 1317796 - Rebucket and rename GPU_PROCESS_LAUNCH_TIME_MS to cater for launch times up to 64000ms r=dvander data-review=bsmedberg
authorGeorge Wright <george@mozilla.com>
Fri, 02 Dec 2016 14:59:03 -0500
changeset 325444 3ea1f28bd0f3b021b40693d6a3a6f944a9e82420
parent 325443 febbbdc0273edf0cf7da1cc9de046a9c58625292
child 325445 b3b5af78a162b11a9a838087c0f6ad3567eeb55e
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewersdvander
bugs1317796
milestone53.0a1
Bug 1317796 - Rebucket and rename GPU_PROCESS_LAUNCH_TIME_MS to cater for launch times up to 64000ms r=dvander data-review=bsmedberg
gfx/ipc/GPUChild.cpp
toolkit/components/telemetry/Histograms.json
--- a/gfx/ipc/GPUChild.cpp
+++ b/gfx/ipc/GPUChild.cpp
@@ -77,30 +77,30 @@ GPUChild::EnsureGPUReady()
   if (mGPUReady) {
     return;
   }
 
   GPUDeviceData data;
   SendGetDeviceStatus(&data);
 
   gfxPlatform::GetPlatform()->ImportGPUDeviceData(data);
-  Telemetry::AccumulateTimeDelta(Telemetry::GPU_PROCESS_LAUNCH_TIME_MS, mHost->GetLaunchTime());
+  Telemetry::AccumulateTimeDelta(Telemetry::GPU_PROCESS_LAUNCH_TIME_MS_2, mHost->GetLaunchTime());
   mGPUReady = true;
 }
 
 mozilla::ipc::IPCResult
 GPUChild::RecvInitComplete(const GPUDeviceData& aData)
 {
   // We synchronously requested GPU parameters before this arrived.
   if (mGPUReady) {
     return IPC_OK();
   }
 
   gfxPlatform::GetPlatform()->ImportGPUDeviceData(aData);
-  Telemetry::AccumulateTimeDelta(Telemetry::GPU_PROCESS_LAUNCH_TIME_MS, mHost->GetLaunchTime());
+  Telemetry::AccumulateTimeDelta(Telemetry::GPU_PROCESS_LAUNCH_TIME_MS_2, mHost->GetLaunchTime());
   mGPUReady = true;
   return IPC_OK();
 }
 
 mozilla::ipc::IPCResult
 GPUChild::RecvReportCheckerboard(const uint32_t& aSeverity, const nsCString& aLog)
 {
   layers::CheckerboardEventStorage::Report(aSeverity, std::string(aLog.get()));
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -939,23 +939,23 @@
   },
   "GEOLOCATION_WATCHPOSITION_VISIBLE": {
     "alert_emails": ["michelangelo@mozilla.com"],
     "expires_in_version": "55",
     "kind": "boolean",
     "bug_numbers": [1255198],
     "description": "This metric is recorded every time a navigator.geolocation.watchPosition() request gets allowed/fulfilled. A false value is recorded if the owner is not visible according to document.isVisible."
   },
-  "GPU_PROCESS_LAUNCH_TIME_MS" : {
+  "GPU_PROCESS_LAUNCH_TIME_MS_2" : {
     "alert_emails": ["george@mozilla.com", "danderson@mozilla.com"],
     "expires_in_version": "never",
-    "bug_numbers": [1297790],
-    "kind": "exponential",
-    "high": 1000,
-    "n_buckets": 50,
+    "bug_numbers": [1297790, 1317796],
+    "kind": "exponential",
+    "high": 64000,
+    "n_buckets": 100,
     "releaseChannelCollection": "opt-out",
     "description": "GPU process launch time in milliseconds"
   },
   "JS_DEPRECATED_LANGUAGE_EXTENSIONS_IN_CONTENT": {
     "alert_emails": ["jdemooij@mozilla.com"],
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 10,