Bug 1312434 - Post: cleanup obsolete layout params r=sebastian
authorAndrzej Hunt <ahunt@mozilla.com>
Tue, 08 Nov 2016 08:50:33 -0500
changeset 321595 39feb13d796211eb37dda17e3b2c74a5ea283aa6
parent 321594 37a28e758b41ed01d3bb11f7f2442b564c94f0af
child 321596 ef393dc07cb861db2bdc19a7635b3f3cdec8bc6d
push id21
push usermaklebus@msu.edu
push dateThu, 01 Dec 2016 06:22:08 +0000
reviewerssebastian
bugs1312434
milestone52.0a1
Bug 1312434 - Post: cleanup obsolete layout params r=sebastian These were leftover from when the toppanel was a RelativeLayout. (Leaving these also causes lint to complain, the paramters are however ignored by LinearLayout.) MozReview-Commit-ID: HTZvo2fnqVj
mobile/android/base/resources/layout/activity_stream_main_highlightstitle.xml
mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
--- a/mobile/android/base/resources/layout/activity_stream_main_highlightstitle.xml
+++ b/mobile/android/base/resources/layout/activity_stream_main_highlightstitle.xml
@@ -18,13 +18,11 @@
         android:layout_marginBottom="@dimen/activity_stream_base_margin"
         android:layout_marginRight="@dimen/activity_stream_base_margin"
         android:layout_marginEnd="@dimen/activity_stream_base_margin"
         android:text="@string/activity_stream_highlights"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:textStyle="bold"
         android:textSize="16sp"
-        android:textColor="#FF858585"
-        android:layout_alignParentLeft="true"
-        android:layout_alignParentStart="true" />
+        android:textColor="#FF858585" />
 
-</LinearLayout>
\ No newline at end of file
+</LinearLayout>
--- a/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
+++ b/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
@@ -6,26 +6,21 @@
     android:layout_height="wrap_content"
     android:orientation="vertical">
 
     <android.support.v4.view.ViewPager
         android:layout_marginTop="10dp"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:id="@+id/topsites_pager"
-        android:contentDescription="@string/activity_stream_topsites"
-        android:layout_alignParentTop="true"
-        android:layout_alignParentLeft="true"
-        android:layout_alignParentStart="true"/>
+        android:contentDescription="@string/activity_stream_topsites" />
 
     <org.mozilla.gecko.home.activitystream.topsites.CirclePageIndicator
         android:id="@+id/topsites_indicator"
         android:padding="10dip"
         app:fillColor="#ff9d9d9d"
         app:pageColor="#FFFFFF"
         app:strokeWidth="1dp"
         app:radius="2dp"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_alignParentRight="true"
-        android:layout_alignParentEnd="true"/>
+        android:layout_height="wrap_content" />
 
-</LinearLayout>
\ No newline at end of file
+</LinearLayout>