Bug 1321412 - Fix a bug in the definition of SizeTyped. r=kats
☠☠ backed out by 284e73444c60 ☠ ☠
authorBotond Ballo <botond@mozilla.com>
Wed, 23 Nov 2016 19:26:55 -0500
changeset 325540 34a1640010d698cb36b2ca74e4b0fffcdda6d4eb
parent 325539 a3fe137d4d47d0d8c897bcb81d6ed1201a5dde89
child 325541 31f15a3b5ce0e02ce66d7ed04fa6055853749d20
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewerskats
bugs1321412
milestone53.0a1
Bug 1321412 - Fix a bug in the definition of SizeTyped. r=kats A second template parameter 'F' was previously added to SizeTyped, but was not correspondingly added to the argument passed for the 'Sub' parameter of BaseSize. MozReview-Commit-ID: 2pRQXeWMJpP
gfx/2d/Point.h
--- a/gfx/2d/Point.h
+++ b/gfx/2d/Point.h
@@ -280,17 +280,17 @@ struct IntSizeTyped :
   IntSizeTyped<UnknownUnits> ToUnknownSize() const {
     return IntSizeTyped<UnknownUnits>(this->width, this->height);
   }
 };
 typedef IntSizeTyped<UnknownUnits> IntSize;
 
 template<class units, class F = Float>
 struct SizeTyped :
-  public BaseSize< F, SizeTyped<units> >,
+  public BaseSize< F, SizeTyped<units, F> >,
   public units {
   static_assert(IsPixel<units>::value,
                 "'units' must be a coordinate system tag");
 
   typedef BaseSize< F, SizeTyped<units, F> > Super;
 
   constexpr SizeTyped() : Super() {}
   constexpr SizeTyped(F aWidth, F aHeight) : Super(aWidth, aHeight) {}