Bug 1319937 - Remove String generics uses in services/sync. r=markh
authorAndré Bargull <andre.bargull@gmail.com>
Thu, 24 Nov 2016 13:17:08 -0800
changeset 324747 2a34ba3cdc1d9c7158cb43bad2eb622dc72f9542
parent 324746 1219cdda749644daba4e836c146f8067215900d0
child 324748 5897fbfa16c965eed37783bbe0c2edfd919edcf6
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewersmarkh
bugs1319937
milestone53.0a1
Bug 1319937 - Remove String generics uses in services/sync. r=markh
services/sync/tests/unit/test_bookmark_validator.js
--- a/services/sync/tests/unit/test_bookmark_validator.js
+++ b/services/sync/tests/unit/test_bookmark_validator.js
@@ -327,17 +327,17 @@ add_task(async function test_telemetry_i
   let ping = await validationPing(server, client, duration);
   ok(ping.engines);
   let bme = ping.engines.find(e => e.name === "bookmarks");
   ok(bme);
   ok(bme.validation);
   ok(bme.validation.problems)
   equal(bme.validation.checked, server.length);
   equal(bme.validation.took, duration);
-  bme.validation.problems.sort((a, b) => String.localeCompare(a.name, b.name));
+  bme.validation.problems.sort((a, b) => String(a.name).localeCompare(b.name));
   equal(bme.validation.version, new BookmarkValidator().version);
   deepEqual(bme.validation.problems, [
     { name: "badClientRoots", count: 3 },
     { name: "sdiff:childGUIDs", count: 1 },
     { name: "serverMissing", count: 1 },
     { name: "structuralDifferences", count: 1 },
   ]);
 });