Bug 1321010 - Remove two minor bits of deritrus from IPDL Python code. r=kanru
authorAndrew McCreight <continuation@gmail.com>
Mon, 28 Nov 2016 15:16:57 -0800
changeset 325104 1e40fb1d78e33faa55545a4c51429458eeb9678e
parent 325103 6c0fb6a93e904b4db0e0821ad5471320586551b1
child 325105 e907fb6bfcfe40e6c4b28c406f8784c4b919ba2c
push id24
push usermaklebus@msu.edu
push dateTue, 20 Dec 2016 03:11:33 +0000
reviewerskanru
bugs1321010
milestone53.0a1
Bug 1321010 - Remove two minor bits of deritrus from IPDL Python code. r=kanru The bug referred to in the comment was fixed 6 years ago. The includes in cgen.py are unused.
ipc/ipdl/ipdl/cgen.py
ipc/ipdl/ipdl/type.py
--- a/ipc/ipdl/ipdl/cgen.py
+++ b/ipc/ipdl/ipdl/cgen.py
@@ -1,16 +1,15 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os, sys
 
 from ipdl.ast import Visitor
-from ipdl.ast import IN, OUT, INOUT, ASYNC, SYNC, INTR
 
 class CodePrinter:
     def __init__(self, outf=sys.stdout, indentCols=4):
         self.outf = outf
         self.col = 0
         self.indentCols = indentCols
 
     def write(self, str):
--- a/ipc/ipdl/ipdl/type.py
+++ b/ipc/ipdl/ipdl/type.py
@@ -1445,18 +1445,16 @@ class CheckTypes(TcheckVisitor):
         if not mgstype.isManagedBy(ptype):
             self.error(
                 loc,
                 "|manages| declaration in protocol `%s' does not match any |manager| declaration in protocol `%s'",
                 pname, mgsname)
 
 
     def visitManager(self, mgr):
-        # FIXME/bug 541126: check that the protocol graph is acyclic
-
         pdecl = mgr.of.decl
         ptype, pname = pdecl.type, pdecl.shortname
 
         mgrdecl = mgr.decl
         mgrtype, mgrname = mgrdecl.type, mgrdecl.shortname
 
         # we added this information; sanity check it
         assert ptype.isManagedBy(mgrtype)