searching for reviewer(sebastian)
1cce3b69bfc76377f5a0c015372d790b81f7b2bd: Bug 1321418 - Use GekcoBundle events in GeckoApp/BrowserApp; r=snorp r=sebastian r=gbrown
Jim Chen <nchen@mozilla.com> - Fri, 09 Dec 2016 12:32:45 -0500 - rev 325598
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321418 - Use GekcoBundle events in GeckoApp/BrowserApp; r=snorp r=sebastian r=gbrown Bug 1321418 - 1. Use GekcoBundle events in GeckoApp; r=snorp r=sebastian Switch GeckoApp to using GeckoBundle events everywhere. UI or Gecko events are used if the event requires the UI or Gecko thread, respectively, and background events are used for all other events. There are changes to some other Java classes, such as SnackbarBuilder and GeckoAccessibility, due to the switch to GeckoBundle. For "Snackbar:Show", we need the global EventDispatcher because the event can be sent to both GeckoApp and GeckoPreferences. Howveer, we only want one listener registered at the same time, so we register and unregister in GeckoApp's and GeckoPreferences's onPause and onResume methods. Bug 1321418 - 2. Use appropriate JS EventDispatcher to send GeckoApp events; r=snorp r=sebastian Change JS code that sends events to GeckoApp to use either the global EventDispatcher or the per-window EventDispatcher. "Session:StatePurged" is not used so it's removed. "Gecko:Ready" in geckoview.js is not necessary because it's only used for GeckoApp, so it's removed from geckoview.js. Bug 1321418 - 3. Use GeckoBundle events in BrowserApp; r=snorp r=sebastian Switch BrowserApp to using GeckoBundle events, in a similar vein as GeckoApp. UI or Gecko events are used if the event handlers required UI or Gecko thread, respectively, and background events are used for all other events. Some other Java classes also have to be modified as a result of switching to GeckoBundle. Bug 1321418 - 4. Use global EventDispatcher to send BrowserApp events; r=snorp r=sebastian Change JS code that sends events to BrowserApp to use the global EventDispatcher instead of "Messaging". Bug 1321418 - 5. Update usages of events in tests; r=gbrown Update cases where we use or wait for events in tests.
88e0fb654a104419dd66774d422b20692639919e: Bug 1202861 - 2. Refresh tabs panel when compact tabs configuration changes. r=sebastian
Tom Klein <twointofive@gmail.com> - Mon, 28 Nov 2016 09:27:24 -0600 - rev 325434
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1202861 - 2. Refresh tabs panel when compact tabs configuration changes. r=sebastian MozReview-Commit-ID: HV9EQcLtCrE
4de97a01678bc55bf39daea37fd487ec52e5714c: Bug 1202861 - 1. Create compact (two column) tabs tray option for portrait mode phones. r=sebastian
Tom Klein <twointofive@gmail.com> - Tue, 29 Nov 2016 13:22:37 -0600 - rev 325433
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1202861 - 1. Create compact (two column) tabs tray option for portrait mode phones. r=sebastian Changing the setting currently won't take effect until you rotate the tabs panel (to cause it to be recreated); that will be fixed in the next commit. MozReview-Commit-ID: HZfQRy8zubV
594afa97ff78d3f2814f3710719b32b25b1640e9: Bug 1320605 - The shrunk height just nee to cover the text itself. r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Fri, 02 Dec 2016 11:12:24 +0800 - rev 325405
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320605 - The shrunk height just nee to cover the text itself. r=sebastian MozReview-Commit-ID: BdoLEOKjvxw
ff3a2aebe47d050ba5bbef5cf2cc9848c49dc821: Bug 1321799 - Use decimal format placeholder for filesize r=sebastian
Andrzej Hunt <ahunt@mozilla.com> - Fri, 02 Dec 2016 21:57:33 -0800 - rev 325310
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321799 - Use decimal format placeholder for filesize r=sebastian %l seems to be for hour in 12hr clock (i.e. 1-12), but we're applying it to a filesize. %d seems more appropriate in order to display the actual raw filesize. MozReview-Commit-ID: AKTpYndm81o
73cbeef4f94009a35a082b62d18196664df6965f: Bug 1317326 - Pause media playing when headset unplugged, r=alwu,sebastian
maliu <max@mxli.us> - Fri, 25 Nov 2016 21:23:05 +0800 - rev 325253
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317326 - Pause media playing when headset unplugged, r=alwu,sebastian MozReview-Commit-ID: GHdFWPgPum1
4c969c7c1c2221e2e9c3da63b1153ddbaf1378f5: Bug 1314835: Add more debug information to TelemetryPingStore r=sebastian
Julian_Chu <walkingice0204@gmail.com> - Tue, 15 Nov 2016 14:35:59 +0800 - rev 324937
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1314835: Add more debug information to TelemetryPingStore r=sebastian So far still cannot find the reason of causing exception. To add more debug information to make sure it is not permssion problem. MozReview-Commit-ID: 7hhU7Et64Qs
e7ae0014cb1e50baaead4a0dee1dc2d014390724: Bug 1320603 - Revert to global EventDispatcher for certain events; r=sebastian
Jim Chen <nchen@mozilla.com> - Wed, 30 Nov 2016 14:01:20 -0500 - rev 324833
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320603 - Revert to global EventDispatcher for certain events; r=sebastian These events are not accessed through GeckoApp, and should therefore use the global EventDispatcher rather than the per-GeckoApp/GeckoView EventDispatcher. Otherwise, we could run into situations where we end up registering / unregistering the same event using different EventDispatcher instances, causing exceptions like this one.
3118e664715ba656a1f9fde28cb61d22efd5c4f7: Bug 1320449 - Enable keyboard text prediction on the awesome bar during normal browsing. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 26 Nov 2016 15:14:22 +0100 - rev 324797
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320449 - Enable keyboard text prediction on the awesome bar during normal browsing. r=sebastian MozReview-Commit-ID: 17xMoyDhYmn
539af8b2ccc96cfb689534178b1e59cd9cf8ba95: Bug 1318171 - Catch all throwables in SearchEngineManager.createEngineFromLocale; r=sebastian
Geoff Brown <gbrown@mozilla.com> - Tue, 29 Nov 2016 16:51:31 -0700 - rev 324758
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318171 - Catch all throwables in SearchEngineManager.createEngineFromLocale; r=sebastian
26551118afb7716ed8f789acf84487c9f184286c: Bug 1320143 - Remove String generics uses in mobile/android/chrome/content. r=sebastian
André Bargull <andre.bargull@gmail.com> - Thu, 24 Nov 2016 13:18:09 -0800 - rev 324755
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320143 - Remove String generics uses in mobile/android/chrome/content. r=sebastian
5e8406f38c0936d8626a9dc0debc23b5ea7138bd: Bug 1319496 - 5. Change prompt response to use GeckoBundle; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 324721
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319496 - 5. Change prompt response to use GeckoBundle; r=sebastian Change prompt response from using JSONObject/String to using GeckoBundle. The GeckoBundle is automatically translated to a JS object, like before, when dispatched to JS code.
16dbb57af3e2888827ef2db6d6e17d28cdab1379: Bug 1319496 - 4. Fix context menu item IDs; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 324720
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319496 - 4. Fix context menu item IDs; r=sebastian Context menu items used UUIDs as their prompt list item IDs. However, prompt list items only support integers as IDs. This error didn't show up before because JSONObject was silently ignoring the error. This patch changes to using an incremental integer as the ID and fixes the error.
10a6565daede03fcb1b5d4c7bfbfa499dfec404c: Bug 1319496 - 3. Convert prompts to BundleEventListener; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 29 Nov 2016 12:25:53 -0500 - rev 324719
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319496 - 3. Convert prompts to BundleEventListener; r=sebastian Convert prompts to use BundleEventListener and GeckoBundle. DefaultDoorHanger.setOptions accepts a JSONObject argument, but if we converted it to GeckoBundle, it would involve a lot of extra changes in the other doorhanger code. So this patch adds GeckoBundle.fromJSONObject and converts JSONObject to GeckoBundle within DefaultDoorHanger.setOptions. In the future, another patch would convert all doorhanger code to use GeckoBundle instead of JSONObject.
e6459d80bf245d1f5e2f46bda884878548d58126: Bug 1316005 - fixed unused methods, made methods use actual signature and added @Override; r=sebastian
Tomislav Jurin <svezauzeto12@hotmail.com> - Thu, 24 Nov 2016 22:30:04 +0100 - rev 324714
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316005 - fixed unused methods, made methods use actual signature and added @Override; r=sebastian
d2b817bfed7cda483903914bff356dc1e73ff05d: Bug 1321002 - Reduce total space at top and bottom of tabs grid panels. r=sebastian
Tom Klein <twointofive@gmail.com> - Mon, 28 Nov 2016 14:58:09 -0600 - rev 324688
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321002 - Reduce total space at top and bottom of tabs grid panels. r=sebastian Previously for the spacing at the top and bottom of the tabs grid panel we had the total desired vertical spacing set on the RecyclerView padding, but then there was also an additional half spacing coming from the ItemDecoration padding in the top and bottom rows. Here we decrease the RecyclerView vertical padding to account for the ItemDecoration vertical padding. The alternative route of keeping full RecyclerView padding and then having the ItemDecoration adjust itself depending on its position turned out to not "just work": for example, if span count is three and you have four tabs, then the first three tabs have half padding along their bottoms (since there are two rows), but then when you close tab 4, there's now only one row and so the three tabs should have no padding along their bottoms (since the RecyclerView already has its own full padding), *but only tab 3 gets its ItemDecoration updated automatically*, so it gets 0 bottom padding, but its row still has other tabs with half bottom padding, so a) there's still too much bottom padding in that row coming from tabs 1 and 2, and b) tab 3 sits too far down in its space because it doesn't have the bottom padding that tabs 1 and 2 do. That issue could be fixed by updating all ItemDecorations after each close, but the patch here is both simpler and leads to less runtime work. MozReview-Commit-ID: 2WeZ6QdfIF4
dcdee53249e1afe2cc62b50dcdfe5a1f5f2dcd3d: Bug 1316023 - Version 2 of fixes. Removed unreachable statements. r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Mon, 21 Nov 2016 20:00:31 -0500 - rev 324684
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316023 - Version 2 of fixes. Removed unreachable statements. r=sebastian MozReview-Commit-ID: 5gQEJVmboOr
b37f2a4bd333912ef621d3fb3f85d0df14473dd6: Bug 1316012 - Remove unnecessary boxing/unboxing; r=sebastian
Shan <11812r@gmail.com> - Sat, 26 Nov 2016 11:24:00 +0530 - rev 324683
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316012 - Remove unnecessary boxing/unboxing; r=sebastian MozReview-Commit-ID: 6k9d86ioK70
be6f5b8a484e90088ec40f4ae18a5e009e1979ec: Bug 1318663 - Don't skip load start tab during tab restore if incoming action of intent is VIEW with non-external URL. r=JanH,sebastian
maliu <max@mxli.us> - Tue, 29 Nov 2016 02:25:29 +0800 - rev 324575
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318663 - Don't skip load start tab during tab restore if incoming action of intent is VIEW with non-external URL. r=JanH,sebastian MozReview-Commit-ID: 4DAYikBnzz2
6b4ddaf6c2762ba93489f69a28b781abd8e702eb: Bug 1320564 - Fix the default value logic for "selected" when creating a new tab. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Nov 2016 18:46:53 +0100 - rev 324574
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320564 - Fix the default value logic for "selected" when creating a new tab. r=sebastian The idea is that cancelling edit mode when opening a new tab implies that we want to select it as well, otherwise we wouldn't have to cancel edit mode in the first place. MozReview-Commit-ID: Gova1ymzlHn
bcc32212520f87444003cea288b248b6c6e37c4b: Bug 1320550 - Part 2 - Clear closed tabs when max_tabs_undo is set to 0. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Nov 2016 16:59:53 +0100 - rev 324533
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320550 - Part 2 - Clear closed tabs when max_tabs_undo is set to 0. r=sebastian Currently, we stop updating closed tabs if max_tabs_undo is set to 0, however we don't clear that data and carry it around indefinitely unless the user clears the browser history. This means that when closing a tab, we still show the "Undo close tab" snackbar, however with its contents referring to the last tab the user closed before setting browser.sessionstore.max_tabs_undo to 0. With this patch, we clear all closed tabs (and don't reload them from disc on startup) if max_tabs_undo is 0, which also stops the snackbar from showing after closing a tab. MozReview-Commit-ID: PEtminpW4B
849f80eca8e6f6a5cef250efd5510801606c1a53: Bug 1320550 - Part 1 - Only try showing the "Undo close tab" snackbar if we actually have some closed tab data. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 27 Nov 2016 16:44:38 +0100 - rev 324532
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320550 - Part 1 - Only try showing the "Undo close tab" snackbar if we actually have some closed tab data. r=sebastian This can happen if the users sets browser.sessionstore.max_tabs_undo to 0 - with no closed tabs available, without this fix the resulting exception breaks browser.js's closed tab handling, meaning the tab gets closed in the UI but not in Gecko. MozReview-Commit-ID: 7yMyIB6UzAB
0c9297cc0e465f5fbfabf8aba64daac9edd8baca: Bug 1316006 - Change implicit toString() to Arrays.toString(); r=sebastian
Shan <11812r@gmail.com> - Fri, 25 Nov 2016 16:50:49 +0530 - rev 324522
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316006 - Change implicit toString() to Arrays.toString(); r=sebastian MozReview-Commit-ID: Cgcc8UMNpCr
7e51bad5f8bdf26b6e0d09f55e49206ad9e11377: Bug 1316009 - Adding 'final' keyword to static fields where appropriate. r=sebastian
Tomislav Jurin <svezauzeto12@hotmail.com> - Fri, 25 Nov 2016 20:02:44 +0100 - rev 324456
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316009 - Adding 'final' keyword to static fields where appropriate. r=sebastian
5aa4b8d980786d55d1fda696329312f40cc33868: Bug 1318222 - Updated the unit test,added more test r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Thu, 17 Nov 2016 16:29:23 +0800 - rev 324390
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318222 - Updated the unit test,added more test r=sebastian MozReview-Commit-ID: 8PvSoPJQ88n
16b1dec1956fb81cada13fe80cf0c005b2a755e0: Bug 1318222 - Add a unit test r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Thu, 17 Nov 2016 14:44:10 +0800 - rev 324389
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318222 - Add a unit test r=sebastian MozReview-Commit-ID: Fv1e2dtPKut
dfa353352f30da222393cfd72a420ef26d556ebd: Bug 1314563 - Change state icon and message when url icon is clicked r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Mon, 21 Nov 2016 16:32:10 +0800 - rev 324235
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1314563 - Change state icon and message when url icon is clicked r=sebastian MozReview-Commit-ID: 5KDVFVse9Tu
36c0196cf2ef2b1753e464a1d29621003c3d7e2c: Bug 1314563 - Add info for Java to know when the url is in the exception list and show the correct icon r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Tue, 15 Nov 2016 09:47:12 +0800 - rev 324234
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1314563 - Add info for Java to know when the url is in the exception list and show the correct icon r=sebastian MozReview-Commit-ID: FG6a7mRCzZY
c08d0aa688dcd1d9e264da3ecf0a2bf1a81c6b28: Bug 1240560 - After shortcut is created, show the mobile desktop. r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Thu, 24 Nov 2016 10:57:19 +0800 - rev 324233
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1240560 - After shortcut is created, show the mobile desktop. r=sebastian MozReview-Commit-ID: 21YzmJfNC6E
df6b2f6295009fbe4158b8e3e703cede5e854ed2: Bug 1240560 - Extract goToHomeScreen() method to AcitvityUtils r=sebastian
Nevin Chen <cnevinchen@gmail.com> - Thu, 24 Nov 2016 10:54:49 +0800 - rev 324232
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1240560 - Extract goToHomeScreen() method to AcitvityUtils r=sebastian MozReview-Commit-ID: 5w4ywPhDtAy
49351d35d695abff020daa7a197516bbe511f972: Bug 1316017 - Remove redundant nullcheck calls. r=sebastian
Hamel Joshi <joshihamel@gmail.com> - Wed, 16 Nov 2016 09:12:00 -0500 - rev 324132
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316017 - Remove redundant nullcheck calls. r=sebastian
120c84ca53629202c22cce565053fee7973eea72: Bug 1319302 - RTL support for Firefox for Android, r=sebastian
maliu <max@mxli.us> - Fri, 11 Nov 2016 16:10:21 +0800 - rev 324054
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319302 - RTL support for Firefox for Android, r=sebastian MozReview-Commit-ID: bKzW07YBDy
59bfc010206650c3c6bff4c23f27bad632d57138: Bug 1310081 - 3. Add ItemDecoration to create fixed spacing items. r=sebastian
Tom Klein <twointofive@gmail.com> - Wed, 21 Sep 2016 22:51:27 -0500 - rev 324003
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1310081 - 3. Add ItemDecoration to create fixed spacing items. r=sebastian We switch to thinking of the tabs grid layout as being determined by specifying the spacing between the items, and then allowing the items themselves to expand to fill whatever room that leaves available, but we also allow the spacing to be adjusted to match the span counts of the previous GridLayout implementation (which is a good thing). MozReview-Commit-ID: L3fgjacMu2d
19f73951d4e542473ba819c3bcc5551b97ba4e22: Bug 1310081 - 2. Refactor TabsListTouchHelperCallback to support any swipe alpha function. r=sebastian
Tom Klein <twointofive@gmail.com> - Mon, 12 Sep 2016 11:01:08 -0500 - rev 324002
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1310081 - 2. Refactor TabsListTouchHelperCallback to support any swipe alpha function. r=sebastian MozReview-Commit-ID: HqKwdpArcMm
d64d6d962c6712996f0c4f13f22ca7c50d62fbcb: Bug 1310081 - 1. Make the tabs list grid view a RecyclerView. r=sebastian
Tom Klein <twointofive@gmail.com> - Mon, 12 Sep 2016 11:21:51 -0500 - rev 324001
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1310081 - 1. Make the tabs list grid view a RecyclerView. r=sebastian Our previous GridLayout settings gave extra horizontal space to the padding between items, but GridLayoutManager by default simply left aligns fixed width items in their column, so the item's width has been changed to fill_parent and the item title has been switched to fixed width (since otherwise it looks broken when it expands to an item width larger than the thumbnail width). The drawback is that clicking on the extra width part of an item activates the tab, even though it would seem from what's being displayed that the item should end at the vertical edge of the thumbnail - that will be fixed in a future commit. Both the list and grid tabs panel views are now RecyclerViews, so move TabsLayoutRecyclerAdapter.java to TabsLayoutAdapter.java. MozReview-Commit-ID: CBrxw1HfRcP
5bc8f7e5e1d21b230ee7e2ab92377a17f496b4de: Bug 1319173 - Register MediaPlayerManager events later; r=sebastian
Jim Chen <nchen@mozilla.com> - Tue, 22 Nov 2016 13:39:54 -0500 - rev 323861
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1319173 - Register MediaPlayerManager events later; r=sebastian Wait to register MediaPlayerManager events until we have a GeckoApp EventDispatcher, because we only have an EventDispatcher after we create the GeckoView in onCreate.
c3452e927deffea3a506d046a2e7998128b961dd: Bug 1291270 - Update updater string to distinguish from download and install more clearly, r=sebastian
maliu <max@mxli.us> - Tue, 22 Nov 2016 18:38:59 +0800 - rev 323797
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1291270 - Update updater string to distinguish from download and install more clearly, r=sebastian MozReview-Commit-ID: B4hR8aonESh
22411be95565f743e9287f188d425f5108435a24: Bug 1317604 - 1. Add EventDispatcher to Messaging.jsm; r=snorp r=sebastian
Jim Chen <nchen@mozilla.com> - Mon, 21 Nov 2016 10:01:30 -0500 - rev 323705
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317604 - 1. Add EventDispatcher to Messaging.jsm; r=snorp r=sebastian Add a new EventDispatcher interface to Messaging.jsm, and provide means to access either the global EventDispatcher through EventDispatcher.instance or a per-window EventDispatcher through EventDispatcher.for(window). The old Messaging object is retained until we can convert all existing uses of it in Fennec to use EventDispatcher, at which point `Messaging` will be made to point to `EventDispatcher.instance`.
a776c56e2ac7879f8e910cd616da0fcf0379a970: Bug 1255914 - Part 2: mostly back out multiDex (changeset 6972bef6693c). r=sebastian
Nick Alexander <nalexander@mozilla.com> - Sun, 13 Nov 2016 14:43:00 -0800 - rev 323654
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1255914 - Part 2: mostly back out multiDex (changeset 6972bef6693c). r=sebastian Since we're Proguarding the automation build now, we shouldn't need to multiDex anymore -- even in beta. MozReview-Commit-ID: 6Yc73Vi9Fhd
61e649e690c9073c07d70b4d5fccbcc40855ceeb: Bug 1255914 - Part 1: Proguard (minify) Gradle builds in automation. r=sebastian
Nick Alexander <nalexander@mozilla.com> - Mon, 21 Nov 2016 11:58:57 -0800 - rev 323653
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1255914 - Part 1: Proguard (minify) Gradle builds in automation. r=sebastian moz.build achieves better results than Gradle, and I can't fully explain why that is. At first I thought it was due to -optimizationpasses, which is 6 for MOZILLA_OFFICIAL; however, it's not -- I see no change (let alone an improvement), when I set the number of passes to 1, 6, 10, or 100. I think there are two things at play. First, moz.build strips debugging information from "libraries", which are broadly the Google support libraries. I don't think it's possible to strip debug information in this fine-grained manner using Gradle. Second, I think the Gradle build might be including more code than the moz.build configuration (see the follow-up patch removing multidex support), but I can't determine what's actually different. After APK compression, I see less than a 50kb regression in APK size between Gradle and moz.build outputs, which I deem reasonable. MozReview-Commit-ID: 4q4Zye2wnOF
e20c0b78111ecd40826a7caa5a141fe9c3519a98: Bug 1318823 - Use com.getkeepsafe.dexcount in Gradle builds. r=sebastian
Nick Alexander <nalexander@mozilla.com> - Fri, 18 Nov 2016 18:28:58 -0800 - rev 323652
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1318823 - Use com.getkeepsafe.dexcount in Gradle builds. r=sebastian MozReview-Commit-ID: DHkWkztgJZB
faf335ab953216b790042988defcf5c416e69cf3: Bug 1293305 - Part 1.8: Do not use non-standard for-each. r=sebastian
Tooru Fujisawa <arai_a@mac.com> - Mon, 21 Nov 2016 15:03:44 +0900 - rev 323599
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1293305 - Part 1.8: Do not use non-standard for-each. r=sebastian
4ca9f9807277d4f981b53e8098d1cf9e7a52aaae: Bug 1316015 - Fixed by replacing '==' & '!=' float comparisons with FloatUtils.fuzzyEquals(). r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Thu, 17 Nov 2016 11:39:56 -0500 - rev 323314
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316015 - Fixed by replacing '==' & '!=' float comparisons with FloatUtils.fuzzyEquals(). r=sebastian MozReview-Commit-ID: 2daF8XCHo0o
a34cadadc9446c451221b5b6902cec49d07c7fbc: Bug 1315980 - Changed ExtendedJSONObject to implement Cloneable and the clone() method to throw CloneNotSupportedException. Changed inner class in ResizablePathDrawable to implement Cloneable. r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Thu, 17 Nov 2016 10:37:41 -0500 - rev 323313
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315980 - Changed ExtendedJSONObject to implement Cloneable and the clone() method to throw CloneNotSupportedException. Changed inner class in ResizablePathDrawable to implement Cloneable. r=sebastian MozReview-Commit-ID: AIxAp1zlN2J
f0f2dbc18d183a5a024a70e5cdcee126edbe91fe: Bug 1316013 - Fixed by removing variables and building them as part of the Log statement (which never gets called because DEBUG is set to FALSE). r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Wed, 16 Nov 2016 09:12:36 -0500 - rev 323048
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316013 - Fixed by removing variables and building them as part of the Log statement (which never gets called because DEBUG is set to FALSE). r=sebastian MozReview-Commit-ID: 7nWeXG50KLQ
4a380f84548df2d742311ea0622947eaf2cc4928: Bug 1303993 - Display "Save Media" for long tapping unloaded video, r=sebastian
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 15 Nov 2016 14:53:28 +0800 - rev 323027
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1303993 - Display "Save Media" for long tapping unloaded video, r=sebastian MozReview-Commit-ID: 7L1AJ0a0yFL
fc1cb5366882e142eb6b5f455e07f5d3dd435883: Bug 1316004 - Fixed by putting the offending statement in an else block; r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Fri, 11 Nov 2016 21:28:12 -0500 - rev 323020
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316004 - Fixed by putting the offending statement in an else block; r=sebastian MozReview-Commit-ID: 6eTso4djFGF
d444cb9e676df82f6a793e1e05f2dcec66f679e9: Bug 1316002: Fixed '==' comparison of strings; r=sebastian
Swaroop Rao <swaroop.rao@gmail.com> - Fri, 11 Nov 2016 15:08:55 -0500 - rev 323019
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316002: Fixed '==' comparison of strings; r=sebastian MozReview-Commit-ID: ERo8gOjsXB8
01409299e7b5c5a0dc782f4124039f8432256a8f: Bug 1308886 - change color for searchbox's placeholder r=sebastian
Julian_Chu <walkingice0204@gmail.com> - Thu, 17 Nov 2016 12:30:44 +0800 - rev 323015
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1308886 - change color for searchbox's placeholder r=sebastian the color code is same as R.color.placeholder_grey in themes/core/config.css
0f8126c38179a6475b550ed97f0dfac42c4899b6: Bug 1317198 - Check if a tab is null before trying to get its id in GeckoApp.onPause() r=sebastian
Dylan Roeh <droeh@mozilla.com> - Wed, 16 Nov 2016 09:07:27 -0600 - rev 322874
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317198 - Check if a tab is null before trying to get its id in GeckoApp.onPause() r=sebastian