searching for reviewer(mats)
70a0740cbd8129b84aabb426a50c3cf3240f8266: Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Dec 2016 09:20:25 -1000 - rev 325615
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats MozReview-Commit-ID: 9kH7rLF66zd
9d41238dabf42896e32ab1df01cb477f25e207f8: Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 08 Dec 2016 09:20:25 -1000 - rev 325422
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319318: When resolving a video/audio frame's shrinkwrapped BSize from controls, check whether controls are orthogonal when reading its size. r=mats MozReview-Commit-ID: 9kH7rLF66zd
5144592dd9180a21472159e4d813a7f61c90484e: Bug 1319668 - Check for null context before trying to draw canvas text. r=mats
Jonathan Kew <jkew@mozilla.com> - Sat, 03 Dec 2016 14:49:46 +0000 - rev 325219
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319668 - Check for null context before trying to draw canvas text. r=mats
eeb34d6bc82cbc44e9dec0005faa6dedb3d1b318: Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:44:07 -0800 - rev 325151
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321698 part 3: Fold nsFlexContainerFrame's old IsLegacyBox() function into its only remaining caller, nsFlexContainerFrame::Init(). r=mats This patch is to prevent any new callers of this API, since we can now rely on the new frame state bit (NS_STATE_FLEX_IS_LEGACY_WEBKIT_BOX) to test for this. MozReview-Commit-ID: BONaqPC30Cn
e38ccf5210624c1a4906f893fc2f7932d4e76a5e: Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 10:32:31 -0800 - rev 325150
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321698 part 2: Use the new frame state bit to check for -webkit-box containers. r=mats Note that at the callsites in nsCSSFrameConstructor.cpp, we have to also check the frame type (since the frame state bit is in a range of bits whose meaning differs depending on frame type). The first change in this patch is the addition of a convenience fucntion that checks both the frame type as well as the frame state bit. MozReview-Commit-ID: DEOThTX5NAO
15f43157a6e1241e6203ac47871e4b1e59ed2585: Bug 1321698 part 1: Set a frame state bit on nsFlexContainerFrame if it's emulating -webkit-box. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 02 Dec 2016 01:02:00 -0800 - rev 325149
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321698 part 1: Set a frame state bit on nsFlexContainerFrame if it's emulating -webkit-box. r=mats MozReview-Commit-ID: 5eL55atUBnT
0c03c2ddda3a4e58295c9f3e1670237cd8b75fb9: Bug 1317588 Part 5 - Change Side's operator++ from postfix to prefix. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 23 Nov 2016 16:55:04 +0800 - rev 324065
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317588 Part 5 - Change Side's operator++ from postfix to prefix. r=mats The postfix operator++ was actually incorrectly implemented as a prefix version. Since it's only used in NS_FOR_CSS_SIDES, let's changed it to prefix version. MozReview-Commit-ID: GbdB2ZC9KyW
88f2c7f0a24a5d7e1f82769ae24aed5c0cf9bed7: Bug 1317588 Part 4 - Remove side bits defined in BorderConsts.h r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 21 Nov 2016 11:56:35 +0800 - rev 324064
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317588 Part 4 - Remove side bits defined in BorderConsts.h r=mats Those bits are already defined as enum in gfx/2d/Types.h. MozReview-Commit-ID: 8E81lW9WnAg
1710e2f930dbd5b32aa5f126ab031c8353a73523: Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 18:12:25 +0800 - rev 324063
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats This patch was written with the help of the following script. Also, manually add mozilla qualifier to the enum values in nsStyleCoord.h, gfxRect.h, and Types.h to make it build. function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename "NS_SIDE_TOP" "eSideTop" rename "NS_SIDE_RIGHT" "eSideRight" rename "NS_SIDE_BOTTOM" "eSideBottom" rename "NS_SIDE_LEFT" "eSideLeft" MozReview-Commit-ID: 9T0ORsqM6nP
60506dc6f798fde3715897564930ce5b2dcf5ed8: Bug 1317588 Part 2 - Remove mozilla::css::Side typedef. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 16:28:38 +0800 - rev 324062
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317588 Part 2 - Remove mozilla::css::Side typedef. r=mats This patch is written with the help of the following script. function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename "css::Side" "Side" MozReview-Commit-ID: DPV6vivpPUp
aceab4673889e2575c25bb5910a9784b2a8e1d1d: Bug 1317588 Part 1 - Move NS_FOR_CSS_SIDES and operator++ to gfx/2d/Types.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 15:25:33 +0800 - rev 324061
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317588 Part 1 - Move NS_FOR_CSS_SIDES and operator++ to gfx/2d/Types.h. r=mats Make them live with the definition of enum Side. MozReview-Commit-ID: 5uJPxFPOj79
b1ad7c0aadfbcff130dc8570784148f1e4e85d85: Bug 1317111 - Remove RealPlayer plugin quirk handling. r=mats
Chris Peterson <cpeterson@mozilla.com> - Wed, 16 Nov 2016 13:44:24 -0800 - rev 322989
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317111 - Remove RealPlayer plugin quirk handling. r=mats
af3eb6a8e0ae5d925fda8d2f9dda039ed6d0a9ac: Bug 1317111 - Remove RealPlayer plugin quirk handling. r=mats
Chris Peterson <cpeterson@mozilla.com> - Mon, 14 Nov 2016 22:06:53 -0800 - rev 322821
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317111 - Remove RealPlayer plugin quirk handling. r=mats Delayed stop was only used for RealPlayer and forced reentry was only used by delayed stop (nsStopPluginRunnable).
c2cb52bf740e6a92e977f2bc0e0463f8783039d4: Bug 1317203 - Change ReflowInputFlags to use bool : 1. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 14 Nov 2016 11:39:25 +0800 - rev 322412
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317203 - Change ReflowInputFlags to use bool : 1. r=mats Based on bug 1294628 comment 8, I added spaces around the colon. MozReview-Commit-ID: Dd4fvavMgmc
11829d96d9016ce42522fb9f4452faccd6a201b8: Bug 1269017 part 5 - [css-grid] Tag grid placeholder children as needing CSS Box Alignment, & consolidate their placement code. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 321818
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1269017 part 5 - [css-grid] Tag grid placeholder children as needing CSS Box Alignment, & consolidate their placement code. r=mats MozReview-Commit-ID: 5105oez3IO3
9f2bdebbdb89d5be01e11a148812f01211dcae64: Bug 1269017 part 4 - [css-grid] When doing CSS Box Alignment, opt out of a CalculateHypotheticalPosition() clause that disregards placeholder's inline position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 321817
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1269017 part 4 - [css-grid] When doing CSS Box Alignment, opt out of a CalculateHypotheticalPosition() clause that disregards placeholder's inline position. r=mats (We don't want to disregard this position -- it's what we use to encode the start of the alignment container for this child, when we're doing CSS Box Alignment. So we need it to be reflected in the hypothetical position, not disregarded.) MozReview-Commit-ID: 28IgPn8z1Hr
ab70dc086596dc45abba729112247a7b6c684b57: Bug 1269017 part 3 - [css-grid] Reduce scope of a mStaticPosIsCBOrigin check to *just* cover hypothetical-position calculation, and update comments. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 321816
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1269017 part 3 - [css-grid] Reduce scope of a mStaticPosIsCBOrigin check to *just* cover hypothetical-position calculation, and update comments. r=mats Previously, I'd thought the "mStaticPosIsCBOrigin" flag was going to become obsolete -- but now I've realized it's quite useful to avert mixup between the coordinate space of the grid vs. the coordinate space of grid-areas-acting-as-abspos-containing-blocks. So, this patch clarifies/removes some stale comments about this flag, and also pulls out some code that was unnecessarily in an "else" clause, so that it happens regardless of whether this flag is set. (Note: the InitAbsoluteConstraints changes are basically just code-reordering & deindentation.) MozReview-Commit-ID: 9TFrOuldVBe
5e6f0bf39062d35752108049fb4b70cc5732f2bd: Bug 1269017 part 2 - [css-grid] Give grid an implementation of CSSAlignmentForAbsPosChild(). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 321815
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1269017 part 2 - [css-grid] Give grid an implementation of CSSAlignmentForAbsPosChild(). r=mats This grid implementation is similar to the one on nsFlexContainerFrame, with a few simplifications: - We can simply use the LogicalAxis to decide between align-* vs justify-* prpoerties (whereas flexbox has extra abstraction from the flex axes). - We don't have to bother with "align-content" or "justify-content", since those apply to grid areas rather than to children. (And any grid area that's involved will be sized/positioned separately.) - Grid can unconditionally treat "flex-start" & "flex-end" as "start" & "end". MozReview-Commit-ID: 9l1Wq9Cq5T0
5795b76480b60724e3fc5e703d8f0848a88dad13: Bug 1269017 part 1 - [css-grid] Adjust OffsetToAlignedStaticPos() to use correct alignment container for abpsos children of grid containers. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Nov 2016 16:30:00 -0800 - rev 321814
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1269017 part 1 - [css-grid] Adjust OffsetToAlignedStaticPos() to use correct alignment container for abpsos children of grid containers. r=mats MozReview-Commit-ID: LItIGLH5GJP
5c85b7c93c5e86011e180451c86bae49dcc49f4e: Bug 1269046 part 10: Skip the normal margin-adding codepath for abspos frames that undergo CSS Box Alignment (which takes care of margins). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 320349
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 10: Skip the normal margin-adding codepath for abspos frames that undergo CSS Box Alignment (which takes care of margins). r=mats MozReview-Commit-ID: Ha0o1rwFzE9
c8965356a17237420621f7089af5146275e5efff: Bug 1269046 part 9: Add a flag to control whether CSSAlignUtils::AlignJustifySelf() expands "auto" margins. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 320348
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 9: Add a flag to control whether CSSAlignUtils::AlignJustifySelf() expands "auto" margins. r=mats MozReview-Commit-ID: I0UdEIfiOqX
7085eed57189b0b50cc466683c153af6325ee4d4: Bug 1269046 part 8: Rewrite CSSAlignUtils::AlignJustifySelf to use a single "flags" arg instead of boolean args. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 320347
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 8: Rewrite CSSAlignUtils::AlignJustifySelf to use a single "flags" arg instead of boolean args. r=mats MozReview-Commit-ID: 5loE21U7FF6
b44098de249789c5aa196575d15e14c9b31457fb: Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:59:40 -0700 - rev 320346
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats MozReview-Commit-ID: LFQfKPlR9Gv
7978dd8d68cedf2050f9dbaae817aa59eddcbc1c: Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320345
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats Right now, there's only one flag in this new class (with no usages until a later patch). This flag suppresses a hack, which otherwise makes us transparently reverse the child list & flex axes in some circumstances, to prevent bottom-to-top child ordering. (We don't want that hack when we're dealing with individual abspos children, since it only makes things more complicated.) MozReview-Commit-ID: HYUf0vjlfiJ
6deb2d4c2f6bcfb1bbf2ed0e9ef3acf35b8c4051: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320344
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
6d5ca25a653be1fde5d672858b8f433427dbb9fd: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320343
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
85fa1048315a87dee973c70773a4fb776eedc5d3: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320342
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
777060004f3ffc63cb95c1d015f548dc7743df63: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320341
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
707a38d83b3b735f92c6bc03269d4e834d451067: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320340
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
78495666fd8ce3814d8b90c9f3a890b805048f38: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:18 -0700 - rev 320339
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl
707b2ab5879d69e2966c97aefa5b237c5146f557: Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 320338
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats This patch also: * Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore. * Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly). MozReview-Commit-ID: 8canWfXk6Kf
d1135160f859f64f5a5b0ca02bf70f220e8167ce: Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 320337
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats MozReview-Commit-ID: 5lXUsusLryC
86fbc1fb2818ec68c7c917557639c6c0a049c75b: Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 31 Oct 2016 08:58:17 -0700 - rev 320336
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats This patch makes the following specific changes: (1) Adds an early-return to both versions of the IsOrderLEQ function, to treat placeholder children as LEQ everything (including each other). This will tend to sort them to the beginning of the child list, which is unimportant but fine. More importantly, though: this means our "order"-sorting code won't reorder placeholders *with respect to each other* (since our sort algorithm is stable). So their painting order won't be affected by the "order" property, which is required by the spec. (2) Drops some nsPlaceholderFrame::GetRealFrameFor() calls -- they're unnecessary, since any placeholder frames will have prompted us to return earlier. One caveat to (2): this patch does leave a few "nsPlaceholderFrame::GetRealFrameFor()" calls in place, *for the moment*. These remaining calls are for handling placeholders that are wrapped, i.e. inside of anonymous flex items. These calls are still needed to avoid assertion-failures (i.e. to get a consistent ordering) at this point, but they'll be removed in a later patch in this same bug, when we stop wrapping placeholders in anonymous flex items. MozReview-Commit-ID: 1R6NW30Kxgv
a0008dd33cf4ef5a733c431c163dbd3793234a2f: Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319906
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 7: Give nsFlexContainerFrame a CSSAlignmentForAbsPosChild() implementation (to determine appropriate align enum for abspos children). r=mats MozReview-Commit-ID: LFQfKPlR9Gv
75b58c4e61e6e51ca6d738b3a3d599476e4e9b89: Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319905
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 6: Add a flags enum-class to customize FlexboxAxisTracker behavior. r=mats Right now, there's only one flag in this new class (with no usages until a later patch). This flag suppresses a hack, which otherwise makes us transparently reverse the child list & flex axes in some circumstances, to prevent bottom-to-top child ordering. (We don't want that hack when we're dealing with individual abspos children, since it only makes things more complicated.) MozReview-Commit-ID: HYUf0vjlfiJ
fb7655f3e1cf3bf9635da9e434eb7da6cf6800f9: Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319904
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 5: If an abspos child's offset depends on CSS Box Alignment, ask nsContainerFrame for the alignment enum to use, and align with CSSAlignUtils. r=mats Right now, this method has only one stub impl, in nsContainerFrame; a later patch will add a more interesting (overriding) impl in nsFlexContainerFrame. MozReview-Commit-ID: 3U3vTTX4vdm
8088e5a9e6e322731d4a3008642b54a1fc0774b1: Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319903
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 4: Set flags on nsPlaceholderFrame & ReflowInput to track abspos frames that need CSS Box Alignment to resolve static position. r=mats (We'll react to the ReflowInput flags and do the actual CSS Box Alignment in a later patch in this series.) MozReview-Commit-ID: EZd7npWSzQI
eea6479452f0be2d7ee98f6d537106f6fe8a0d50: Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319902
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 3: Make a grid-specific comment more general, in CSSAlignUtils::AlignJustifySelf. r=mats MozReview-Commit-ID: GZ35iZ2E1Iz
eb4b52bf06ec8c1f5b33cfba7255a0d4bb64c168: Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319901
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 2: Spin out a helper function to hold nsAbsoluteContainingBlock's code for resolving abspos offsets. r=mats MozReview-Commit-ID: 5tvCIEhAsPH
539db74e4a889a6dc0605f91ff40ab7e748b996d: Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319900
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats MozReview-Commit-ID: 1Eh2CreOLTC
f57f9ac1435edc2d581c4645fa818ffd665d68f7: Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319899
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269045 part 4: Drop now-obsolete parameter from anonymous flex/grid-item wrapping functions. r=mats MozReview-Commit-ID: 5rGemcMMOhl
2162d5c9fb54f3e1b993add441287216534b0b9c: Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319898
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269045 part 3: Stop wrapping placeholder frames in anonymous flex items. r=mats This patch also: * Removes some now-unnecessary code from nsFlexContainerFrame, which was for jumping from wrapped-placeholders to their out-of-flow frames (for DOM comparisons). This code is now unnecessary because placeholders won't be wrapped anymore. * Updates some reftests with abspos content to match the updated spec's expectations, with one marked as "fails" for the time being (until bug 1269046 implements css box alignment, which we need to render that test correctly). MozReview-Commit-ID: 8canWfXk6Kf
7aa8199183fca08ca7d9b309fa01580affb45da7: Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:26 -0700 - rev 319897
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269045 part 2: Separate out abspos placeholders when creating FlexItems, and give them a trivial reflow at container's content-box origin. r=mats MozReview-Commit-ID: 5lXUsusLryC
86a391e3e1638407465610b0dc5b5fc4694a0a08: Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:58:25 -0700 - rev 319896
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1269045 part 1: Adjust flex item "order"-sorting code to treat placeholder frames as <= anything they're compared against, including each other. r=mats This patch makes the following specific changes: (1) Adds an early-return to both versions of the IsOrderLEQ function, to treat placeholder children as LEQ everything (including each other). This will tend to sort them to the beginning of the child list, which is unimportant but fine. More importantly, though: this means our "order"-sorting code won't reorder placeholders *with respect to each other* (since our sort algorithm is stable). So their painting order won't be affected by the "order" property, which is required by the spec. (2) Drops some nsPlaceholderFrame::GetRealFrameFor() calls -- they're unnecessary, since any placeholder frames will have prompted us to return earlier. One caveat to (2): this patch does leave a few "nsPlaceholderFrame::GetRealFrameFor()" calls in place, *for the moment*. These remaining calls are for handling placeholders that are wrapped, i.e. inside of anonymous flex items. These calls are still needed to avoid assertion-failures (i.e. to get a consistent ordering) at this point, but they'll be removed in a later patch in this same bug, when we stop wrapping placeholders in anonymous flex items. MozReview-Commit-ID: 1R6NW30Kxgv
ae632144724fc5efae24a32acab2d7d938384123: Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:48 -0700 - rev 319894
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1313421 part 2: Use flex container's FlexLine linked-list to determine the first flex item, rather than its child-frame list. r=mats This shouldn't change our behavior right now, but it will make a difference after bug 1269045 -- when that bug lands, we'll have nsPlaceholderFrames (which are not flex items) in the child-frame list, which means we can't depend on its first entry being a flex item anymore. MozReview-Commit-ID: KRXYaK8R8bc
c565ba669d962165dc90b99f77b0b26d4acb4d92: Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 27 Oct 2016 18:56:41 -0700 - rev 319893
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1313421 part 1: Unconditionally cache a FlexItem's ascent, after it's been reflowed. r=mats This removes a (very minor) optimization. The optimization was simply that we avoided storing this nscoord value, if we could tell that we weren't ever going to need it. Now it's becoming a bit more complicated to prove that we'll never need it, so we might as well just store it unconditionally. MozReview-Commit-ID: 94FFc9SO516
46a855ae9e4b59c29580aca18afc9648fbc5ed2a: Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
Xidorn Quan <me@upsuper.org> - Tue, 25 Oct 2016 17:25:10 +1100 - rev 319542
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats MozReview-Commit-ID: J5Fp0iAEnkg
9b715399e5859fd5a7382199f5999c87cef39287: Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats
Xidorn Quan <me@upsuper.org> - Tue, 25 Oct 2016 17:25:10 +1100 - rev 319522
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1310123 - Move values of static constants in nsStyleStruct to the header. r=mats MozReview-Commit-ID: J5Fp0iAEnkg
713fd01584d9616f9483bf6204ee230d3cd9108c: Bug 1309982. Check if presshell is destroying before proceeding to do more work in PresShell::ReconstructFrames. r=mats
Timothy Nikkel <tnikkel@gmail.com> - Thu, 20 Oct 2016 16:42:16 -0500 - rev 318910
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1309982. Check if presshell is destroying before proceeding to do more work in PresShell::ReconstructFrames. r=mats PresShell::Destroy calls destroy on the frame constructor/manager, which clears it's local presshell pointer, thus causing us to crash.
06d4b91875087e77e8a6569b5df9db9b1ade7569: Bug 1309119 part 4: Make the scrollframe, button, & fieldset anonymous inner boxes inherit -webkit-box container CSS properties. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 20 Oct 2016 13:23:52 -0700 - rev 318898
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1309119 part 4: Make the scrollframe, button, & fieldset anonymous inner boxes inherit -webkit-box container CSS properties. r=mats (We already do this for the properties that we use to configure modern flexbox.) MozReview-Commit-ID: KStEZ42FIqB