searching for reviewer(johannh)
4d13fd025112b2e9da6433815bc2fc2abe0f883c: Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
Florian Quèze <florian@queze.net> - Mon, 28 Nov 2016 12:29:31 +0100 - rev 324650
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
77b01f2bda7f4737ad3573103c05ccea895d1a39: Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
Florian Quèze <florian@queze.net> - Mon, 28 Nov 2016 12:29:31 +0100 - rev 324435
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320375 - Remove webrtcUI.showSharingDoorhanger's obsolete aType parameter, r=johannh.
966bed7e5627ebe5c165f202b62d90f285e78b27: Fix the access key conflict in the password manager prompt (bug 1279586). r=johannh
Panos Astithas <past@mozilla.com> - Wed, 23 Nov 2016 12:27:08 +0200 - rev 324000
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Fix the access key conflict in the password manager prompt (bug 1279586). r=johannh MozReview-Commit-ID: 3XquO7Evzgb
9b5e7c9b5c8cd19e41dc8c0f89830ef6e5b01403: Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. r=johannh
Mike Conley <mconley@mozilla.com> - Sat, 19 Nov 2016 17:25:58 -0500 - rev 323624
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. r=johannh This was originally taking advantage of the fact that we were hiding HTML checkboxes by default via common.inc.css. Since bug 1309316 landed, we don't hide those checkboxes by default anymore. So now we special-case about:privatebrowsing to hide the checkbox. MozReview-Commit-ID: CaImnCPu8cE
ff5425b88b3c5d495984abd9378b73078233e52d: Bug 1296252 - Part 1 - Only display doorhanger notifications when they are anchored to the right icon. r=johannh
Panos Astithas <past@mozilla.com> - Sun, 20 Nov 2016 18:40:12 +0100 - rev 323566
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1296252 - Part 1 - Only display doorhanger notifications when they are anchored to the right icon. r=johannh MozReview-Commit-ID: 93nzbZ8jnQK
f547d674f0c2b587c03a0893ec1abe65faed43f0: Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh
catdesk <catdesk@tuta.io> - Sat, 29 Oct 2016 11:43:03 +0200 - rev 322442
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh MozReview-Commit-ID: 8rsjCQjbXQk
084f217c4d49b0a617204d6445ab9f30ff4f43db: Bug 1269568 - Remove LoginManagerContent's isDocumentSecure function in favor of Window.isSecureContext. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 06 Oct 2016 21:51:01 -0400 - rev 317368
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1269568 - Remove LoginManagerContent's isDocumentSecure function in favor of Window.isSecureContext. r=johannh MozReview-Commit-ID: 12o3WIr6zqS
651b30ec6c5c4820559027fbda9bdc15fa504930: Bug 1301109 - Avoid LoginManagerPrompter initialization failures due to init() with a null window. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 19 Sep 2016 17:26:57 +0800 - rev 314374
Bug 1301109 - Avoid LoginManagerPrompter initialization failures due to init() with a null window. r=johannh Also document the fact that there may be no ChromeWindow so this case is kept in mind. MozReview-Commit-ID: DGp68U5L8yY
8bf7bb7bd560003169abbd98d75122c771ce1878: Bug 1286718 - Revert bug 1164028 to remove the additional login fill doorhanger code. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 09 Sep 2016 23:23:03 -0700 - rev 313846
Bug 1286718 - Revert bug 1164028 to remove the additional login fill doorhanger code. r=johannh MozReview-Commit-ID: 3A3crOXQv7p
5e8106a481ec4e6b98642fd8e906af53d51e126c: Bug 1286718 - Revert bug 1149975 to remove the additional login fill doorhanger code. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 09 Sep 2016 23:04:45 -0700 - rev 313845
Bug 1286718 - Revert bug 1149975 to remove the additional login fill doorhanger code. r=johannh MozReview-Commit-ID: 7dAZKshpwdC
f25222e5731ae2492b87d3cd31d1d4e4210f66eb: Bug 1286718 - Revert bug 1148026 to remove the initial login fill doorhanger code. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 09 Sep 2016 22:56:52 -0700 - rev 313844
Bug 1286718 - Revert bug 1148026 to remove the initial login fill doorhanger code. r=johannh MozReview-Commit-ID: 8IiG6gTNeHY
a5f0a08902a730c9a172b668cd8985d966f88c54: Bug 1286718 - Manually revert LoginManagerContent's _updateLoginFormPresence and fillForm. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 09 Sep 2016 22:54:59 -0700 - rev 313843
Bug 1286718 - Manually revert LoginManagerContent's _updateLoginFormPresence and fillForm. r=johannh Manually revert since the context menu and insecure passwords UI are using some of this code now. MozReview-Commit-ID: JnRFfnbPaOj
331f9d101a83510c0976ea268705d42d3483e94b: Bug 1286718 - Remove password manager's browser_filldoorhanger.js. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 09 Sep 2016 22:55:59 -0700 - rev 313842
Bug 1286718 - Remove password manager's browser_filldoorhanger.js. r=johannh MozReview-Commit-ID: 5sAfeNmrTiR
4f7ca1523e06f093a330aff511e5bffe2e7663e1: Bug 1301287 - Password manager: enable eslint no-array-constructor rule. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:40:02 -0700 - rev 313254
Bug 1301287 - Password manager: enable eslint no-array-constructor rule. r=johannh MozReview-Commit-ID: 61PSYdgzDz2
4cfa5df42a78e30ebe80d9e2b392d2bacfecdb01: Bug 1301287 - Password manager: enable eslint no-new-object rule. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:39:48 -0700 - rev 313253
Bug 1301287 - Password manager: enable eslint no-new-object rule. r=johannh MozReview-Commit-ID: 608ugBaVxrg
1daf7a032230f4850509c7f6d17cb877983743a5: Bug 1301287 - Password manager: enable eslint space-infix-ops rule. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:41:15 -0700 - rev 313252
Bug 1301287 - Password manager: enable eslint space-infix-ops rule. r=johannh .js files were fixed automatically with --fix MozReview-Commit-ID: wzRpQhqEH7
96afe7c272935fbe911c52598bc008477740eb1b: Bug 1301287 - Password manager: enable eslint semi rule. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:42:49 -0700 - rev 313251
Bug 1301287 - Password manager: enable eslint semi rule. r=johannh .js files were fixed automatically with --fix MozReview-Commit-ID: Get2mxB8Twx
c2f550b205094107816e99c5523b65e0faf701a0: Bug 1301287 - Remove useless method comments and convert others to JSDoc style. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:43:53 -0700 - rev 313250
Bug 1301287 - Remove useless method comments and convert others to JSDoc style. r=johannh MozReview-Commit-ID: KiHNSpLqVnj
66e80898e791f6de033520076056a0168f58e653: Bug 1301287 - Password manager: enable eslint brace-style rule on shipping code. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 07 Sep 2016 21:45:20 -0700 - rev 313249
Bug 1301287 - Password manager: enable eslint brace-style rule on shipping code. r=johannh MozReview-Commit-ID: BDHUOlv83eR
beda515683970341d1338dbc687bb929c0ce291f: Bug 1294576 - Remove device sharing indicator on location changes, r=johannh.
Florian Quèze <florian@queze.net> - Thu, 08 Sep 2016 12:46:25 +0200 - rev 313214
Bug 1294576 - Remove device sharing indicator on location changes, r=johannh.
47080eb5264154cdc8726628981c1a7948eec96d: Bug 1297336 - Preserve device sharing indicator when tearing off a tab, r=johannh.
Florian Quèze <florian@queze.net> - Thu, 08 Sep 2016 12:46:25 +0200 - rev 313213
Bug 1297336 - Preserve device sharing indicator when tearing off a tab, r=johannh.
d3d05b94bc1bd2cb443109cd8b5700cefaf41f09: Bug 1297693 - Used a more specific selector in tests for blocked permission icons in browser_permissions.js. r=johannh, r=dao
Udayan Baidya <udayanbaidya@gmail.com> - Mon, 05 Sep 2016 09:23:00 -0400 - rev 313128
Bug 1297693 - Used a more specific selector in tests for blocked permission icons in browser_permissions.js. r=johannh, r=dao
a093339f5b6181440201bcf747c9013da11c4bda: Bug 1299984 - Enable eslint no-unused-vars for shipping pwmgr code. r=johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Fri, 02 Sep 2016 14:07:13 -0700 - rev 312883
Bug 1299984 - Enable eslint no-unused-vars for shipping pwmgr code. r=johannh I also fixed two test cases while I was looking at the results. MozReview-Commit-ID: LpUj56UNV3r
f5ba84cadbc99ef9cf6f508834da5ce4aa1eebbb: Bug 1299211 - Move icon transparency into identity-icon.svg and tracking-protection-16.svg and remove !important from .plugin-icon.plugin-blocked opacity. r=johannh
Dão Gottwald <dao@mozilla.com> - Tue, 06 Sep 2016 13:04:01 +0200 - rev 312821
Bug 1299211 - Move icon transparency into identity-icon.svg and tracking-protection-16.svg and remove !important from .plugin-icon.plugin-blocked opacity. r=johannh
e6cd5070f45402ae11b0d16dc42fcf2db7d557ef: Bug 1297430 -Add tooltip to X icon in control center. r=johannh
7 <mail2seven@gmx.de> - Thu, 01 Sep 2016 19:54:10 +0200 - rev 312442
Bug 1297430 -Add tooltip to X icon in control center. r=johannh
f0a49e4df7c722da827e4239a6dae98afe8509c4: Bug 1295571 - Disable toggle in debugInfo on aboutNetError. r=johannh, r=Gijs
xunga <alessioscarapazzi@gmail.com> - Thu, 18 Aug 2016 21:51:10 +0200 - rev 310381
Bug 1295571 - Disable toggle in debugInfo on aboutNetError. r=johannh, r=Gijs
b4f5a80d3533c651b1a754a8f6bc71b0f5ad5ca5: Bug 1291730 - Assign background tooltip to connection-icon and identity-label instead of identityBox. r=florian r=johannh
jdinartejesus <jdinartejesus@gmail.com> - Sat, 06 Aug 2016 19:12:11 +0200 - rev 310333
Bug 1291730 - Assign background tooltip to connection-icon and identity-label instead of identityBox. r=florian r=johannh MozReview-Commit-ID: 4P1LRmo55Lc
2f24daceada71e15c03b5f90765264c720ed035a: Bug 1206233 - Update webrtc browser-chrome tests to pass without the webRTC-sharingDevices doorhanger, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:52:27 +0200 - rev 308965
Bug 1206233 - Update webrtc browser-chrome tests to pass without the webRTC-sharingDevices doorhanger, r=johannh.
f2b5ee82a99bd339eac7037ac45f6bb88f625bb5: Bug 1206233 - Removed the old device/screen sharing doorhangers, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:53 +0200 - rev 308964
Bug 1206233 - Removed the old device/screen sharing doorhangers, r=johannh.
e3107e2095b8b4527f47706f40a6bdde512fc239: Bug 1206233 - Show devices actively streaming in the control center panel, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:53 +0200 - rev 308963
Bug 1206233 - Show devices actively streaming in the control center panel, r=johannh.
576f62171a713f3d4d14c933fe6e837cd0a4ad83: Bug 1206233 - Implement the animated sharing indicator above the control center (i) icon, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:52 +0200 - rev 308962
Bug 1206233 - Implement the animated sharing indicator above the control center (i) icon, r=johannh.
5fd912b9afedd1328764552772485a398aaf9c84: Bug 1206233 - Update webrtc browser-chrome tests to pass without the webRTC-sharingDevices doorhanger, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:52:27 +0200 - rev 308800
Bug 1206233 - Update webrtc browser-chrome tests to pass without the webRTC-sharingDevices doorhanger, r=johannh.
3e0bcd0f52c77b99f9708724880db7d2877be33d: Bug 1206233 - Removed the old device/screen sharing doorhangers, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:53 +0200 - rev 308799
Bug 1206233 - Removed the old device/screen sharing doorhangers, r=johannh.
c3796270f3c271122af6540891cdcf9aaaaa1244: Bug 1206233 - Show devices actively streaming in the control center panel, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:53 +0200 - rev 308798
Bug 1206233 - Show devices actively streaming in the control center panel, r=johannh.
855fe322a553bd7fe067d6e9debeab535fc0d830: Bug 1206233 - Implement the animated sharing indicator above the control center (i) icon, r=johannh.
Florian Quèze <florian@queze.net> - Tue, 09 Aug 2016 22:50:52 +0200 - rev 308797
Bug 1206233 - Implement the animated sharing indicator above the control center (i) icon, r=johannh.
8bdde675e429d79fc707ec2327de05d3fae31f65: Bug 1290174 - Increasing text size of permission prompts and spacing around icons. r=johannh
Jonathan Kingston <jkt@mozilla.com> - Thu, 04 Aug 2016 14:09:02 +0100 - rev 308643
Bug 1290174 - Increasing text size of permission prompts and spacing around icons. r=johannh MozReview-Commit-ID: GHDVro0tYyK
516c82acb163c7f75048b46118d5414db5cec558: Bug 1282455 - Use dedicated "Learn more..." link on time related cert error pages. r=johannh r=Gijs
Sebastin Santy <sebastinssanty> - Mon, 04 Jul 2016 10:39:00 +0200 - rev 303633
Bug 1282455 - Use dedicated "Learn more..." link on time related cert error pages. r=johannh r=Gijs
964138adafa9b8fe51703b4a89258f6aca9cf7d5: Bug 1280919 - Update all permission icon class names to match the permission ID. r=johannh
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 21 Jun 2016 16:36:02 +0100 - rev 302447
Bug 1280919 - Update all permission icon class names to match the permission ID. r=johannh MozReview-Commit-ID: Ax5v9eLZLVF
6833ddd73063182bc4569b73cb56787dc1a5863e: Bug 1274712 - Follow-up to also change doNotTrackCheckbox.accesskey. rs=flod,johannh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 01 Jun 2016 00:34:10 -0700 - rev 299685
Bug 1274712 - Follow-up to also change doNotTrackCheckbox.accesskey. rs=flod,johannh MozReview-Commit-ID: BVSlJ9qAaJs