searching for reviewer(jesup)
b5301d5a9251625788a510333fea870ac4a26b5b: Bug 1317714 - port mediaconduit_unittests to xul gtest; r=jesup, glandium
Dan Minor <dminor@mozilla.com> - Fri, 18 Nov 2016 08:17:36 -0500 - rev 325601
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317714 - port mediaconduit_unittests to xul gtest; r=jesup, glandium The test results were updated to match current behaviour. The TestDummyAudioWithTransport and TestDummyVideoWithTransports are disabled due to shutdown crashes and intermittent failures that show up in automation. A follow up bug has been filed to fix these. The GMP test was removed completely as it seems unlikely that it will be practical to test that from a gtest. MozReview-Commit-ID: 2pOb7u2Qp7v
afdc890658747791601d65c77ed549d4607d0d77: Bug 1320101 - Support renegotiations with changes to TIAS and simulcast params. r=bwc,jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 08 Dec 2016 10:11:18 -1000 - rev 325415
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320101 - Support renegotiations with changes to TIAS and simulcast params. r=bwc,jesup MozReview-Commit-ID: GNWRNnwX9pk
337f8b56236774aea32593bba2c540df33cddd26: Bug 1320101 - Differentiate between b=TIAS and simulcast stream max-br. r=bwc,jesup
Andreas Pehrson <pehrsons@gmail.com> - Wed, 07 Dec 2016 08:38:13 -1000 - rev 325414
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320101 - Differentiate between b=TIAS and simulcast stream max-br. r=bwc,jesup MozReview-Commit-ID: HPnOvwtawwV
38e008ff60f0f595cc6f57ecbac6775166ab480a: Bug 1320101 - Pass mLastFramerateTenths by copy. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Sat, 26 Nov 2016 00:28:29 +0100 - rev 325413
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320101 - Pass mLastFramerateTenths by copy. r=jesup Just for the cleanliness of not having to pass an atomic that we always read by reference. MozReview-Commit-ID: 60HzuTAENdQ
8e249f96175065170c647f4d10526af3e13d04ac: Bug 1320101 - mNegotiatedMaxBitrate should be able to cap the max bitrate. r=bwc,jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 01 Dec 2016 16:52:41 +0100 - rev 325412
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320101 - mNegotiatedMaxBitrate should be able to cap the max bitrate. r=bwc,jesup MozReview-Commit-ID: 9WRUa0SKuM2
b0d0bb5e3cfff8d3f3f7967df7706f02b1d64831: Bug 1320101 - Default to 2Mbps when no max bitrate is set. r=bwc,jesup
Andreas Pehrson <pehrsons@gmail.com> - Fri, 25 Nov 2016 23:00:11 +0100 - rev 325411
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320101 - Default to 2Mbps when no max bitrate is set. r=bwc,jesup webrtc.org is in kbps and our constraints are in bps. 2000U is already in kbps however. MozReview-Commit-ID: 2Y4z2CIO6jE
4ed75a24f8b5bd3b400ec44a5c3a3a48575347ff: Bug 1317927 - Media caching needs to use origin attributes, r=cpearce, r=jesup
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 07 Dec 2016 07:07:09 -1000 - rev 325387
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317927 - Media caching needs to use origin attributes, r=cpearce, r=jesup
eef062272d1951b7c2e650b69cace6ba6f1023d0: Bug 1310064 - mark MediaEngineTabVideoSource draw target as uninitialized to avoid triggering assertion with Skia. r=lsalzman, jesup
vincentliu <vliu@mozilla.com> - Tue, 06 Dec 2016 21:52:02 -1000 - rev 325374
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1310064 - mark MediaEngineTabVideoSource draw target as uninitialized to avoid triggering assertion with Skia. r=lsalzman, jesup --- dom/media/webrtc/MediaEngineTabVideoSource.cpp | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
f1f8ed76c1e7ece3c10610e4479487fa60567507: Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values. r=jesup,mrbkap
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 22 Nov 2016 16:13:04 -0500 - rev 325308
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319542 - Update RTCDataChannelInit to spec, and remove support for old deprecated values. r=jesup,mrbkap MozReview-Commit-ID: 12JbUVuSEYg
617cd94bd7c5ff1dbcd3083bbe1c843bfb2fdb49: Bug 1313758 - set media.getusermedia.browser.enabled to default false; r=jesup
Munro Mengjue Chiang <mchiang@mozilla.com> - Wed, 30 Nov 2016 15:03:48 +0800 - rev 325110
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1313758 - set media.getusermedia.browser.enabled to default false; r=jesup MozReview-Commit-ID: 54YTn2p4nnX
eea552a9e16285b98c5971e7a8a7c141a55477d4: Bug 1321235 - Let ended MediaStreamTracks be removable. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 01 Dec 2016 19:35:48 +0100 - rev 325108
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321235 - Let ended MediaStreamTracks be removable. r=jesup MozReview-Commit-ID: A3V3SY4L3HL
7f0eb04ee1d58b0f28085bea908ad5a9425e85c2: Bug 1321235 - Add a mochitest. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 01 Dec 2016 19:35:15 +0100 - rev 325107
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321235 - Add a mochitest. r=jesup MozReview-Commit-ID: 11gpS79Ce2h
6992281f395d344cf6921297ecf83fe8df071188: Bug 1037438 - implement persistent deny permissions for screen sharing, r=jesup,past.
Florian Quèze <florian@queze.net> - Mon, 28 Nov 2016 12:29:31 +0100 - rev 324649
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1037438 - implement persistent deny permissions for screen sharing, r=jesup,past.
ca8ca07756ab80d29778329aa22ebc453f17fc69: Bug 1037438 - implement persistent deny permissions for screen sharing, r=jesup,past.
Florian Quèze <florian@queze.net> - Mon, 28 Nov 2016 12:29:31 +0100 - rev 324434
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1037438 - implement persistent deny permissions for screen sharing, r=jesup,past.
36297c58723f978d1924bd7ad74dc25ad34feb4d: Bug 1221574 - [06] Disable one media test in case of Android. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Nov 2016 18:00:49 +0200 - rev 323469
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1221574 - [06] Disable one media test in case of Android. r=jesup MozReview-Commit-ID: 1xoauN0vIMy
14af435edc2d399d2834a32d43b0d7d4ffec9782: Bug 1221574 - [05] Fix MediaStreamGraph lifecycle logs in case of Android. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Nov 2016 18:00:48 +0200 - rev 323468
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1221574 - [05] Fix MediaStreamGraph lifecycle logs in case of Android. r=jesup MozReview-Commit-ID: czoHOOCqSu
d0269eb23e0c23e08b95158c4c125c82a64dfaa0: Bug 1221574 - [04] Change assert of expected devices in case of Android. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Nov 2016 18:00:48 +0200 - rev 323467
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1221574 - [04] Change assert of expected devices in case of Android. r=jesup MozReview-Commit-ID: 5ueMnCqi5Me
bd59a9fb070a85ba8d03357bb3b516d38ee462db: Bug 1221574 - [03] Hardcode expected mic device on Android. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Nov 2016 18:00:48 +0200 - rev 323466
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1221574 - [03] Hardcode expected mic device on Android. r=jesup MozReview-Commit-ID: 5sTPpwskJCC
5a104f59c9f3c946276b448330eb9a839144e7ba: Bug 1221574 - [02] Fix build erros with the new backend. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Fri, 18 Nov 2016 18:00:48 +0200 - rev 323465
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1221574 - [02] Fix build erros with the new backend. r=jesup MozReview-Commit-ID: n27saMBWfw
f0f06d912b18a0a74361918466421668569a58b6: Bug 1318132 - Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity) r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 16 Nov 2016 17:09:14 -0500 - rev 323029
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1318132 - Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity) r=jesup MozReview-Commit-ID: 5RQodJ18MbA
4fc83233df681d000842ef2945bc6207d519efd2: Bug 1317473 - Make GMPService accept paths with mixed dir separators. r=jesup
Chris Pearce <cpearce@mozilla.com> - Tue, 15 Nov 2016 10:56:43 +1300 - rev 322636
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317473 - Make GMPService accept paths with mixed dir separators. r=jesup The mochitest harness on Windows sets MOZ_GMP_PATH to paths with a mixture of Windows and UNIX dir separators, and the NS_NewLocalFile() call in GMPServiceParent::AddOnGMPThread() fails on this input. We've had this problem before, and if we fixed the test harness to give us input with platform specific line endings somebody would likely just break this again someday and have this issue again, so just make the GMP service normalize the paths it's given to have consistent dir separators. This makes test_peerConnection_basicH264Video.html pass when run locally on my Windows machine. MozReview-Commit-ID: 88hSvTdZuWg
31b6c03c69f18df000420d218b7b233f739af584: Bug 1315470: booleans never turn negative. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Mon, 07 Nov 2016 15:28:50 -0800 - rev 322362
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315470: booleans never turn negative. r=jesup MozReview-Commit-ID: 7XbJd35uMSX
3ae375b7fab132700fe66e8d179ed5bb723a9e67: Bug 1316657 - Clean up the webrtc-related gtest entries in toolkit.mozbuild. r=jesup
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 11 Nov 2016 10:32:54 -0500 - rev 322182
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316657 - Clean up the webrtc-related gtest entries in toolkit.mozbuild. r=jesup
c0d2974a85377ed9a30092153978696dc9049ea1: Bug 1315858 - Test ability to detect screensharing sources that are firefox. r=florian,jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 07 Nov 2016 12:20:41 -0500 - rev 321847
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315858 - Test ability to detect screensharing sources that are firefox. r=florian,jesup MozReview-Commit-ID: K6Kkdaso7dd
621860d37e7223a26c116c3dd5f9236d757459e3: Bug 1315858 - Test ability to detect screensharing sources that are firefox. r=florian,jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 07 Nov 2016 12:20:41 -0500 - rev 321683
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315858 - Test ability to detect screensharing sources that are firefox. r=florian,jesup MozReview-Commit-ID: K6Kkdaso7dd
e35ee6e46109004db4abf0ad805f5518036ca12b: Bug 1313406 - Enable DTMF by default; r=jesup
Dan Minor <dminor@mozilla.com> - Mon, 07 Nov 2016 11:50:13 -0500 - rev 321589
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1313406 - Enable DTMF by default; r=jesup MozReview-Commit-ID: JUGU2JCPIah
3d0b7a58598b324fd0e72a72aa6e800d69e5521f: Bug 1315737 - Test that allowed_domains is no longer needed for screensharing. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 07 Nov 2016 13:51:58 -0500 - rev 321527
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315737 - Test that allowed_domains is no longer needed for screensharing. r=jesup MozReview-Commit-ID: FNMuqq9fzKu
56dfef4b382a41fbbefcec7a9d159cd32835bf9c: Bug 1315737 - Remove platform checking of screensharing whitelist r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 07 Nov 2016 13:39:20 -0500 - rev 321526
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315737 - Remove platform checking of screensharing whitelist r=jesup MozReview-Commit-ID: IosWOvEsIF8
63be72bf8bbd66a07c64e29a5deb52c1b3a2f411: Bug 1315470: booleans never turn negative. r=jesup
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Sat, 05 Nov 2016 10:48:43 -0700 - rev 321376
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315470: booleans never turn negative. r=jesup MozReview-Commit-ID: 8YkI17SMGYE
b8f2d6428e38806fb1ce5898ed2a16d3b7e77d3c: Bug 1311048 - Surface process id in application sharing for completeness (we never share own process). r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 04 Nov 2016 00:59:47 -0400 - rev 321341
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1311048 - Surface process id in application sharing for completeness (we never share own process). r=jesup MozReview-Commit-ID: HShFSBMO0yx
8da036418f24571d18ad32a5b7870571e8f141a8: Bug 1311048 - Make it compile on android. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 04 Nov 2016 11:44:32 -0400 - rev 321340
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1311048 - Make it compile on android. r=jesup MozReview-Commit-ID: 7jwGgr0JVEt
bec62243bf7e3869379b12017cd10e5ed5902296: Bug 1311048 - Pick out Firefox windows as scary by pid on Linux. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 04 Nov 2016 23:56:48 -0400 - rev 321339
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1311048 - Pick out Firefox windows as scary by pid on Linux. r=jesup MozReview-Commit-ID: CjkfnZWjCTl
533d7494d9cad184fc90d3dcf10b74e9925ccefe: Bug 1311048 - Pick out Firefox windows as scary by pid on Windows. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 03 Nov 2016 17:21:56 -0400 - rev 321338
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1311048 - Pick out Firefox windows as scary by pid on Windows. r=jesup MozReview-Commit-ID: DzlAVt1oJIs
5b9dacd187bb70d51e24d148d03b410d334094f9: Bug 1311048 - Pick out Firefox windows as scary by pid (only OSX atm). r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 30 Sep 2016 13:23:42 -0400 - rev 321337
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1311048 - Pick out Firefox windows as scary by pid (only OSX atm). r=jesup MozReview-Commit-ID: DwUodsRWswm
f6aba4ec09af240e3688ba634b43a5d593ec8d9d: Bug 1314667 - Add bounds check when configuring simulcast streams; r=jesup a=dveditz
Dan Minor <dminor@mozilla.com> - Wed, 02 Nov 2016 15:16:36 -0400 - rev 321008
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1314667 - Add bounds check when configuring simulcast streams; r=jesup a=dveditz The webrtc.org code has a hard coded limit on the number of simulcast streams. This adds a check to make sure we don't try to add more streams than it can support. Since the jsep code orders by decreasing resolution, if too many streams are passed in we will end up dropping the lowest resolution ones.
233a212baec5194ee99dbe3ad00c7ba0838903fe: Bug 1312030 - Remove MediaParent singleton to work with multi content processes. r=jesup
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 01 Nov 2016 07:44:02 -0400 - rev 320516
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1312030 - Remove MediaParent singleton to work with multi content processes. r=jesup MozReview-Commit-ID: 8JONCRge6SU
0b3122d59d17056b6d0142f74a0a4bff78f56ece: Bug 1314316 - Restore use of ceilf method instead of roundf. r=jesup
Alex Chronopoulos <achronop@gmail.com> - Tue, 01 Nov 2016 18:34:55 +0200 - rev 320450
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1314316 - Restore use of ceilf method instead of roundf. r=jesup MozReview-Commit-ID: 5Wv5dqSy3B8
c136ac92dcdc37dfd09f4868887f1ccf86522989: Bug 1312431 - Make buffers passed into Get10msTone match specified maximum buffer size; r=jesup
Dan Minor <dminor@mozilla.com> - Fri, 28 Oct 2016 08:58:19 -0400 - rev 319981
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1312431 - Make buffers passed into Get10msTone match specified maximum buffer size; r=jesup MozReview-Commit-ID: I7UNWfzHi6I
355c7ec8b68e965787e18517eeef2a693434992a: Bug 1312431 - Support for higher sample rates in dtmf_inband.cc can not be reached; r=jesup
Dan Minor <dminor@mozilla.com> - Mon, 24 Oct 2016 11:36:29 -0400 - rev 319957
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1312431 - Support for higher sample rates in dtmf_inband.cc can not be reached; r=jesup This also fixes a potential buffer overflow as the buffer size was hard coded to be the old maximum buffer size of 320. MozReview-Commit-ID: 5DD8vWlIDPQ
0b1ae9f4f07bd823d91fadc1b2eac168e37363ca: Bug 1308412 - fix setCaptureHeight() failure; r=jesup,jib
Munro Mengjue Chiang <mchiang@mozilla.com> - Wed, 26 Oct 2016 18:08:51 +0800 - rev 319735
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1308412 - fix setCaptureHeight() failure; r=jesup,jib MozReview-Commit-ID: 47mgoY4sOSw
0680e3176fa56b00a75d187b9b338546371486a8: Bug 1308412 - retrieve CVImageBuffer from CMSampleBuffer if it doesn't contain any CMBlockBuffer; r=jesup,jib
Munro Mengjue Chiang <mchiang@mozilla.com> - Wed, 26 Oct 2016 18:08:18 +0800 - rev 319734
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1308412 - retrieve CVImageBuffer from CMSampleBuffer if it doesn't contain any CMBlockBuffer; r=jesup,jib MozReview-Commit-ID: BERDnKJ0i3t
6e16ba93d1d7375e936a675942ba01d7dbd9a3aa: Bug 1295352 - Release MediaEngineTabVideoSource main-thread-only members on main thread. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Tue, 30 Aug 2016 14:17:59 +0200 - rev 319611
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Release MediaEngineTabVideoSource main-thread-only members on main thread. r=jesup MozReview-Commit-ID: H3N70b9tGiI
ef7b7be0c4e8b32bc646ff8065cfcfe6d8ab4160: Bug 1295352 - Use mState in MediaEngineTabVideoSource. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 25 Aug 2016 12:25:06 +0200 - rev 319609
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Use mState in MediaEngineTabVideoSource. r=jesup MozReview-Commit-ID: 1zZlMXAqpo7
4f06424634eaf6ba3d49b206ccbecb00721d1853: Bug 1295352 - Check state in MediaEngines' NotifyPull(). r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Tue, 23 Aug 2016 10:45:09 +0200 - rev 319608
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Check state in MediaEngines' NotifyPull(). r=jesup GetEndOfAppendedData() returns null and calls a NS_ERROR() if the track we're looking for doesn't exist - to indicate an error in the caller's code. When we end a MediaEngine track we set the state to stopped, which we can use to guard the calls to GetEndOfAppendedData() (and appending data in general). The locking is already in place. MozReview-Commit-ID: DuknmBF883H
148057da1d5edd89e404ea5af27a7d5de2ed20f0: Bug 1309469 - Crash [@ webrtc::ViECaptureImpl::NumberOfCaptureDevices]; r=jesup
Munro Mengjue Chiang <mchiang@mozilla.com> - Mon, 24 Oct 2016 18:19:16 +0800 - rev 319361
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1309469 - Crash [@ webrtc::ViECaptureImpl::NumberOfCaptureDevices]; r=jesup MozReview-Commit-ID: Di4uXmJe6oz
d2b9b6e2da6b76e7d5134980fb02f31cdaf6eca4: Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`. r=jesup
Paul Adenot <paul@paul.cx> - Mon, 24 Oct 2016 17:26:07 +0200 - rev 319186
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1312413 - `mDefaultDevice` should be an index in `mDeviceIndexes`. r=jesup MozReview-Commit-ID: 8UywuqRAegy
f7ffbce9fd97bc3b728a463247cc6a137d00fabe: Bug 1302612 - SourceMediaStream: Don't lock mMutex when disconnecting consumers. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Mon, 24 Oct 2016 07:46:21 +0200 - rev 319180
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1302612 - SourceMediaStream: Don't lock mMutex when disconnecting consumers. r=jesup MozReview-Commit-ID: 7F4BXQbzUSx
57f7b75e5a6210ba05e58cb6a117151e1d25f29e: Bug 1295352 - Release MediaEngineTabVideoSource main-thread-only members on main thread. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Tue, 30 Aug 2016 14:17:59 +0200 - rev 318942
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Release MediaEngineTabVideoSource main-thread-only members on main thread. r=jesup MozReview-Commit-ID: H3N70b9tGiI
f3dae14842ecbc89f405095c20faa6834ed10a04: Bug 1295352 - Use mState in MediaEngineTabVideoSource. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 25 Aug 2016 12:25:06 +0200 - rev 318940
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Use mState in MediaEngineTabVideoSource. r=jesup MozReview-Commit-ID: 1zZlMXAqpo7
a7c8bab2624a1a1b27d6ba472815a0a09fba1b50: Bug 1295352 - Check state in MediaEngines' NotifyPull(). r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Tue, 23 Aug 2016 10:45:09 +0200 - rev 318939
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1295352 - Check state in MediaEngines' NotifyPull(). r=jesup GetEndOfAppendedData() returns null and calls a NS_ERROR() if the track we're looking for doesn't exist - to indicate an error in the caller's code. When we end a MediaEngine track we set the state to stopped, which we can use to guard the calls to GetEndOfAppendedData() (and appending data in general). The locking is already in place. MozReview-Commit-ID: DuknmBF883H