searching for reviewer(dbaron)
48ce71d365d86d41375eceb7bfc9e29a0c8c5fb1: Bug 1321127 - Add temporary annotations for asserts missed by CI, r=dbaron
James Graham <james@hoppipolla.co.uk> - Thu, 01 Dec 2016 14:24:38 +0000 - rev 325448
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321127 - Add temporary annotations for asserts missed by CI, r=dbaron These asserts appeared during the window when reftest harness assert count failures were not correctly detected by the CI system. They are expected to be fixed in followup commits. MozReview-Commit-ID: JoXtI4c0SSF
4855aa893e36a07ffd2a226b36332b545ef53a5b: Bug 140562 - Part 3: Fix up reftests to account for the fact that -moz-focus-inner no longer affects button size. r=dbaron
Thomas Wisniewski <wisniewskit@gmail.com> - Wed, 30 Nov 2016 21:43:32 -0500 - rev 325118
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 140562 - Part 3: Fix up reftests to account for the fact that -moz-focus-inner no longer affects button size. r=dbaron
f86ce2e2f6a51f351974e3781158bc0586ab71ed: Bug 140562 - Part 2: Remove the 2px extra padding on buttons for a prospective -moz-focus-inner ring, and just size that ring the same as the content frame (inflated by its CSS padding). r=dbaron
Thomas Wisniewski <wisniewskit@gmail.com> - Fri, 02 Dec 2016 01:11:48 -0500 - rev 325117
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 140562 - Part 2: Remove the 2px extra padding on buttons for a prospective -moz-focus-inner ring, and just size that ring the same as the content frame (inflated by its CSS padding). r=dbaron
f8f0eba2dcbecd7bf12f59888fade012a59da4f2: Bug 140562 - Part 1: Remove unused moz-focus-outer code for buttons. r=dbaron
Thomas Wisniewski <wisniewskit@gmail.com> - Fri, 21 Oct 2016 12:19:03 -0400 - rev 325116
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 140562 - Part 1: Remove unused moz-focus-outer code for buttons. r=dbaron
1e768923183b892c1d4f28444d426fa765913354: Bug 504622 followup for a review comment I missed. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Dec 2016 15:29:17 -0500 - rev 325071
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 504622 followup for a review comment I missed. r=dbaron
db70aca765dc6400864e16701f4c9d42866ad713: Bug 1316556 - Remove zeroing allocation in class nsIPresShell. r=dbaron.
Julian Seward <jseward@acm.org> - Thu, 01 Dec 2016 09:06:50 +0100 - rev 324990
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316556 - Remove zeroing allocation in class nsIPresShell. r=dbaron.
c91e2710718e0f29c036d87d223ba102efd650e8: Bug 1319378 - Don't set NS_FRAME_MAY_BE_TRANSFORMED against nsIFrame that does not support transforms. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Mon, 28 Nov 2016 14:19:40 +0900 - rev 324802
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319378 - Don't set NS_FRAME_MAY_BE_TRANSFORMED against nsIFrame that does not support transforms. r=dbaron MozReview-Commit-ID: CuDA14ktcDL
096c7943a1c8f97370379463bde5195f0a4029e3: Bug 504622 part 2. Allow fieldsets to shrink below their intrinsic min-width and below the width of their legend if their min-width is explicitly overridden. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Nov 2016 15:52:55 -0500 - rev 324762
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 504622 part 2. Allow fieldsets to shrink below their intrinsic min-width and below the width of their legend if their min-width is explicitly overridden. r=dbaron
694d5dac1dccbe712f9b5ff8789ae525c738f03c: Bug 504622 part 1. Rewrite fieldset border drawing to just clip to the area outside the legend instead of doing it in pieces with different clip rects. r=mattwoodrow,dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Nov 2016 15:52:30 -0500 - rev 324761
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 504622 part 1. Rewrite fieldset border drawing to just clip to the area outside the legend instead of doing it in pieces with different clip rects. r=mattwoodrow,dbaron This change will allow the border drawing code to deal with the following changes, which will make us no longer force the fieldset to be wider than the legend. Without this patch, allowing the fieldset to be narrower than the legend causes the vertical inline-start-side and inline-end-side borders of the fieldset to paint under the legend, because the current code only modifies the painting of the block-start-side border (the one the legend is positioned on). This does change behavior in one situation, which the new tests test. For relatively positioned legends, we used to use the original vertical location but the positioned horizontal location of the legend to decide which parts of the border to not paint. In the new setup, we use the original location for both. I did check that this new behavior matches Chrome and Safari. Edge seems to have our old behavior.
2e6d1dafee00c988288f4b8e3023d4df7bf792fc: Bug 1289701 - Find the root style context by walkng up the style context tree instead of calling ResolveStyleFor or getting it from root element's primary frame. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 30 Nov 2016 07:46:27 +0900 - rev 324749
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1289701 - Find the root style context by walkng up the style context tree instead of calling ResolveStyleFor or getting it from root element's primary frame. r=dbaron The only call site of CalcLengthWith() with a null style context is CalcLengthWithInitialFont(). CalcLengthWithInitialFont() calls CalcLengthWith() with a valid nsStyleFont and aUseProvidedRootEmSize true, so we can get the rem unit font size from the nsStyleFont when called from CalcLengthWithInitialFont(). MozReview-Commit-ID: A9LKfQEozaB
c024721d9b03fac54eee5730a34f8e7bfbff2129: Bug 504622 part 2. Allow fieldsets to shrink below their intrinsic min-width and below the width of their legend if their min-width is explicitly overridden. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Nov 2016 15:52:55 -0500 - rev 324730
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 504622 part 2. Allow fieldsets to shrink below their intrinsic min-width and below the width of their legend if their min-width is explicitly overridden. r=dbaron
056f728704e77c6ddc3cf9fc0f0ae8e539d73dc9: Bug 504622 part 1. Rewrite fieldset border drawing to just clip to the area outside the legend instead of doing it in pieces with different clip rects. r=mattwoodrow,dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 29 Nov 2016 15:52:30 -0500 - rev 324729
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 504622 part 1. Rewrite fieldset border drawing to just clip to the area outside the legend instead of doing it in pieces with different clip rects. r=mattwoodrow,dbaron This change will allow the border drawing code to deal with the following changes, which will make us no longer force the fieldset to be wider than the legend. Without this patch, allowing the fieldset to be narrower than the legend causes the vertical inline-start-side and inline-end-side borders of the fieldset to paint under the legend, because the current code only modifies the painting of the block-start-side border (the one the legend is positioned on). This does change behavior in one situation, which the new tests test. For relatively positioned legends, we used to use the original vertical location but the positioned horizontal location of the legend to decide which parts of the border to not paint. In the new setup, we use the original location for both. I did check that this new behavior matches Chrome and Safari. Edge seems to have our old behavior.
cb5869f00c9f6b1f6f9360e0883e958050e51502: Bug 1319672 Part 2 - Check the line direction is not changed. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 23 Nov 2016 18:10:23 +0800 - rev 324626
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319672 Part 2 - Check the line direction is not changed. r=dbaron Since the line direction affects the interpretation of float right or left, we should check aWM has the same line direction as mWritingMode. And this also guarantees that float added by AddFloat() has the same line direction as when querying the available space via GetFlowArea(). MozReview-Commit-ID: FGxVFbo910g
81eb4fbbb3ef691d439fce501778f3ef19d05f2f: Bug 1319672 Part 1 - Add document related to writing-mode in nsFloatManager. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 23 Nov 2016 18:07:56 +0800 - rev 324625
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319672 Part 1 - Add document related to writing-mode in nsFloatManager. r=dbaron MozReview-Commit-ID: 2Sr7UU6BQ9r
756713ac1804df262718024930db1fa761f8da23: Bug 389283 - Choose cursor value based on selectability. r=dbaron
Xidorn Quan <me@upsuper.org> - Fri, 25 Nov 2016 01:00:34 +1100 - rev 324565
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 389283 - Choose cursor value based on selectability. r=dbaron MozReview-Commit-ID: 2c4RcXgwz1U
8611e9d0bdaab5204a120a23b971b0c1d3a9f1b4: Bug 1319378 - Don't set NS_FRAME_MAY_BE_TRANSFORMED against nsIFrame that does not support transforms. r=dbaron
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Mon, 28 Nov 2016 14:19:40 +0900 - rev 324564
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319378 - Don't set NS_FRAME_MAY_BE_TRANSFORMED against nsIFrame that does not support transforms. r=dbaron MozReview-Commit-ID: CuDA14ktcDL
2fbf43c56b4ca7349651fd51cdf9845cece01db9: Bug 1320094 - Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor. r=dbaron.
Julian Seward <jseward@acm.org> - Mon, 28 Nov 2016 12:59:02 +0100 - rev 324439
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320094 - Add missing mLoading assignments in {nsHTMLFramesetFrame,nsHTMLFramesetBorderFrame}::GetCursor. r=dbaron.
f89eef33b118c06c0b90faee269db4840d3301a5: Bug 1258916 part 10 - Not attach HTTP directive to tests which need ahem font. r=dbaron
Xidorn Quan <me@upsuper.org> - Mon, 28 Nov 2016 10:13:08 +1100 - rev 324409
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1258916 part 10 - Not attach HTTP directive to tests which need ahem font. r=dbaron MozReview-Commit-ID: E4ItEEmThcC
f8f9cdefb1f832c7f0d91083ed05e6b3788110b9: Bug 1258916 part 9 - Optimize re.sub usage in import script. r=dbaron
Xidorn Quan <me@upsuper.org> - Mon, 28 Nov 2016 10:13:08 +1100 - rev 324408
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1258916 part 9 - Optimize re.sub usage in import script. r=dbaron This reduces the time to import by ~30% with css-writing-modes included. MozReview-Commit-ID: JsnkRfTFnp6
ce2b35bf0048555354a5684c1c2b7c8d27b06b65: Bug 1320423 - Null check cursor images to handled failed loads. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sat, 26 Nov 2016 15:00:53 +0800 - rev 324387
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320423 - Null check cursor images to handled failed loads. r=dbaron
e9872fff04e29255714658452af04f58e885747d: Bug 1316549 Part 4 - Use logical names for ComputeEllipseLineInterceptDiff(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 13:54:09 +0800 - rev 324038
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316549 Part 4 - Use logical names for ComputeEllipseLineInterceptDiff(). r=dbaron This patch is just renames. No logic change for the function. MozReview-Commit-ID: K7w0YL3G3gu
0d04f4ee523b3897d1e8b3addeefd1513076e29a: Bug 1316549 Part 3 - Fix <shape-box> with border-radius in writing-mode. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 14 Nov 2016 18:11:45 +0800 - rev 324037
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316549 Part 3 - Fix <shape-box> with border-radius in writing-mode. r=dbaron The tests cases are designed based on the integer solution to the ellipse equation (x/a)^2 + (y/b)^2 = 1, where x=36, y=32, a=60, b=40. MozReview-Commit-ID: De2fXcb6ypP
aaf70a7cd344ceb7ea9c78d7807bb15283918d0f: Bug 1316549 Part 2 - Fix assertion failure: aRadiusY > 0 in FloatInfo::XInterceptAtY(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 14 Nov 2016 18:11:45 +0800 - rev 324036
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316549 Part 2 - Fix assertion failure: aRadiusY > 0 in FloatInfo::XInterceptAtY(). r=dbaron We need to consider the case when only one of the four corner radius is specified. The two reftests are added to test 'border-top-right-radius' and 'border-bottom-right-radius', respectively. MozReview-Commit-ID: De2fXcb6ypP
a214a23b603eb5dedf8210ae9d027b985fb60835: Bug 1223561 - Support putting <table> into fullscreen. r=dbaron
Xidorn Quan <me@upsuper.org> - Tue, 22 Nov 2016 16:31:56 +1100 - rev 323974
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1223561 - Support putting <table> into fullscreen. r=dbaron MozReview-Commit-ID: 5ohJW9U65dr
535f8682016bdc71be4d604bdf61c9247ca47feb: Bug 1223561 - Support putting <table> into fullscreen. r=dbaron
Xidorn Quan <me@upsuper.org> - Tue, 22 Nov 2016 16:31:56 +1100 - rev 323960
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1223561 - Support putting <table> into fullscreen. r=dbaron MozReview-Commit-ID: 5ohJW9U65dr
07ed7e5fa5ff504ce36ce72758dc9418ef6035c3: Bug 1317732 - Reduce logging in test_value_storage.html on Android only; r=dbaron
Geoff Brown <gbrown@mozilla.com> - Fri, 18 Nov 2016 15:00:41 -0700 - rev 323529
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317732 - Reduce logging in test_value_storage.html on Android only; r=dbaron
73ed02918ff7faf9f00ecaf514029010441bacc7: Bug 1046166 - Send userContent.css URL to content processes. r=dbaron,haik
Wei-Cheng Pan <wpan@mozilla.com> - Thu, 21 Jul 2016 18:57:35 +0800 - rev 323420
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1046166 - Send userContent.css URL to content processes. r=dbaron,haik MozReview-Commit-ID: 4NTxwYeFGSU
662953491bfd4590c33df5e0b54eb44315e212d2: Bug 1293743 - Part 4: Implement ParseVariant for VARIANT_INTEGER | VARIANT_CALC (i.e. pure-integer calc()s). r=dbaron,dholbert
Jonathan Chan <jyc@eqv.io> - Mon, 17 Oct 2016 21:32:19 -0400 - rev 323053
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1293743 - Part 4: Implement ParseVariant for VARIANT_INTEGER | VARIANT_CALC (i.e. pure-integer calc()s). r=dbaron,dholbert MozReview-Commit-ID: 5vKgaH3dN5X
979937f3349eb35f1d59f4cad743bf7abb3f20a8: Bug 1309467 Part 5 - Make flow area of <shape-box> values respect border-radius. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Thu, 13 Oct 2016 16:28:38 +0800 - rev 322470
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1309467 Part 5 - Make flow area of <shape-box> values respect border-radius. r=dbaron In GetFlowArea(), "Shrink our band's height if needed." computation was moved to the end because we need to pass the unmodified |blockEnd| to compute LineRight() and LineLeft(). Revamp OutsetBorderRadii() to allow negative margin to reduce the radius, but not below zero. Also implement the cubic formula required by the spec. https://drafts.csswg.org/css-shapes/#valdef-shape-box-margin-box OutsetBorderRadii() is now tailored only for margin-box with border-radius, so it might no longer be suitable for other scenarios. MozReview-Commit-ID: HKxW7rp6sIA
892b614625fe7bf340444ad4ad17f6e206fe82a3: Bug 1309467 Part 4 - Implement <shape-box> values for shape-outside. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 Oct 2016 16:06:25 +0800 - rev 322469
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1309467 Part 4 - Implement <shape-box> values for shape-outside. r=dbaron Per spec, float positioning and stacking is not affected by defining a float area with a shape. https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior So all the call sites of GetFloatAvailableSpace() related to adding a float are replaced by GetFloatAvailableSpaceForPlacingFloat(). <shape-box> with border-radius will be implemented in next part. MozReview-Commit-ID: 1RXEeXDhdWo
4ff1f76b04983b95339637aedf966eb98ccc8850: Bug 1309467 Part 3 - Move FloatInfo::mRect construction into FloatInfo's constructor. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 Oct 2016 14:26:26 +0800 - rev 322468
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1309467 Part 3 - Move FloatInfo::mRect construction into FloatInfo's constructor. r=dbaron In later parts, we need the aMarginRect to build rect for shape box. MozReview-Commit-ID: LtwMxbsNu3u
9ac5a902d5198d91e597e7a46bede3fd77c89951: Bug 1309467 Part 2 - Convert BandInfoType to an enum class. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 Oct 2016 13:26:17 +0800 - rev 322467
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1309467 Part 2 - Convert BandInfoType to an enum class. r=dbaron Also exchange the order of the second argument |aBSize| and the third argument |aBandInfo| for GetFlowArea() so that aBCoord and aBSize are grouped together. And it'll be prettier to add ShapeInfo behind BandInfo in later part. MozReview-Commit-ID: cusdomjUyu
3c12d8818326e5cb5b1ba9f7e35fba392351a699: Bug 1309467 Part 1 - Rename aBOffset to aBCoord in nsFloatManager::GetFlowArea(). r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Wed, 12 Oct 2016 13:01:19 +0800 - rev 322466
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1309467 Part 1 - Rename aBOffset to aBCoord in nsFloatManager::GetFlowArea(). r=dbaron The header file and its documentation uses |aBCoord| so I change the implementation for consistency. MozReview-Commit-ID: 99mEUgUwcBV
f5031fb2bc5e9f7d69f6e7c3d6381f66e7728b0d: Bug 1317092 - Fix metadata for logical-to-physical-mapping-001; r=dbaron
Manish Goregaokar <manishearth@gmail.com> - Sat, 12 Nov 2016 16:13:14 -0800 - rev 322249
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317092 - Fix metadata for logical-to-physical-mapping-001; r=dbaron MozReview-Commit-ID: HX65RbpAVRK
498f5669f48db0d57c6edb53f1d5ef3eb507833b: Bug 1258916 part 8 - Change most uses of 'fn' to 'srcname' to make it clearer. rs=dbaron
Xidorn Quan <me@upsuper.org> - Fri, 11 Nov 2016 21:35:38 +1100 - rev 322170
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1258916 part 8 - Change most uses of 'fn' to 'srcname' to make it clearer. rs=dbaron MozReview-Commit-ID: HxHRj2He6cw
f33bcb35609a9c0a5a2173951f99e4ddcff9a536: Bug 1258916 part 7 - Use the directory structure from upstream repo for test and reference files. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Fri, 11 Nov 2016 21:35:38 +1100 - rev 322169
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1258916 part 7 - Use the directory structure from upstream repo for test and reference files. r=dbaron MozReview-Commit-ID: E9HCyCGMtqp
6bdf4b5b69d13ff2728ef77c6353b7630e091c91: Bug 1315353 - Part 2: Add testcase for border-image-repeat with SVG content. r=dbaron
Ethan Lin <ethlin@mozilla.com> - Tue, 08 Nov 2016 11:46:46 +0800 - rev 322069
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315353 - Part 2: Add testcase for border-image-repeat with SVG content. r=dbaron
b14c86a0fb84c5ef7c6d5c1c5d8424b847b17760: Bug 1315353 - Part 1: Fix the wrong image size of border-image-repeat while the content is SVG. r=dbaron
Ethan Lin <ethlin@mozilla.com> - Tue, 08 Nov 2016 11:46:46 +0800 - rev 322068
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315353 - Part 1: Fix the wrong image size of border-image-repeat while the content is SVG. r=dbaron
742ff7058a1efa990fe9eacb1b3c1bdeaad60c6b: Bug 1316172 - Add a reftest for logical properties; r=dbaron
Manish Goregaokar <manishearth@gmail.com> - Tue, 08 Nov 2016 15:03:08 -0800 - rev 322018
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316172 - Add a reftest for logical properties; r=dbaron MozReview-Commit-ID: J9PZVBoK0Fg
ae7543286030724b9aa495792c86085265e0f711: Bug 1291110 Part 4 - Use line BSize to query available space when updating nsLineLayout. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 22 Aug 2016 19:42:37 +0800 - rev 321891
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1291110 Part 4 - Use line BSize to query available space when updating nsLineLayout. r=dbaron In nsBlockFrame::PlaceLine(), we query the float available space by using the line's BSize(), which may cause the line to reflow again due to available space shrunk. The first issue lies in the second reflow. That is, we do not leverage the line's BSize() computed in the first reflow to query the float available space when updating the inline reflow engine in BlockReflowInput::AddFloat(). So some tall inline elements could still overlap the floats as in the first reflow. To solve this, we cache current line's BSize so that it could be used to update the inline reflow engine when redo the line. Another issue is in nsBlockFrame::PlaceLine(). When determined whether the available space is shrunk, we use the float manager's state *before* placing the line. So if current line has floats, they're not considered. To solve this, we use the current set of floats to get the float available space for comparison, and leave the original aFloatAvailableSpace to provide the information when redoing the line. MozReview-Commit-ID: GqqNlphgxYS
5ebd8aebc99f26443b596cb026ab025585a9260d: Bug 1291110 Part 3 - Enforce float available space never grow on either side. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Nov 2016 15:20:58 +0800 - rev 321890
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1291110 Part 3 - Enforce float available space never grow on either side. r=dbaron This patch is based on bug 1291110 comment 29, but |aCanGrow| is preserved, since the set of float available spaces we'll be testing in Part 4 are difference from the one we enforced here. MozReview-Commit-ID: LswbIaRukVR
0ddd1de392d811da6cf3497a42f2b833e53c093e: Bug 1291110 Part 2 - Rename availableSpaceHeight to availableSpaceBSize. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Tue, 08 Nov 2016 13:42:14 +0800 - rev 321889
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1291110 Part 2 - Rename availableSpaceHeight to availableSpaceBSize. r=dbaron Rename to make the variable name consistent with the writing-mode terminology used in PlaceLine(). MozReview-Commit-ID: AvhwHyHz7hV
0bc5e1c941a21a32668adae737030887a7865fba: Bug 1291110 Part 1 - Fix log and comment related to float. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 22 Aug 2016 19:41:53 +0800 - rev 321888
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1291110 Part 1 - Fix log and comment related to float. r=dbaron MozReview-Commit-ID: ICUflMUOsD2
a1af90b862e1514a0606876f28a8dc5cf4a186c8: Bug 1315368. Back out changeset bf190e326bfd (bug 790997) because what it implements doesn't actually follow the CSS syntax editor's draft and breaks some sites in the process. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 05 Nov 2016 00:23:16 -0400 - rev 321327
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315368. Back out changeset bf190e326bfd (bug 790997) because what it implements doesn't actually follow the CSS syntax editor's draft and breaks some sites in the process. r=dbaron
ad249ce81497259edc016f4c6957a256a455dbc0: Bug 582951 - Use CSS outline for checkbox and radio button focus indicator. r=dbaron,jimm
Dão Gottwald <dao@mozilla.com> - Sat, 22 Oct 2016 08:28:53 +0200 - rev 319043
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 582951 - Use CSS outline for checkbox and radio button focus indicator. r=dbaron,jimm
df0022e05784068c0d9925bd69049af18f54522c: Bug 1304556 part 2 - Use AutoLineCursorSetup to optimize pre-render innerText query. r=dbaron
Xidorn Quan <me@upsuper.org> - Fri, 21 Oct 2016 11:53:12 +1100 - rev 318961
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1304556 part 2 - Use AutoLineCursorSetup to optimize pre-render innerText query. r=dbaron MozReview-Commit-ID: G0I4MPSeV38
7e8d0d68f550e00f8c9ad628923a9e6b5fa6e011: Bug 1304556 part 1 - Add AutoLineCursorSetup RAII class for local line cursor setup. r=dbaron
Xidorn Quan <me@upsuper.org> - Fri, 21 Oct 2016 12:41:52 +1100 - rev 318960
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1304556 part 1 - Add AutoLineCursorSetup RAII class for local line cursor setup. r=dbaron MozReview-Commit-ID: G5xeCkxsm8N
276f973ad01c870867da36c5f2f5a895a355653b: Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron
Neerja Pancholi <npancholi@mozilla.com> - Mon, 10 Oct 2016 13:16:57 -0700 - rev 317492
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron Also make necessary updates to tests like: 1. unprefixing in property_database.js and added new aliases there 2. unprefixing in test_transitions_per_property.html 3. update nsComputedDomStylePropertyList.h 4. update devtools' property database MozReview-Commit-ID: B3kOFrM9EL
b7c0df58a2f4e68d719ba9d49fee3c7c807fc10a: Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron
Neerja Pancholi <npancholi@mozilla.com> - Mon, 10 Oct 2016 13:16:57 -0700 - rev 317369
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron Also make necessary updates to tests like: 1. unprefixing in property_database.js and added new aliases there 2. unprefixing in test_transitions_per_property.html 3. update devtools' property database MozReview-Commit-ID: B3kOFrM9EL
1982d92ae18067444ddf867e458b86c5073cb7bd: Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron
Neerja Pancholi <npancholi@mozilla.com> - Mon, 03 Oct 2016 19:15:01 -0700 - rev 317090
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1300895 - Unprefix CSS multi-column properties, but add back prefixed aliases via nsCSSPropAliasList.h r=dbaron Also make necessary updates to tests like: 1. unprefixing in property_database.js and added new aliases there 2. unprefixing in test_transitions_per_property.html MozReview-Commit-ID: B3kOFrM9EL