searching for reviewer(chmanchester)
2c698b01dfe8a2639cb825fdb138baa7fe44c113: Bug 1319227 - Support ObjdirFiles in tup; r=chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 06 Dec 2016 19:39:01 -0500 - rev 325364
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319227 - Support ObjdirFiles in tup; r=chmanchester MozReview-Commit-ID: 5AXDZUzlg4t
6b3b26d63719ceeb45c0219f6fb1eb58af3b49d3: Bug 1322301 - Add flags to GeneratedFiles in the tup backend; r=chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 06 Dec 2016 19:35:12 -0500 - rev 325363
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1322301 - Add flags to GeneratedFiles in the tup backend; r=chmanchester MozReview-Commit-ID: 5N6jm6RMitD
79b6b6ff9a1b07b2a1b76c933c38a4daebc40e42: Bug 1311224 - Talos jobs don't get scheduled for artifact builds on try; r=chmanchester
Maja Frydrychowicz <mjzffr@gmail.com> - Tue, 06 Dec 2016 23:40:25 -0500 - rev 325357
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1311224 - Talos jobs don't get scheduled for artifact builds on try; r=chmanchester Enabled talos sendchange on linux,linux64,win32,win64,macosx64. MozReview-Commit-ID: 8M0VSZ5fr8d
db686076ae29249df47ff792c996de293d23cd6f: Bug 1319156 - part 3 - tests for Rust library features, frontend and backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 325174
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319156 - part 3 - tests for Rust library features, frontend and backend; r=chmanchester This commit also adds an overdue test for plain Rust libraries in the recursivemake backend, but said test also serves to ensure that we don't emit features for a library if none were defined in moz.build.
b5de6b777970f98b97e9f33db1e7e8b4a7deeeab: Bug 1319156 - part 2 - handle Rust library features in the recursivemake backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 325173
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319156 - part 2 - handle Rust library features in the recursivemake backend; r=chmanchester
8276296cd50509ba109d115d7b1d3b28b761e97c: Bug 1319156 - part 1 - add features to RustLibrary objects and moz.build definitions; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:39:15 -0500 - rev 325172
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319156 - part 1 - add features to RustLibrary objects and moz.build definitions; r=chmanchester Ideally, people will just use the extra argument to RustLibrary to define features for their library.
d9d80b5b44fc7b11a935e853844caa8b51cf16d7: Bug 1318981 - part 2 - pass MOZ_DIST as an environment variable to `cargo build`; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:38:45 -0500 - rev 325171
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318981 - part 2 - pass MOZ_DIST as an environment variable to `cargo build`; r=chmanchester rust-bindgen, at least, will need to know where Gecko's headers are to parse them.
f49a4f2953f35a1161d79902ba71e26592371c3d: Bug 1318981 - part 1 - factor out a CARGO_BUILD makefile variable; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Fri, 02 Dec 2016 11:38:45 -0500 - rev 325170
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1318981 - part 1 - factor out a CARGO_BUILD makefile variable; r=chmanchester This change makes the individual cargo rules easier to understand, and provides a single place to change e.g. environment variables passed to cargo.
02aa6ad54a6ecd18d1e9d5f219f12ac74a8db9e6: Bug 1321696 - Require rust 1.13 with --enable-rust. r=chmanchester
Ralph Giles <giles@mozilla.com> - Thu, 01 Dec 2016 17:35:52 -0800 - rev 325153
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321696 - Require rust 1.13 with --enable-rust. r=chmanchester Bug 1320425 using the '?' operator stabilized in rust 1.13.0. Update the minimum supported version to reflect this. MozReview-Commit-ID: 3HKrhfNavEZ
0a1c6a0b270dc6b13b819731d1eac28a02b36a46: Bug 1321691 - Suggest boostrap if configure fails to find rust. r=chmanchester
Ralph Giles <giles@mozilla.com> - Thu, 01 Dec 2016 17:01:55 -0800 - rev 325152
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321691 - Suggest boostrap if configure fails to find rust. r=chmanchester Now that `./mach boostrap` installs rustup, suggest this if configure fails to find the toolchain when building with --enable-rust. Also point out https://rustup.rs/ for those who want more control. MozReview-Commit-ID: 8JIbERfz12f
cd6aa4390d359320b0eeed1e1a6823a01516f115: Bug 1320741 - Recommend `rustup target add`. r=chmanchester
Ralph Giles <giles@mozilla.com> - Mon, 28 Nov 2016 10:51:59 -0800 - rev 325038
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320741 - Recommend `rustup target add`. r=chmanchester Provide some guidance on how to resolve the common error: can't find crate for `std` when cross-compiling rust code. This most commonly comes up with the Android build. MozReview-Commit-ID: 8PKKt7tf1KS
f72e2fa55bf5c2e87b1e5f6f1c7657ff7a635dfb: Bug 1285608 - Part 2: Make --artifact handle Android builds. r=chmanchester,maja_zf
Nick Alexander <nalexander@mozilla.com> - Tue, 29 Nov 2016 19:52:01 -0800 - rev 324852
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1285608 - Part 2: Make --artifact handle Android builds. r=chmanchester,maja_zf I'm not a fan of introducing a new configuration flags (and not knowing where or how to document it!), but there's a clear need for configuration in the absence of a documented way to add a coherent "artifact build dimension" akin to "opt/debug". I like adding a subtle tri-state flag even less, but I tried this with two flags (ignore and build-variant) and it was worse, so I'm rolling with a tri-state flag. MozReview-Commit-ID: KTNvacTBUXB
4b304f6f7c92f39b19981f7df1f47e1da1a60c3f: Bug 1314679 - Remove inherited mh config to support tc win artifact builds. r=chmanchester
Rob Thijssen <rthijssen@mozilla.com> - Fri, 25 Nov 2016 12:30:09 +0000 - rev 324829
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1314679 - Remove inherited mh config to support tc win artifact builds. r=chmanchester MozReview-Commit-ID: u5zCj9Sg4r
d63d083ab7672423620d6d83366d3e1cbae86bad: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Sat, 12 Nov 2016 06:05:07 +0900 - rev 324788
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
8c1409a443ee41860f8caaf59a149ab83c467736: Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:47:10 +0900 - rev 324787
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317504 - Don't try to set LD from old-configure. r=chmanchester Now, it's completely unused.
6353e704bf2c4d47610f0e3555d2fd47c002ebda: Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:45:16 +0900 - rev 324786
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317504 - Make MSVC builds use the LINK variable instead of LD. r=chmanchester At the same time, remove HOST_LD. It was only used for MSVC builds, which don't support cross-compile anyways, so we can, at least for now, use LINK for both host and target.
fd007caf51dfebb5224316c5d0978d15a2cfcc4b: Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:25:42 +0900 - rev 324785
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317504 - Remove the GNU_LD variable, nothing uses it. r=chmanchester
677f47fec9e7f21f1188c1a1d437d33f749cafc6: Bug 1317504 - Remove unused non-GCC/clang flags settings. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:17:59 +0900 - rev 324784
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317504 - Remove unused non-GCC/clang flags settings. r=chmanchester Compilers other than GCC, clang and MSVC have not been supported for a while, and have been explicitly rejected since bug 1259382. There are a few branches in old-configure that are taken for non-GCC/clang compilers, but all of them are later overwritten by the MSVC setup. So we just remove those.
cffe1cd111f65c9045cc8e1fe34d845a9a6b5c28: Bug 1317504 - Warn that LD is not used by the build system. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 24 Nov 2016 15:07:01 +0900 - rev 324783
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317504 - Warn that LD is not used by the build system. r=chmanchester It turns out that, in practice, the LD variable is not used by the build system, except on Windows, where it's used to feed the default for LINK, which is then re-injected as LD. The upcoming changes are going to normalize the use of LD/LINK.
09f249970fc319f7810d80886d34de54175abf8a: Bug 1293253 - part 10 - emit {Host,}RustProgram objects from the frontend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:38 -0500 - rev 324487
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 10 - emit {Host,}RustProgram objects from the frontend; r=chmanchester
27c257be4c2e18221ee679c48e342b0b5b0ca9ed: Bug 1293253 - part 9 - handle {Host,}RustProgram objects in the recursivemake backend; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324486
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 9 - handle {Host,}RustProgram objects in the recursivemake backend; r=chmanchester
b3505dd036cfa0db0c3a2c2047c1b3b6b458566e: Bug 1293253 - part 8 - factor out a unique binary check function; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324485
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 8 - factor out a unique binary check function; r=chmanchester We'll need this for Rust programs as well.
fcc7e0fd607c0ec2270744f26560be13ff4bc0e9: Bug 1293253 - part 7 - factor out a Cargo.toml-for-context parsing function; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324484
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 7 - factor out a Cargo.toml-for-context parsing function; r=chmanchester We'll need a function to do this for Rust program definitions, so we might as well use one that's already there for Rust library definitions.
0d91224e1389d87439ee8af1f1f0d398049aaa3c: Bug 1293253 - part 6 - add build and installation rules for {HOST_,}RUST_PROGRAMS; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324483
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 6 - add build and installation rules for {HOST_,}RUST_PROGRAMS; r=chmanchester The only complicating factor here is having to split out the --target flag from cargo_build_flags, so we can pass the appropriate one depending on our build target.
bc2b70ec392bff7672decd92483eed5553eb0310: Bug 1293253 - part 5 - move cargo_build_flags determination out of RUST_LIBRARY_FILE block; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324482
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 5 - move cargo_build_flags determination out of RUST_LIBRARY_FILE block; r=chmanchester We need cargo_build_flags not just for Rust libraries now, but for Rust programs as well.
5586b76ab2a4c7b059485206e36217bc8c0bc4d2: Bug 1293253 - part 4 - add frontend objects for Rust programs; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324481
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 4 - add frontend objects for Rust programs; r=chmanchester
009cffc985ab7e9b5736edfd6c68f9f5203915bb: Bug 1293253 - part 3 - add configure support for determining a --target value for Rust host code; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324480
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 3 - add configure support for determining a --target value for Rust host code; r=chmanchester We'll need this for compiling host binaries. We could just call `rustc` without any --target value whatsoever, but since we use --target for target code, we might as well be consistent and explicit, and use --target for host code as well.
779d75b98fc5b19a8e45a82ad357f0ecbedcdcd9: Bug 1293253 - part 2 - split out cargo_target_directory; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324479
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 2 - split out cargo_target_directory; r=chmanchester We're going to need this functionality for Rust programs as well as Rust libraries, so we might as well move the functionality out of RustLibrary into a separate function.
03549e92001dda90199b2cbab7f1985b61e8fa07: Bug 1293253 - part 1 - modify existing Rust library build rules to be explicitly about libraries; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Mon, 28 Nov 2016 11:20:39 -0500 - rev 324478
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1293253 - part 1 - modify existing Rust library build rules to be explicitly about libraries; r=chmanchester In preparation for a world where we have cargo building binaries too, the existing rules should be renamed to reflect their library associations. The lone Cargo invocation should be updated to explicitly build libraries only, so libraries and binaries in the same directory will work correctly. Fixup a leftover comment from a previous set of changes while we're here.
9100b758e2580c05ddf8c8ac0f17ab4d8fc26809: Bug 1317970 - Filter python unittests through manifestparser.active_tests, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 17 Nov 2016 16:30:27 -0500 - rev 323666
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317970 - Filter python unittests through manifestparser.active_tests, r=chmanchester The build system's TestResolver does a pretty good job of getting the right manifestparser based tests to run, but it isn't perfect. Notably, it ignores the 'disabled' key. We filter the tests through manifestparser here to make sure the build system didn't miss anything. For context, this is also what the other test harnesses (e.g mochitest) do as well. MozReview-Commit-ID: FaHb4nvuoK9
068f2a43fe68d786814e3789b4966344449daea1: Bug 1317970 - Use manifestparser manifests for python unit tests, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Wed, 16 Nov 2016 09:59:22 -0500 - rev 323665
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317970 - Use manifestparser manifests for python unit tests, r=chmanchester This deprecates PYTHON_UNIT_TESTS and replaces it with PYTHON_UNITTEST_MANIFESTS. In the build system, this means python unittests will be treated the same as all other test suites that use manifestparser. New manifests called 'python.ini' have been created for all test directories containing python unittests. MozReview-Commit-ID: IBHG7Thif2D
55405892e588fa851979d8ea31a656853666b40f: Bug 1317970 - Make mozbase tests use mozunit for consistent formatting, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 17 Nov 2016 16:36:18 -0500 - rev 323664
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317970 - Make mozbase tests use mozunit for consistent formatting, r=chmanchester The mozbase unittests don't use mozunit, so their output is confusing in the log. This makes mozbase output consistent with the rest of the python unittests. MozReview-Commit-ID: AIs5mza8Rn6
b4b8e2baeec2a3c82b42e68390eb3bac3ebe6059: Bug 1317970 - Move mozsystemmonitor tests to a consistent directory structure, r=chmanchester
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 17 Nov 2016 16:36:13 -0500 - rev 323663
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317970 - Move mozsystemmonitor tests to a consistent directory structure, r=chmanchester The mozsystemmonitor test is under mozsystemmonitor/mozsystemmonitor/test instead of mozsystemmonitor/tests like all the other mozbase modules. MozReview-Commit-ID: AIs5mza8Rn6
cad7e38527b98bbfcc174bea2f00df99d96d1dac: Bug 1315810 - Support some FinalTargetFiles in the tup backend; r=chmanchester
Mike Shal <mshal@mozilla.com> - Sat, 08 Oct 2016 11:49:20 -0400 - rev 323363
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315810 - Support some FinalTargetFiles in the tup backend; r=chmanchester MozReview-Commit-ID: 68b596wAp8g
7a1621d1bea10e135a9c9800f067796cbc02ae9c: Bug 1315810 - Use tup's internal symlinking instead of build manifests; r=chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 30 Sep 2016 11:16:41 -0400 - rev 323362
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315810 - Use tup's internal symlinking instead of build manifests; r=chmanchester MozReview-Commit-ID: LNsbghIGJvH
8b122a300411387d7c976b16517472053c27137e: Bug 1318574 - Support buildbot and TC jobs for opt android artifact builds; r=chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 18 Nov 2016 13:54:12 -0500 - rev 323354
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1318574 - Support buildbot and TC jobs for opt android artifact builds; r=chmanchester MozReview-Commit-ID: YkgUJEZiUU
2fa61db0ad05e0d55f58ed2046c8a41503a3ce13: Bug 1317101 - Part 8a: Read defaults from ancestor manifests when processing test metadata. r=chmanchester
Kris Maglione <maglione.k@gmail.com> - Sat, 12 Nov 2016 18:30:47 -0800 - rev 323249
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317101 - Part 8a: Read defaults from ancestor manifests when processing test metadata. r=chmanchester MozReview-Commit-ID: 90ldX6DuKBy
e06d269a5d4f35b608b5bc7f1c61e875f2322b45: Bug 1317101 - Part 8a: Read defaults from ancestor manifests when processing test metadata. r=chmanchester
Kris Maglione <maglione.k@gmail.com> - Sat, 12 Nov 2016 18:30:47 -0800 - rev 322938
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317101 - Part 8a: Read defaults from ancestor manifests when processing test metadata. r=chmanchester MozReview-Commit-ID: 90ldX6DuKBy
40935ab99b85c527fa10fcb99a40636fdb6b4e58: Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 07:43:39 +0900 - rev 322654
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
387015ba9c7462a3aa639f7de3c6c17be48bdb08: Bug 1317359 - Move add_old_configure_* functions to util.configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 14:35:22 +0900 - rev 322653
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317359 - Move add_old_configure_* functions to util.configure. r=chmanchester
6d6366a2842e26aabec2ad47b94e819de661ba05: Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 07:43:39 +0900 - rev 322476
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
c403ebdab6b84c5a31392c0f8ac4ae269cea8de0: Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 15 Nov 2016 07:43:39 +0900 - rev 322463
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
f44dbf7e6f4c96d960a58ed77274eec619a87c8a: Bug 1316844 - Make the linter detect unused dependencies. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 12:52:58 +0900 - rev 322461
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316844 - Make the linter detect unused dependencies. r=chmanchester
e9f19254a85d07fd2b4e3fda76210b355ac52b48: Bug 1316844 - Remove unused dependencies. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 12:52:37 +0900 - rev 322460
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316844 - Remove unused dependencies. r=chmanchester
f45564cb091fb98a058f470de5e1f5857683870f: Bug 1316844 - Improve function unwrapping to properly cover templates. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 11 Nov 2016 11:32:43 +0900 - rev 322459
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316844 - Improve function unwrapping to properly cover templates. r=chmanchester
2b174353e76a8c7b7595f29b21a797f8f84af72c: Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Sat, 12 Nov 2016 06:05:07 +0900 - rev 322241
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win. r=chmanchester
fb579bc49c2f153e61cf06b34bcd6a03a409e6c4: Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:32:28 +0900 - rev 321878
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316250 - Allow functions using the fake os module to not depend on --help. r=chmanchester
53f988e1c1fd34ca2ff5f42a59fa05b4a768a1e5: Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Wed, 09 Nov 2016 15:22:17 +0900 - rev 321877
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316250 - Don't pretend imported modules in templates are inherited by functions they contain. r=chmanchester The current state of python configure sandbox execution is that if a template imports a module, and a function defined in the template tries to use the module, it doesn't work. Ideally, it would, but rather than try to fix this corner case, we remove the unit tests that assume it works (and consequently pass for half bad reasons), and add a unit test so that the behavior doesn't change unwillingly.
1a61a17b9986e0ecb70d33ed28cb512c0843ed0a: Bug 1314894 - Avoid path changes from b6be0e9e3e1e. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 04 Nov 2016 06:50:43 +0900 - rev 320991
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1314894 - Avoid path changes from b6be0e9e3e1e. r=chmanchester Importing 'os' in python configure functions, on Windows, changes the separate the various os.path functions use, and that can have unexpected, badly handled, consequences. While on the long term, it is desirable to make @imports('os') modify os.path to use the same base functions as if there were no @imports, let's go with the simpler workaround of restoring the non-{isfile,isdir,exists} os.path functions from b6be0e9e3e1e.
f74ebe3e7a86429a4157049956996a84a2ef0c25: Bug 1313028 - GCC 6 null pointer check removal causes segfaulting in ActionResultHolder::GetValueAndDelete(). r=chmanchester.
Julian Seward <jseward@acm.org> - Tue, 01 Nov 2016 17:23:46 +0100 - rev 320619
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1313028 - GCC 6 null pointer check removal causes segfaulting in ActionResultHolder::GetValueAndDelete(). r=chmanchester.