searching for reviewer(Waldo)
1e905d6da8356a1da48d43afb4bbbc54b4b5ae02: Bug 1246597 - adapt existing DataView tests to SharedArrayBuffer. r=waldo
Lars T Hansen <lhansen@mozilla.com> - Wed, 07 Dec 2016 14:22:35 -1000 - rev 325482
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1246597 - adapt existing DataView tests to SharedArrayBuffer. r=waldo
9287824003f42411c84cdf4b7b3506371c57a582: Bug 1246597 - support DataView on SharedArrayBuffer. r=waldo
Lars T Hansen <lhansen@mozilla.com> - Wed, 07 Dec 2016 14:21:24 -1000 - rev 325451
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1246597 - support DataView on SharedArrayBuffer. r=waldo
3a52f03ddcb07c790965426a156b3cd0d0b1685e: Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo)
Luke Wagner <luke@mozilla.com> - Mon, 05 Dec 2016 15:59:18 -0800 - rev 325297
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo)
f38852711f383117b245c47db466764cd0a0b8b8: Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo)
Luke Wagner <luke@mozilla.com> - Mon, 05 Dec 2016 08:46:27 -0600 - rev 325287
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1320905 - Add js::RefCounted that uses js_delete (r=waldo) MozReview-Commit-ID: D0mSwdm0nn0
2f51065d18691e3bab09abf3224b0f4e134d451f: Bug 1321030: Update tzdata in ICU data files to 2016j. r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 29 Nov 2016 15:16:21 -0800 - rev 325264
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1321030: Update tzdata in ICU data files to 2016j. r=Waldo
77ce40d94cfabce30efafe88835cb7bbe485ba19: Bug 1319831 - Clarify some code with explicit casts; r=Waldo
Ms2ger <Ms2ger@gmail.com> - Thu, 01 Dec 2016 09:23:21 +0100 - rev 324977
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319831 - Clarify some code with explicit casts; r=Waldo
296b9cc46b97eaa009a978c32f5a2c6486032677: Bug 1319831 - Remove an unbalanced pragma from Vector.h; r=Waldo
Ms2ger <Ms2ger@gmail.com> - Thu, 01 Dec 2016 09:23:21 +0100 - rev 324976
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319831 - Remove an unbalanced pragma from Vector.h; r=Waldo
12718a74c79f3b720f5a0cef171242ab2e10b8b8: Bug 1287677 - Add mozIntl.getDisplayNames API. r=Waldo
Zibi Braniecki <gandalf@mozilla.com> - Mon, 28 Nov 2016 12:06:20 -0800 - rev 324687
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1287677 - Add mozIntl.getDisplayNames API. r=Waldo MozReview-Commit-ID: GYVlvSv3Yd9
fcdea0f0691b930b8d7ef78d6d17a1ee92ae8bce: Bug 1319673 - Make it compile error when instantiate a Variant with duplicate type. r=Tomcat,Waldo
James Cheng <jacheng@mozilla.com> - Wed, 23 Nov 2016 15:12:50 +0800 - rev 324237
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319673 - Make it compile error when instantiate a Variant with duplicate type. r=Tomcat,Waldo MozReview-Commit-ID: IKoLU2FjtzA
968fe7fa5d930f46e8b2caf2e24e316beed02f5d: Bug 1319464 - Replace flattened with linear strings in Intl.cpp file. r=Waldo
André Bargull <andre.bargull@gmail.com> - Wed, 23 Nov 2016 09:12:51 -0800 - rev 324135
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319464 - Replace flattened with linear strings in Intl.cpp file. r=Waldo
4a29a037a33525700c5d8f8f1953e8e24c836048: Bug 1317761 - Standardise names of tracing methods r=jandem r=h4writer r=waldo r=bbouvier
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 23 Nov 2016 17:45:47 +0000 - rev 324119
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1317761 - Standardise names of tracing methods r=jandem r=h4writer r=waldo r=bbouvier
7251919f6a2318ab715085c4162d927455bae6b7: Bug 1319464: Replace flattened with linear strings in Intl.cpp file. r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 22 Nov 2016 09:29:49 -0800 - rev 324101
Push 24 by maklebus@msu.edu at Tue, 20 Dec 2016 03:11:33 +0000
Bug 1319464: Replace flattened with linear strings in Intl.cpp file. r=Waldo
db60e23a4c5baf00f28d1d0ed5af9cb578307e22: Bug 1303091 - Share static Intl data across compartments. r=Waldo, r=jonco
André Bargull <andre.bargull@gmail.com> - Thu, 17 Nov 2016 14:40:18 -0800 - rev 323768
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1303091 - Share static Intl data across compartments. r=Waldo, r=jonco
1c66c26641eadba32e72da8ff00837d2d904700d: Bug 1317389: Change property attributes for generator and async functions to match ES2015/2017. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 17 Nov 2016 10:09:02 -0800 - rev 323286
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317389: Change property attributes for generator and async functions to match ES2015/2017. r=Waldo
7a79f153b1eb227b06b6b032f1db08da167967ff: Bug 1314920 - Update tzdata in ICU data files to 2016i. r=Waldo
André Bargull <andre.bargull@gmail.com> - Mon, 07 Nov 2016 10:10:21 -0800 - rev 323211
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1314920 - Update tzdata in ICU data files to 2016i. r=Waldo
9822e0525b82bcca19078eab6532c8972977a156: Bug 1300925 - Change Intl.cpp stubs to an anonymous namespace. r=Waldo
Vladimir Vukicevic <vladimir@pobox.com> - Tue, 15 Nov 2016 14:08:05 -0600 - rev 322787
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1300925 - Change Intl.cpp stubs to an anonymous namespace. r=Waldo MozReview-Commit-ID: 9Ed1gglWsby
fa5e948205052d195f08bff9ef5d750f15de4c9d: Bug 1316540 - Update version requirement for --with-system-icu to 58.1 for Unicode 9 support. r=waldo
Jonathan Kew <jkew@mozilla.com> - Tue, 15 Nov 2016 09:22:43 +0000 - rev 322740
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316540 - Update version requirement for --with-system-icu to 58.1 for Unicode 9 support. r=waldo
3e2bacaba5468e08c6548e757069c18ec885001e: Bug 1317430 - Avoid a unnecessary copy by passing a const & in js/ r=Waldo
Sylvestre Ledru <sledru@mozilla.com> - Mon, 14 Nov 2016 23:16:24 +0100 - rev 322692
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1317430 - Avoid a unnecessary copy by passing a const & in js/ r=Waldo MozReview-Commit-ID: EJ7B3697kZj
e12e761d2106b1c5ea836462177617e147176ee5: Bug 1316829 - DataViews are part of ArrayBufferView. - r=waldo
Jeff Gilbert (:jgilbert) <jgilbert@mozilla.com> - Fri, 11 Nov 2016 17:43:53 -0800 - rev 322514
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1316829 - DataViews are part of ArrayBufferView. - r=waldo MozReview-Commit-ID: L0Xauoo2nJh
478f38ea7eca5d6d05ef64854798768b99278815: Bug 1315352 - enable Range<T> -> Range<const T> conversion; r=Waldo
Nathan Froyd <froydnj@mozilla.com> - Mon, 07 Nov 2016 19:30:34 -0400 - rev 321464
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1315352 - enable Range<T> -> Range<const T> conversion; r=Waldo Since |T*| converts into |const T*|, if we want to rewrite code such as: void DoSomething(const T*, size_t); void DoSomethingElse(T* x, size_t len) { ... DoSomething(x, len); } to use ranges: void DoSomething(Range<const T>); void DoSomethingElse(Range<T> x) { ... DoSomething(x); } we need to ensure this conversion works. gsl::span<T> already provides something like this as well.
d22677d3a37f5fa0e6d019242bc3b6865b889556: Bug 1299615 - Part 8: Clobber for ICU 58. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 03 Nov 2016 14:07:55 -0700 - rev 321324
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 8: Clobber for ICU 58. r=Waldo
a3cc99e3ff2427b7e24c7e62aa7d9dc83e01b7e5: Bug 1299615 - Part 7: Adjust expected test result after update to ICU 58. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 27 Oct 2016 15:41:59 -0700 - rev 321323
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 7: Adjust expected test result after update to ICU 58. r=Waldo
9c8727f367c571c83ffea40170a41401792956e9: Bug 1299615 - Part 6: Update ICU stub implementations for ICU 58. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 27 Oct 2016 15:41:13 -0700 - rev 321322
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 6: Update ICU stub implementations for ICU 58. r=Waldo
541e579e59b3213eec4a8e41d7c3522eb5321a68: Bug 1299615 - Part 5: Update tzdata in ICU data files to 2016h. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 27 Oct 2016 15:39:49 -0700 - rev 321321
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 5: Update tzdata in ICU data files to 2016h. r=Waldo
6a7c7000b04791bddcf90f670ac8e33453809a77: Bug 1299615 - Part 4: Change license note for ICU to point to Unicode license. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 27 Oct 2016 15:37:35 -0700 - rev 321320
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 4: Change license note for ICU to point to Unicode license. r=Waldo
eb823a4a31f084a98d08ff5974eefddb0ffafc79: Bug 1299615 - Part 3: Update in-tree ICU to release 58.1. rs=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 03 Nov 2016 05:27:28 -0700 - rev 321319
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 3: Update in-tree ICU to release 58.1. rs=Waldo
8a609e18410d7a450f04d918b7472b141da6c948: Bug 1299615 - Part 2: Skip ICU source directory in Clang build plugin when searching for implicit conversion constructors. r=Waldo, r=mystor
André Bargull <andre.bargull@gmail.com> - Thu, 03 Nov 2016 05:45:39 -0700 - rev 321318
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 2: Skip ICU source directory in Clang build plugin when searching for implicit conversion constructors. r=Waldo, r=mystor
69147f2ddca85498c7de033fae81634a93a8b861: Bug 1299615 - Part 1: Update ICU patch files to apply cleanly on ICU58. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 03 Nov 2016 05:10:41 -0700 - rev 321317
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1299615 - Part 1: Update ICU patch files to apply cleanly on ICU58. r=Waldo
33b4d8c005c4e68c11a10a366719593c6b40819e: Bug 1314331 - Update IANA language subtag registry to version from 2016-10-12. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 03 Nov 2016 04:50:46 -0700 - rev 321303
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1314331 - Update IANA language subtag registry to version from 2016-10-12. r=Waldo
551718400ad4dedff15ce5aa85bb76bb75a19ed9: Bug 1073307: Add tests for timeZone support in Date.prototype.toLocaleString. r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 01 Nov 2016 08:54:19 -0700 - rev 320889
Push 21 by maklebus@msu.edu at Thu, 01 Dec 2016 06:22:08 +0000
Bug 1073307: Add tests for timeZone support in Date.prototype.toLocaleString. r=Waldo
c28c8e058e17cbdd428172894b53e2b81bec53b4: Bug 966559 - Use public C API for NumberingSystem. r=Waldo
Zibi Braniecki <gandalf@mozilla.com> - Tue, 01 Nov 2016 12:15:26 -0700 - rev 320471
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 966559 - Use public C API for NumberingSystem. r=Waldo MozReview-Commit-ID: CBICCJQXI7R
82a35fbc660a225aa5cfca83b84e564bb22bb813: Bug 1299107 - Share more shapes across compartments. r=Waldo
Jan de Mooij <jdemooij@mozilla.com> - Mon, 31 Oct 2016 15:01:20 +0100 - rev 320332
Push 15 by maklebus@msu.edu at Tue, 08 Nov 2016 18:38:37 +0000
Bug 1299107 - Share more shapes across compartments. r=Waldo
ee0568282adc0d6cddf74c3e635568145d5a987d: Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 06 Oct 2016 22:37:20 -0700 - rev 320065
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
f7823287275f2c2c4e2329b75057c12fc31cc806: Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 06 Oct 2016 22:37:20 -0700 - rev 319984
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
c1ef258c04f1960f6c014394f371fc0d3068ccb8: Bug 1312620 - Add IsPositiveZero function to mfbt and use it to replace MPhi by MNaNToZero iff c is +0.0. r=nbp, r=waldo
Johannes Schulte <j_schulte@outlook.com> - Wed, 26 Oct 2016 17:47:42 +0200 - rev 319912
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1312620 - Add IsPositiveZero function to mfbt and use it to replace MPhi by MNaNToZero iff c is +0.0. r=nbp, r=waldo
b490eb28b3bca76327dbe42d6ea65706f77d0cb8: Bug 1312061 - iUpdate tzdata in ICU data files to 2016h. r=Waldo
André Bargull <andre.bargull@gmail.com> - Fri, 21 Oct 2016 10:18:12 -0700 - rev 319375
Push 11 by maklebus@msu.edu at Mon, 31 Oct 2016 21:03:58 +0000
Bug 1312061 - iUpdate tzdata in ICU data files to 2016h. r=Waldo
2821a9fdfd258ef73a74608ec4056c186e68b170: Bug 1041341 - Part 1: Add support to store a pending destructuring error in PossibleError. r=arai, r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 18 Oct 2016 17:27:47 -0700 - rev 318559
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1041341 - Part 1: Add support to store a pending destructuring error in PossibleError. r=arai, r=Waldo
9b2529d5681611a8ced08e977d59638cf77c7382: Bug 1310733 - Part 1: Update tzdata in ICU data files to 2016g. r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 18 Oct 2016 11:45:57 -0700 - rev 318550
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1310733 - Part 1: Update tzdata in ICU data files to 2016g. r=Waldo
04d607a4816550a043fabb1934adfb5f7cfd754a: Bug 1310733 - Part 0: Rename tzdata svn directory to "source" instead of using version name. r=Waldo
André Bargull <andre.bargull@gmail.com> - Tue, 18 Oct 2016 11:46:21 -0700 - rev 318549
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1310733 - Part 0: Rename tzdata svn directory to "source" instead of using version name. r=Waldo
2a5bd50d8ff99a4d884d13aba39dad0e6f0980c9: Bug 866602 - Handle four-character language codes in CanonicalizeLanguageTag. r=Waldo
André Bargull <andre.bargull@gmail.com> - Mon, 19 Sep 2016 09:54:23 -0700 - rev 318393
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 866602 - Handle four-character language codes in CanonicalizeLanguageTag. r=Waldo
a15521c1e84ffabb1cbedb6a93e494eb13c99054: Bug 1277338 - Part 2: Fix SM(pkg) bustage; r=Waldo
Nick Fitzgerald <fitzgen@gmail.com> - Thu, 13 Oct 2016 17:37:56 -0700 - rev 317924
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1277338 - Part 2: Fix SM(pkg) bustage; r=Waldo
b2fbdba6f5c79dde85b8bb2d3f201449a13badba: Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 06 Oct 2016 22:37:20 -0700 - rev 317763
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 837961 - Part 2: Implement timeZone support for Intl.DateTimeFormat. r=Waldo
86e17a8b40d0daaa968613960860b62690d31790: Bug 1306701 - Part 1: Evaluate var-initializer expression in for-in loop per Annex B.3.6 (ES2017). r=Waldo
André Bargull <andre.bargull@gmail.com> - Mon, 10 Oct 2016 10:29:32 -0700 - rev 317514
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1306701 - Part 1: Evaluate var-initializer expression in for-in loop per Annex B.3.6 (ES2017). r=Waldo
d4c1417d3155cc3bc69ae984698470ea61af78b9: Bug 1306701 - Part 0.2: Remove no longer needed destructuring helper method from BytecodeEmitter. r=Waldo
André Bargull <andre.bargull@gmail.com> - Mon, 10 Oct 2016 10:29:17 -0700 - rev 317513
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1306701 - Part 0.2: Remove no longer needed destructuring helper method from BytecodeEmitter. r=Waldo
9d4004121f9c884ff6425cb746c32b3596b5bdae: Bug 1306701 - Part 0.1: Remove dead code in BytecodeEmitter::emitDeclarationList. r=Waldo, shu
André Bargull <andre.bargull@gmail.com> - Mon, 10 Oct 2016 10:29:04 -0700 - rev 317512
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1306701 - Part 0.1: Remove dead code in BytecodeEmitter::emitDeclarationList. r=Waldo, shu
95bf06da8e8d9b9163d7b376a630112ec2eab823: Bug 837961 - Part 1: Add scripts to update tzdata in ICU data files. r=Waldo
André Bargull <andre.bargull@gmail.com> - Thu, 06 Oct 2016 22:37:20 -0700 - rev 316963
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 837961 - Part 1: Add scripts to update tzdata in ICU data files. r=Waldo
b8af68ee1064cf26ace9ef913408828491cb23c2: Bug 1295379 - Avoid performance pitfalls in TypedArray built-ins. r=Waldo
André Bargull <andre.bargull@gmail.com> - Wed, 05 Oct 2016 03:21:57 -0700 - rev 316783
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1295379 - Avoid performance pitfalls in TypedArray built-ins. r=Waldo
a6506191e8948b9c8e4288df9b6ebbe73e82fba8: Bug 1130636 - Reimplement Array.prototype.toLocaleString as per ECMA-402, 2nd edition. r=Waldo
André Bargull <andre.bargull@gmail.com> - Wed, 05 Oct 2016 03:25:57 -0700 - rev 316781
Push 7 by maklebus@msu.edu at Wed, 19 Oct 2016 22:03:57 +0000
Bug 1130636 - Reimplement Array.prototype.toLocaleString as per ECMA-402, 2nd edition. r=Waldo
ab08affc3ca6d7d6ea6175f5f4560a5ff6ff1c1e: Bug 1298809 - Fix skipping lazy function expression bodies to account for semicolon. (r=Waldo)
Shu-yu Guo <shu@rfrn.org> - Mon, 03 Oct 2016 17:48:31 -0700 - rev 316333
Push 1 by maklebus@msu.edu at Wed, 05 Oct 2016 23:10:55 +0000
Bug 1298809 - Fix skipping lazy function expression bodies to account for semicolon. (r=Waldo)
87b7e5eac522bf5e87bcce12d5bcf50665d23442: Bug 1287298 - Add an API to give up ownership of ArrayBuffer data; r=Waldo
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 16 Jul 2016 17:52:39 -0400 - rev 316096
Bug 1287298 - Add an API to give up ownership of ArrayBuffer data; r=Waldo This is similar to stealing the buffer, except that the ArrayBuffer won't be detached. The caller is still responsible for freeing the buffer.