Bug 973805 part 2: Adds MOZ_OVERRIDE in layout/ forms/nsImageControlFrame.cpp, generic/nsImageFrame.h, generic/nsObjectFrame.h r=dholbert
--- a/layout/forms/nsImageControlFrame.cpp
+++ b/layout/forms/nsImageControlFrame.cpp
@@ -25,50 +25,51 @@ IntPointDtorFunc(void *aObject, nsIAtom
typedef nsImageFrame nsImageControlFrameSuper;
class nsImageControlFrame : public nsImageControlFrameSuper,
public nsIFormControlFrame
{
public:
nsImageControlFrame(nsStyleContext* aContext);
~nsImageControlFrame();
- virtual void DestroyFrom(nsIFrame* aDestructRoot);
+ virtual void DestroyFrom(nsIFrame* aDestructRoot) MOZ_OVERRIDE;
virtual void Init(nsIContent* aContent,
nsIFrame* aParent,
nsIFrame* aPrevInFlow) MOZ_OVERRIDE;
NS_DECL_QUERYFRAME
NS_DECL_FRAMEARENA_HELPERS
virtual nsresult Reflow(nsPresContext* aPresContext,
nsHTMLReflowMetrics& aDesiredSize,
const nsHTMLReflowState& aReflowState,
- nsReflowStatus& aStatus);
+ nsReflowStatus& aStatus) MOZ_OVERRIDE;
virtual nsresult HandleEvent(nsPresContext* aPresContext,
WidgetGUIEvent* aEvent,
- nsEventStatus* aEventStatus);
+ nsEventStatus* aEventStatus) MOZ_OVERRIDE;
- virtual nsIAtom* GetType() const;
+ virtual nsIAtom* GetType() const MOZ_OVERRIDE;
#ifdef ACCESSIBILITY
virtual mozilla::a11y::AccType AccessibleType() MOZ_OVERRIDE;
#endif
#ifdef DEBUG_FRAME_DUMP
- virtual nsresult GetFrameName(nsAString& aResult) const {
+ virtual nsresult GetFrameName(nsAString& aResult) const MOZ_OVERRIDE {
return MakeFrameName(NS_LITERAL_STRING("ImageControl"), aResult);
}
#endif
virtual nsresult GetCursor(const nsPoint& aPoint,
- nsIFrame::Cursor& aCursor);
+ nsIFrame::Cursor& aCursor) MOZ_OVERRIDE;
// nsIFormContromFrame
- virtual void SetFocus(bool aOn, bool aRepaint);
- virtual nsresult SetFormProperty(nsIAtom* aName, const nsAString& aValue);
+ virtual void SetFocus(bool aOn, bool aRepaint) MOZ_OVERRIDE;
+ virtual nsresult SetFormProperty(nsIAtom* aName,
+ const nsAString& aValue) MOZ_OVERRIDE;
};
nsImageControlFrame::nsImageControlFrame(nsStyleContext* aContext):
nsImageControlFrameSuper(aContext)
{
}
--- a/layout/generic/nsImageFrame.h
+++ b/layout/generic/nsImageFrame.h
@@ -65,57 +65,58 @@ public:
NS_DECL_FRAMEARENA_HELPERS
nsImageFrame(nsStyleContext* aContext);
NS_DECL_QUERYFRAME_TARGET(nsImageFrame)
NS_DECL_QUERYFRAME
- virtual void DestroyFrom(nsIFrame* aDestructRoot);
+ virtual void DestroyFrom(nsIFrame* aDestructRoot) MOZ_OVERRIDE;
virtual void Init(nsIContent* aContent,
nsIFrame* aParent,
nsIFrame* aPrevInFlow) MOZ_OVERRIDE;
virtual void BuildDisplayList(nsDisplayListBuilder* aBuilder,
const nsRect& aDirtyRect,
const nsDisplayListSet& aLists) MOZ_OVERRIDE;
- virtual nscoord GetMinWidth(nsRenderingContext *aRenderingContext);
- virtual nscoord GetPrefWidth(nsRenderingContext *aRenderingContext);
- virtual mozilla::IntrinsicSize GetIntrinsicSize();
- virtual nsSize GetIntrinsicRatio();
+ virtual nscoord GetMinWidth(nsRenderingContext *aRenderingContext) MOZ_OVERRIDE;
+ virtual nscoord GetPrefWidth(nsRenderingContext *aRenderingContext) MOZ_OVERRIDE;
+ virtual mozilla::IntrinsicSize GetIntrinsicSize() MOZ_OVERRIDE;
+ virtual nsSize GetIntrinsicRatio() MOZ_OVERRIDE;
virtual nsresult Reflow(nsPresContext* aPresContext,
nsHTMLReflowMetrics& aDesiredSize,
const nsHTMLReflowState& aReflowState,
- nsReflowStatus& aStatus);
+ nsReflowStatus& aStatus) MOZ_OVERRIDE;
virtual nsresult GetContentForEvent(mozilla::WidgetEvent* aEvent,
- nsIContent** aContent);
+ nsIContent** aContent) MOZ_OVERRIDE;
virtual nsresult HandleEvent(nsPresContext* aPresContext,
mozilla::WidgetGUIEvent* aEvent,
- nsEventStatus* aEventStatus);
+ nsEventStatus* aEventStatus) MOZ_OVERRIDE;
virtual nsresult GetCursor(const nsPoint& aPoint,
- nsIFrame::Cursor& aCursor);
+ nsIFrame::Cursor& aCursor) MOZ_OVERRIDE;
virtual nsresult AttributeChanged(int32_t aNameSpaceID,
nsIAtom* aAttribute,
- int32_t aModType);
+ int32_t aModType) MOZ_OVERRIDE;
#ifdef ACCESSIBILITY
virtual mozilla::a11y::AccType AccessibleType() MOZ_OVERRIDE;
#endif
- virtual nsIAtom* GetType() const;
+ virtual nsIAtom* GetType() const MOZ_OVERRIDE;
- virtual bool IsFrameOfType(uint32_t aFlags) const
+ virtual bool IsFrameOfType(uint32_t aFlags) const MOZ_OVERRIDE
{
return ImageFrameSuper::IsFrameOfType(aFlags & ~(nsIFrame::eReplaced));
}
#ifdef DEBUG_FRAME_DUMP
- virtual nsresult GetFrameName(nsAString& aResult) const;
- void List(FILE* out = stderr, const char* aPrefix = "", uint32_t aFlags = 0) const;
+ virtual nsresult GetFrameName(nsAString& aResult) const MOZ_OVERRIDE;
+ void List(FILE* out = stderr, const char* aPrefix = "",
+ uint32_t aFlags = 0) const MOZ_OVERRIDE;
#endif
virtual int GetSkipSides(const nsHTMLReflowState* aReflowState = nullptr) const MOZ_OVERRIDE;
nsresult GetIntrinsicImageSize(nsSize& aSize);
static void ReleaseGlobals() {
if (gIconLoad) {
@@ -158,17 +159,17 @@ public:
* Return true if the image has associated image map.
*/
bool HasImageMap() const { return mImageMap || GetMapElement(); }
nsImageMap* GetImageMap();
nsImageMap* GetExistingImageMap() const { return mImageMap; }
virtual void AddInlineMinWidth(nsRenderingContext *aRenderingContext,
- InlineMinWidthData *aData);
+ InlineMinWidthData *aData) MOZ_OVERRIDE;
void DisconnectMap();
// nsIReflowCallback
virtual bool ReflowFinished() MOZ_OVERRIDE;
virtual void ReflowCallbackCanceled() MOZ_OVERRIDE;
protected:
--- a/layout/generic/nsObjectFrame.h
+++ b/layout/generic/nsObjectFrame.h
@@ -51,55 +51,56 @@ public:
friend nsIFrame* NS_NewObjectFrame(nsIPresShell* aPresShell, nsStyleContext* aContext);
NS_DECL_QUERYFRAME
NS_DECL_QUERYFRAME_TARGET(nsObjectFrame)
virtual void Init(nsIContent* aContent,
nsIFrame* aParent,
nsIFrame* aPrevInFlow) MOZ_OVERRIDE;
- virtual nscoord GetMinWidth(nsRenderingContext *aRenderingContext);
- virtual nscoord GetPrefWidth(nsRenderingContext *aRenderingContext);
+ virtual nscoord GetMinWidth(nsRenderingContext *aRenderingContext) MOZ_OVERRIDE;
+ virtual nscoord GetPrefWidth(nsRenderingContext *aRenderingContext) MOZ_OVERRIDE;
virtual nsresult Reflow(nsPresContext* aPresContext,
nsHTMLReflowMetrics& aDesiredSize,
const nsHTMLReflowState& aReflowState,
- nsReflowStatus& aStatus);
+ nsReflowStatus& aStatus) MOZ_OVERRIDE;
virtual nsresult DidReflow(nsPresContext* aPresContext,
const nsHTMLReflowState* aReflowState,
- nsDidReflowStatus aStatus);
+ nsDidReflowStatus aStatus) MOZ_OVERRIDE;
virtual void BuildDisplayList(nsDisplayListBuilder* aBuilder,
const nsRect& aDirtyRect,
const nsDisplayListSet& aLists) MOZ_OVERRIDE;
virtual nsresult HandleEvent(nsPresContext* aPresContext,
mozilla::WidgetGUIEvent* aEvent,
- nsEventStatus* aEventStatus);
+ nsEventStatus* aEventStatus) MOZ_OVERRIDE;
- virtual nsIAtom* GetType() const;
+ virtual nsIAtom* GetType() const MOZ_OVERRIDE;
- virtual bool IsFrameOfType(uint32_t aFlags) const
+ virtual bool IsFrameOfType(uint32_t aFlags) const MOZ_OVERRIDE
{
return nsObjectFrameSuper::IsFrameOfType(aFlags & ~(nsIFrame::eReplaced));
}
- virtual bool NeedsView() { return true; }
+ virtual bool NeedsView() MOZ_OVERRIDE { return true; }
#ifdef DEBUG_FRAME_DUMP
- virtual nsresult GetFrameName(nsAString& aResult) const;
+ virtual nsresult GetFrameName(nsAString& aResult) const MOZ_OVERRIDE;
#endif
- virtual void DestroyFrom(nsIFrame* aDestructRoot);
+ virtual void DestroyFrom(nsIFrame* aDestructRoot) MOZ_OVERRIDE;
- virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext);
+ virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext) MOZ_OVERRIDE;
NS_METHOD GetPluginInstance(nsNPAPIPluginInstance** aPluginInstance) MOZ_OVERRIDE;
virtual void SetIsDocumentActive(bool aIsActive) MOZ_OVERRIDE;
- virtual nsresult GetCursor(const nsPoint& aPoint, nsIFrame::Cursor& aCursor);
+ virtual nsresult GetCursor(const nsPoint& aPoint,
+ nsIFrame::Cursor& aCursor) MOZ_OVERRIDE;
// APIs used by nsRootPresContext to set up the widget position/size/clip
// region.
/**
* Set the next widget configuration for the plugin to the desired
* position of the plugin's widget, on the assumption that it is not visible
* (clipped out or covered by opaque content).
* This will only be called for plugins which have been registered
@@ -208,17 +209,18 @@ protected:
virtual ~nsObjectFrame();
// NOTE: This frame class does not inherit from |nsLeafFrame|, so
// this is not a virtual method implementation.
void GetDesiredSize(nsPresContext* aPresContext,
const nsHTMLReflowState& aReflowState,
nsHTMLReflowMetrics& aDesiredSize);
- bool IsFocusable(int32_t *aTabIndex = nullptr, bool aWithMouse = false);
+ bool IsFocusable(int32_t *aTabIndex = nullptr,
+ bool aWithMouse = false) MOZ_OVERRIDE;
// check attributes and optionally CSS to see if we should display anything
bool IsHidden(bool aCheckVisibilityStyle = true) const;
bool IsOpaque() const;
bool IsTransparentMode() const;
bool IsPaintedByGecko() const;