Bug 1001587 - nsGenericDOMDataNode's Traverse method doesn't need to call nsBindingManager::Traverse. r=smaug
authorAndrew McCreight <continuation@gmail.com>
Mon, 28 Apr 2014 06:15:08 -0700
changeset 180938 a249af412db860e49a25fd0c4e98939c69a4b0f9
parent 180937 9bb8fb4f73f83165ab76a3008b9c8419c18973cd
child 180939 c259840960975b62b1f74cd58b3327b876ef5aef
push id272
push userpvanderbeken@mozilla.com
push dateMon, 05 May 2014 16:31:18 +0000
reviewerssmaug
bugs1001587, 796061
milestone31.0a1
Bug 1001587 - nsGenericDOMDataNode's Traverse method doesn't need to call nsBindingManager::Traverse. r=smaug The stuff from nsBindingManager::Traverse that is used for data nodes was removed in bug 796061, so it now just returns immediately for non-elements, so we don't need to call it any more in data nodes.
content/base/src/nsGenericDOMDataNode.cpp
--- a/content/base/src/nsGenericDOMDataNode.cpp
+++ b/content/base/src/nsGenericDOMDataNode.cpp
@@ -97,18 +97,16 @@ NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(
   if (!nsINode::Traverse(tmp, cb)) {
     return NS_SUCCESS_INTERRUPTED_TRAVERSE;
   }
 
   nsDataSlots *slots = tmp->GetExistingDataSlots();
   if (slots) {
     slots->Traverse(cb);
   }
-
-  tmp->OwnerDoc()->BindingManager()->Traverse(tmp, cb);
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
 
 NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsGenericDOMDataNode)
   nsINode::Unlink(tmp);
 
   nsDataSlots *slots = tmp->GetExistingDataSlots();
   if (slots) {
     slots->Unlink();