Bug 995528 - Certificate viewer describes not-valid-before date as issue date. r=honzab, ui-r=philipp
authorYFdyh000 <yfdyh000@gmail.com>
Mon, 21 Apr 2014 10:58:04 -0400
changeset 179804 994095bfc2e8ef759ef6ae63e82f216ea02f3a44
parent 179803 d75969295963ccb61d4272ed9a309fd967f7de99
child 179805 d525f195556dedaaa0572e84995047def5461cbf
push id272
push userpvanderbeken@mozilla.com
push dateMon, 05 May 2014 16:31:18 +0000
reviewershonzab, philipp
bugs995528
milestone31.0a1
Bug 995528 - Certificate viewer describes not-valid-before date as issue date. r=honzab, ui-r=philipp
mobile/android/components/NSSDialogService.js
mobile/android/locales/en-US/chrome/pippki.properties
security/manager/locales/en-US/chrome/pippki/certManager.dtd
security/manager/pki/resources/content/MineOverlay.xul
security/manager/pki/resources/content/viewCertDetails.xul
--- a/mobile/android/components/NSSDialogService.js
+++ b/mobile/android/components/NSSDialogService.js
@@ -132,18 +132,18 @@ NSSDialogs.prototype = {
                           ["certmgr.certdetail.cn", aCert.commonName,
                            "certmgr.certdetail.o", aCert.organization,
                            "certmgr.certdetail.ou", aCert.organizationalUnit,
                            "certmgr.certdetail.serialnumber", aCert.serialNumber])})
      .addLabel({ label: this.certInfoSection("certmgr.issuerinfo.label",
                           ["certmgr.certdetail.cn", aCert.issuerCommonName,
                            "certmgr.certdetail.o", aCert.issuerOrganization,
                            "certmgr.certdetail.ou", aCert.issuerOrganizationUnit])})
-     .addLabel({ label: this.certInfoSection("certmgr.validity.label",
-                          ["certmgr.issued", aCert.validity.notBeforeLocalDay,
+     .addLabel({ label: this.certInfoSection("certmgr.periodofvalidity.label",
+                          ["certmgr.begins", aCert.validity.notBeforeLocalDay,
                            "certmgr.expires", aCert.validity.notAfterLocalDay])})
      .addLabel({ label: this.certInfoSection("certmgr.fingerprints.label",
                           ["certmgr.certdetail.sha1fingerprint", aCert.sha1Fingerprint,
                            "certmgr.certdetail.md5fingerprint", aCert.md5Fingerprint], false) });
     this.showPrompt(p);
   },
 
   viewCertDetails: function(details) {
--- a/mobile/android/locales/en-US/chrome/pippki.properties
+++ b/mobile/android/locales/en-US/chrome/pippki.properties
@@ -24,18 +24,18 @@ clientAuthAsk.remember.label=Remember th
 clientAuthAsk.organization=Organization: "%S"
 clientAuthAsk.issuer=Issued Under: "%S"
 clientAuthAsk.viewCert.label=View
 
 certmgr.title=Certificate Details
 # These strings are stolen from security/manager/locales/en-US/chrome/pippki/certManager.dtd
 certmgr.subjectinfo.label=Issued To
 certmgr.issuerinfo.label=Issued By
-certmgr.validity.label=Validity
+certmgr.periodofvalidity.label=Period of Validity
 certmgr.fingerprints.label=Fingerprints
 certmgr.certdetail.cn=Common Name (CN)
 certmgr.certdetail.o=Organization (O)
 certmgr.certdetail.ou=Organizational Unit (OU)
 certmgr.certdetail.serialnumber=Serial Number
 certmgr.certdetail.sha1fingerprint=SHA1 Fingerprint
 certmgr.certdetail.md5fingerprint=MD5 Fingerprint
-certmgr.issued=Issued On
+certmgr.begins=Begins On
 certmgr.expires=Expires On
--- a/security/manager/locales/en-US/chrome/pippki/certManager.dtd
+++ b/security/manager/locales/en-US/chrome/pippki/certManager.dtd
@@ -22,17 +22,17 @@
 <!ENTITY certmgr.detail.general_tab.title     "General">
 <!ENTITY certmgr.detail.general_tab.accesskey "G">
 <!ENTITY certmgr.detail.prettyprint_tab.title "Details">
 <!ENTITY certmgr.detail.prettyprint_tab.accesskey "D">
 
 <!ENTITY certmgr.pending.label                "Currently verifying certificate…">
 <!ENTITY certmgr.subjectinfo.label            "Issued To">
 <!ENTITY certmgr.issuerinfo.label             "Issued By">
-<!ENTITY certmgr.validity.label               "Validity" >
+<!ENTITY certmgr.periodofvalidity.label       "Period of Validity" >
 <!ENTITY certmgr.fingerprints.label           "Fingerprints">
 <!ENTITY certmgr.certdetail.title             "Certificate Detail">
 <!ENTITY certmgr.certdetail.cn                "Common Name (CN)">
 <!ENTITY certmgr.certdetail.o                 "Organization (O)">
 <!ENTITY certmgr.certdetail.ou                "Organizational Unit (OU)">
 <!ENTITY certmgr.certdetail.serialnumber      "Serial Number">
 <!ENTITY certmgr.certdetail.sha1fingerprint   "SHA1 Fingerprint">
 <!ENTITY certmgr.certdetail.md5fingerprint    "MD5 Fingerprint">
@@ -54,17 +54,17 @@
 <!ENTITY certmgr.deleteusercert.title         "Delete Your Certificate">
 <!ENTITY certmgr.deleteusercert.beforename    "You have requested to delete the certificate:">
 <!ENTITY certmgr.deleteusercert.aftername     "Once you have deleted this certificate, you will not be able to read mail that has been encrypted with it.">
 
 <!ENTITY certmgr.certname                     "Certificate Name">
 <!ENTITY certmgr.certserver                   "Server">
 <!ENTITY certmgr.override_lifetime            "Lifetime">
 <!ENTITY certmgr.tokenname                    "Security Device">
-<!ENTITY certmgr.issued                       "Issued On">
+<!ENTITY certmgr.begins                       "Begins On">
 <!ENTITY certmgr.expires                      "Expires On">
 <!ENTITY certmgr.email                        "E-Mail Address">
 <!ENTITY certmgr.serial                       "Serial Number">
 
 <!ENTITY certmgr.close.label                  "Close">
 <!ENTITY certmgr.close.accesskey              "C">
 <!ENTITY certmgr.view2.label                  "View…">
 <!ENTITY certmgr.view2.accesskey              "V">
--- a/security/manager/pki/resources/content/MineOverlay.xul
+++ b/security/manager/pki/resources/content/MineOverlay.xul
@@ -22,17 +22,17 @@
                      persist="hidden width ordinal" flex="1"/>
         <splitter class="tree-splitter"/>
         <treecol id="tokencol" label="&certmgr.tokenname;"
                      persist="hidden width ordinal" flex="1"/>
         <splitter class="tree-splitter"/>
         <treecol id="serialnumcol" label="&certmgr.serial;"
                      persist="hidden width ordinal" flex="1"/>
         <splitter class="tree-splitter"/>
-        <treecol id="issuedcol" label="&certmgr.issued;"
+        <treecol id="issuedcol" label="&certmgr.begins;"
                      hidden="true" persist="hidden width ordinal" flex="1"/>
         <splitter class="tree-splitter"/>
         <treecol id="expiredcol" label="&certmgr.expires;"
                      persist="hidden width ordinal" flex="1"/>
       </treecols>
       <treechildren ondblclick="viewCerts();"/>
     </tree>
     
--- a/security/manager/pki/resources/content/viewCertDetails.xul
+++ b/security/manager/pki/resources/content/viewCertDetails.xul
@@ -62,21 +62,21 @@
           <label value="&certmgr.certdetail.ou;"/>
           <textbox id="issuerorgunit" class="plain" readonly="true"/>
         </row>
         <row>
           <separator class="thin"/>
           <spacer/>
         </row>
         <row>
-          <label class ="header" value="&certmgr.validity.label;"/>
+          <label class ="header" value="&certmgr.periodofvalidity.label;"/>
           <spacer/>
         </row>
         <row>
-          <label value="&certmgr.issued;"/>
+          <label value="&certmgr.begins;"/>
           <textbox id="validitystart" class="plain" readonly="true"/>
         </row>
         <row>
           <label value="&certmgr.expires;"/>
           <textbox id="validityend" class="plain" readonly="true"/>
         </row>
         <row>
           <separator class="thin"/>