Bug 1001628 - listbox option role string is now less verbose. r=eeejay
authorYura Zenevich <yzenevich@mozilla.com>
Wed, 30 Apr 2014 11:27:13 -0400
changeset 181431 80a886fea17dca5a54aa97d410badd8bbb8a43c7
parent 181430 61f1739efa5df068863acf386139e706f33a23d3
child 181432 2cecc0699b45986f5e3e48405b04092485d1f76c
push id272
push userpvanderbeken@mozilla.com
push dateMon, 05 May 2014 16:31:18 +0000
reviewerseeejay
bugs1001628
milestone32.0a1
Bug 1001628 - listbox option role string is now less verbose. r=eeejay --- accessible/tests/mochitest/jsat/test_output.html | 12 ++++++++++-- dom/locales/en-US/chrome/accessibility/AccessFu.properties | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-)
accessible/tests/mochitest/jsat/test_output.html
dom/locales/en-US/chrome/accessibility/AccessFu.properties
--- a/accessible/tests/mochitest/jsat/test_output.html
+++ b/accessible/tests/mochitest/jsat/test_output.html
@@ -334,18 +334,23 @@ https://bugzilla.mozilla.org/show_bug.cg
           expectedBraille: [["( )", "I ain't pressed"],
                             ["I ain't pressed", "( )"]]
         },{
           accOrElmOrID: "togglebutton_pressed",
           expectedUtterance: [["pressed toggle button", "I am pressed!"],
                               ["I am pressed!", "pressed toggle button"]],
           expectedBraille: [["(x)", "I am pressed!"],
                             ["I am pressed!", "(x)"]]
-        }
-        ];
+        }, {
+          accOrElmOrID: "listbox-option",
+          expectedUtterance: [["list box", "option", "Search suggestion"],
+            ["Search suggestion", "option", "list box"]],
+          expectedBraille: [["option", "Search suggestion"],
+            ["Search suggestion", "option"]]
+        }];
 
         // Test all possible utterance order preference values.
         tests.forEach(function run(test) {
           var utteranceOrderValues = [0, 1];
           utteranceOrderValues.forEach(
             function testUtteranceOrder(utteranceOrder) {
               SpecialPowers.setIntPref(PREF_UTTERANCE_ORDER, utteranceOrder);
               testOutput(test.expectedUtterance[utteranceOrder],
@@ -449,11 +454,14 @@ https://bugzilla.mozilla.org/show_bug.cg
       <input id="email" type="email" value="test@example.com" />
       <input id="search" type="search" value="This is a search" />
       <input id="tel" type="tel" value="555-5555" />
       <input id="url" type="url" value="http://example.com" />
       <input id="textInput" type="text" value="This is text." />
       <label>Points: <input id="range" type="range" name="points" min="1" max="10" value="3"></label>
       <div id="togglebutton_notpressed" aria-pressed="false" role="button" tabindex="-1">I ain't pressed</div>
       <div id="togglebutton_pressed" aria-pressed="true" role="button" tabindex="-1">I am pressed!</div>
+      <ul role="listbox" style="list-style-type: none;">
+        <li role="option" id="listbox-option">Search suggestion</li>
+      </ul>
     </div>
   </body>
 </html>
--- a/dom/locales/en-US/chrome/accessibility/AccessFu.properties
+++ b/dom/locales/en-US/chrome/accessibility/AccessFu.properties
@@ -59,17 +59,17 @@ paragraph      =       paragraph
 entry          =       entry
 caption        =       caption
 heading        =       heading
 section        =       section
 form           =       form
 comboboxlist   =       combo box list
 comboboxoption =       combo box option
 imagemap       =       image map
-listboxoption  =       list box option
+listboxoption  =       option
 listbox        =       list box
 flatequation   =       flat equation
 gridcell       =       gridcell
 note           =       note
 figure         =       figure
 definitionlist =       definition list
 term           =       term
 definition     =       definition