Bug 978603: Make sure implicit copy constructors and assignment operators aren't invoked for gfxGlyphExtents (which would at least mess up leak statistics if not actually leak). r=jfkthame
authorL. David Baron <dbaron@dbaron.org>
Mon, 03 Mar 2014 00:54:39 -0800
changeset 171767 31b472f3e282a08ca53db8eaf137c4924cd1dc69
parent 171766 8a72d26209182966111fcc0a6a721c65ac3160ec
child 171768 ba9b13653eee2d4f1e3da156420eca6643088628
push id270
push userpvanderbeken@mozilla.com
push dateThu, 06 Mar 2014 09:24:21 +0000
reviewersjfkthame
bugs978603, 435138
milestone30.0a1
Bug 978603: Make sure implicit copy constructors and assignment operators aren't invoked for gfxGlyphExtents (which would at least mess up leak statistics if not actually leak). r=jfkthame Originally written while investigating bug 435138.
gfx/thebes/gfxFont.h
--- a/gfx/thebes/gfxFont.h
+++ b/gfx/thebes/gfxFont.h
@@ -1298,16 +1298,21 @@ private:
         }
 
         nsTArray<uintptr_t> mBlocks;
     };
 
     GlyphWidths             mContainedGlyphWidths;
     nsTHashtable<HashEntry> mTightGlyphExtents;
     int32_t                 mAppUnitsPerDevUnit;
+
+private:
+    // not implemented:
+    gfxGlyphExtents(const gfxGlyphExtents& aOther) MOZ_DELETE;
+    gfxGlyphExtents& operator=(const gfxGlyphExtents& aOther) MOZ_DELETE;
 };
 
 /**
  * gfxFontShaper
  *
  * This class implements text shaping (character to glyph mapping and
  * glyph layout). There is a gfxFontShaper subclass for each text layout
  * technology (uniscribe, core text, harfbuzz,....) we support.