searching for reviewer(dbaron)
d911a4befffe4d200b26ab71a361b55a00e1f410: Bug 1001237 - Add crashtest. r=dbaron
Kearwood (Kip) Gilbert <kgilbert@mozilla.com> - Mon, 28 Apr 2014 12:11:00 -0400 - rev 181279
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 1001237 - Add crashtest. r=dbaron
94b14c87a75ef99c59429ed991e7db820f66b0e5: Bug 1001237 - Don't return nsChangeHint_UpdatePostTransformOverflow in nsStyleDisplay::CalcDifference when a transform is added. r=dbaron
Kearwood (Kip) Gilbert <kgilbert@mozilla.com> - Mon, 28 Apr 2014 14:51:00 -0400 - rev 181278
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 1001237 - Don't return nsChangeHint_UpdatePostTransformOverflow in nsStyleDisplay::CalcDifference when a transform is added. r=dbaron
a344959a575677d2c6a92d57d2787489bffe74bb: Bug 998206. Add --shuffle option to runreftests.py and 'mach reftest'. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Mon, 03 Mar 2014 18:13:01 +1300 - rev 180323
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 998206. Add --shuffle option to runreftests.py and 'mach reftest'. r=dbaron
bfd16de7bf251bb0184a3f4baf6c76552abc8dc1: Bug 979345 - Implement "touch-action: manipulation" CSS value for Pointer Events. r=kats,botond,dbaron,mbrubeck
Maksim Lebedev <alessarik@gmail.com> - Wed, 23 Apr 2014 09:56:46 -0400 - rev 180153
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 979345 - Implement "touch-action: manipulation" CSS value for Pointer Events. r=kats,botond,dbaron,mbrubeck
20eb244eae3b9ac3fe504ca6e4fe4bf5b02c676c: Bug 920688 - Remove FIXME comment from StickyScrollContainer::ComputeStickyLimits. r=dbaron
Kearwood (Kip) Gilbert <kgilbert@mozilla.com> - Tue, 22 Apr 2014 15:30:00 +0200 - rev 180095
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 920688 - Remove FIXME comment from StickyScrollContainer::ComputeStickyLimits. r=dbaron - The condition described in the FIXME comment is already handled by GetNearestBlockContainer in nsFrame.cpp (helper for nsIFrame::GetContainingBlock).
039b15c9b84e10c738f47c81ff03deb4fabd0a66: Bug 979345 - Implement "touch-action: manipulation" CSS value for Pointer Events. r=kats, r=botond, r=dbaron, r=mbrubeck
Maksim Lebedev <alessarik@gmail.com> - Tue, 22 Apr 2014 14:27:02 -0700 - rev 180063
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 979345 - Implement "touch-action: manipulation" CSS value for Pointer Events. r=kats, r=botond, r=dbaron, r=mbrubeck
b9b4ff616b32af49791c397ed2585c18fba294be: Bug 998995 - Reserve stack space for 16 arguments when parsing a CSS function; r=dbaron
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 21 Apr 2014 20:44:33 -0400 - rev 179889
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 998995 - Reserve stack space for 16 arguments when parsing a CSS function; r=dbaron
167291c2fd24fbcc6aff72fffcfb1c87f3cf7f2e: Bug 992878 - Increase number of expected assertions in test_bug437844.xul DONTBUILD, r=dbaron
Honza Bambas <honzab.moz@firemni.cz> - Mon, 07 Apr 2014 18:00:56 +0200 - rev 179650
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 992878 - Increase number of expected assertions in test_bug437844.xul DONTBUILD, r=dbaron
d849022d86338bdab3790f0dd57e57766bfeabfb: Bug 991134 - Output an additional failure line for loadfailed: null failures to make bug 789751 and bug 720452 TBPL starable; r=dbaron
Ed Morley <emorley@mozilla.com> - Thu, 17 Apr 2014 01:13:38 +0100 - rev 179261
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 991134 - Output an additional failure line for loadfailed: null failures to make bug 789751 and bug 720452 TBPL starable; r=dbaron
0d8ac5b08dd5b4508a596fae8fcbad4cfdb14ea6: Bug 984226 - Add parameter to OverflowChangedTracker::AddFrame to distingush between frames that need nsIFrame::UpdateOverflow called and frames that only have a transform that has changed. r=dbaron
Kearwood (Kip) Gilbert <kgilbert@mozilla.com> - Thu, 13 Mar 2014 17:21:25 -0700 - rev 179236
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 984226 - Add parameter to OverflowChangedTracker::AddFrame to distingush between frames that need nsIFrame::UpdateOverflow called and frames that only have a transform that has changed. r=dbaron - OverflowChangedTracker::AddFrame now accepts an enumerated type parameter to indicate if the overflow areas of children have changed (CHILDREN_CHANGED), the overflow areas of the children have changed and the parent have changed (CHILDREN_AND_PARENT_CHANGED), or if only the transform has changed (TRANSFORM_CHANGED). - OverflowChangedTracker::Flush no longer falls back to calling nsIFrame::UpdateOverflow when a frame lacks a PreTransformOverflowAreas property. - Added an additional change hint, nsChangeHint_ChildrenOnlyTransform, which results in TRANSFORM_CHANGED being passed in to OverflowChangedTracker::AddFrame. - In nsIFrame::FinishAndStoreOverflow, the passed in overflow is now stored as the InitialTransformProperty for elements that are IsTransformed(). - Partially corrected Bug 926155, by only calling OverflowChangedTracker::AddFrame on parents of the sticky element during StickyScrollContainer::UpdatePositions, using CHILDREN_CHANGED.
c6becd0b9a5b129159532b764bd79e761e66102b: Bug 985303. Part 3: Save a block's 'bottom edge of content' in a frame property if it doesn't match the block's content height, and use it in UpdateOverflow to compute the correct overflow. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Thu, 03 Apr 2014 04:27:23 -0400 - rev 178867
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 985303. Part 3: Save a block's 'bottom edge of content' in a frame property if it doesn't match the block's content height, and use it in UpdateOverflow to compute the correct overflow. r=dbaron
82f376050e58af01283cdaa4f7b8c1fabb074856: Bug 985303. Part 2: Add aSkipChildLists parameter to nsLayoutUtils::UnionChildOverflow. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Thu, 03 Apr 2014 04:25:03 -0400 - rev 178866
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 985303. Part 2: Add aSkipChildLists parameter to nsLayoutUtils::UnionChildOverflow. r=dbaron
7c7f680de70eafe0cf33680549dae83855af086e: Bug 985303. Part 1: Assert that nsViews are only associated with a specific, limited set of frame types. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Thu, 03 Apr 2014 04:24:58 -0400 - rev 178865
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 985303. Part 1: Assert that nsViews are only associated with a specific, limited set of frame types. r=dbaron
95c89ca2ed6f74da0e897952c27b1ff875599494: Bug 791480. Reenable test on Windows 7. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Tue, 25 Mar 2014 22:15:49 +1300 - rev 178862
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 791480. Reenable test on Windows 7. r=dbaron
a53ff44f6546098033fb8963304afc3b5a9903af: Bug 791480. Make reftests enter print mode before reftest-wait is removed, so canvas-print-callback tests can finish drawing before the test ends. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Tue, 25 Mar 2014 22:11:27 +1300 - rev 178861
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 791480. Make reftests enter print mode before reftest-wait is removed, so canvas-print-callback tests can finish drawing before the test ends. r=dbaron
37d65c484ce6bce791d1863b883ff37f47237506: Bug 992333 - Skip custom properties when looking for properties to transition. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Sun, 13 Apr 2014 11:44:31 +1000 - rev 178593
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 992333 - Skip custom properties when looking for properties to transition. r=dbaron
7be71c699b850c07378b0798542131f84b26d308: Bug 984226 - Add parameter to OverflowChangedTracker::AddFrame to distingush between frames that need nsIFrame::UpdateOverflow called and frames that only have a transform that has changed. r=dbaron
Kearwood (Kip) Gilbert <kgilbert@mozilla.com> - Thu, 13 Mar 2014 17:21:25 -0700 - rev 177965
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 984226 - Add parameter to OverflowChangedTracker::AddFrame to distingush between frames that need nsIFrame::UpdateOverflow called and frames that only have a transform that has changed. r=dbaron - OverflowChangedTracker::AddFrame now accepts an enumerated type parameter to indicate if the overflow areas of children have changed (CHILDREN_CHANGED) or if the transform has changed (TRANSFORM_CHANGED). - OverflowChangedTracker::Flush no longer falls back to calling nsIFrame::UpdateOverflow when a frame lacks a PreTransformOverflowAreas property. - Added an additional change hint, nsChangeHint_ChildrenOnlyTransform, which results in TRANSFORM_CHANGED being passed in to OverflowChangedTracker::AddFrame. - In nsIFrame::FinishAndStoreOverflow, the passed in overflow is now stored as the InitialTransformProperty for elements that are IsTransformed(). - Partially corrected Bug 926155, by only calling OverflowChangedTracker::AddFrame on parents of the sticky element during StickyScrollContainer::UpdatePositions, using CHILDREN_CHANGED.
88f30798bfd0799d32f9525486dd9417c91caaa9: Bug 950526 - dirty frames after reparenting. r=dbaron
John Daggett <jdaggett@mozilla.com> - Tue, 08 Apr 2014 14:13:28 +0900 - rev 177835
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 950526 - dirty frames after reparenting. r=dbaron
9e1a8a3f1a6960e029902eddab0557889f179dfa: Bug 950526 - add more reftests to cover first-letter, first-line scenarios. r=dbaron,heycam
John Daggett <jdaggett@mozilla.com> - Tue, 08 Apr 2014 14:13:28 +0900 - rev 177834
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 950526 - add more reftests to cover first-letter, first-line scenarios. r=dbaron,heycam
353dde65b2421c1ef210733a4e18753614727505: Bug 950526 - don't dump textruns within nsTextFrame::DidSetStyleContext. r=dbaron
John Daggett <jdaggett@mozilla.com> - Tue, 08 Apr 2014 14:13:28 +0900 - rev 177833
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 950526 - don't dump textruns within nsTextFrame::DidSetStyleContext. r=dbaron
8bdb40bd31035e6cfe29134d36bf25fee3ae0930: Bug 964646 part 5 - Add OMTA version of test_animations.html keyframe tests; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 16:55:45 +0900 - rev 177257
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 964646 part 5 - Add OMTA version of test_animations.html keyframe tests; r=dbaron
f5f9279dbaf485c7aebd4d8065a3a4eb68e2e13c: Bug 964646 part 4 - Add OMTA version of test_animations.html animation list tests; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 16:55:44 +0900 - rev 177256
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 964646 part 4 - Add OMTA version of test_animations.html animation list tests; r=dbaron Tests for animation list handling on the compositor thread. Some checks are currently marked todo_is because they depend on Bug 980769 in order to pass.
33a00dec3dbd0ba49faf432b7bc94945929a1c66: Bug 964646 part 3 - Refactor OMTA test methods to include opacity too; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 16:55:44 +0900 - rev 177255
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 964646 part 3 - Refactor OMTA test methods to include opacity too; r=dbaron This patch takes the compareTransform utility methods and makes them more generic so they can be used for testing opacity too (the other property currently animated on the compositor thread). The naming omta_is and omta_is_approx is intended to mirror is and is_approx in test_animations.html.
da72761ebf82f1b6adef94784d94941cabed703a: Bug 964646 part 2 - Add OMTA version of test_animations.html fill mode tests; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 16:55:44 +0900 - rev 177254
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 964646 part 2 - Add OMTA version of test_animations.html fill mode tests; r=dbaron This patch adds an additional mochitest for specifically targetting CSS Animations that run on the compositor thread. The content of the test mimicks test_animations.html but using properties whose animations are expected to run on the compositor thread.
cc8ad11753248c34343db3e335b0f9d5c242d76d: Bug 964646 part 1 - Add common OMTA test runner to animation_utils.js; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 16:55:44 +0900 - rev 177253
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 964646 part 1 - Add common OMTA test runner to animation_utils.js; r=dbaron Since off-main thread animation (OMTA) is not available on all platforms we define a common wrapper function that runs OMTA tests only when available. This patch further performs an internal check of basic OMTA operation so that only a single error is produced if OMTA is unexpectedly unavailable. Typical usage is: SimpleTest.waitForExplicitFinish(); runOMTATest(function() { ... test code ... SimpleTest.finish(); }, SimpleTest.finish); This can be easily wrapped with promises if needed but does not require using promises. The calls to waitForExplicitFinish and finish are not performed automatically since this function may be integrated with test suites that do other work outside the call to runOMTATest.
a95e1a0fb26bb399d75ee0a396fc4a71ca012e0b: Bug 957833 - Enable CSS Variables by default in release builds. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Thu, 03 Apr 2014 17:05:28 +1100 - rev 177250
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 957833 - Enable CSS Variables by default in release builds. r=dbaron
d2f3c58a8e46a793d6a3a1ff951e618a66a50623: Bug 880596 part 9 - Fix comment about mFlushCount; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:28 +0900 - rev 177248
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 9 - Fix comment about mFlushCount; r=dbaron Two comments in AnimationCommon.h refer to 'mFlushCount' which was presumably the old name for mAnimationGeneration. Also, one comment says nsCSSFrameConstructor tracks this. This patch adjusts the comments to refer to mAnimationGeneration and RestyleManager. (The reference to nsTransitionManager::UpdateAllThrottleStyles() is still valid since there is useful documentation accompanying that method despite the fact that the relevant code is mostly contained in AnimationCommon.h since bug 914847. Eventually we will unify the structures of transitions and animations to the the point that we can replace the IMPL_UPDATE_ALL_THROTTLED_STYLES_INTERNAL macro in AnimationCommon.h with an actual method. At that point we can move the documentation accompanying nsTransitionManager::UpdateAllThrottleStyles and its references to AnimationCommon.)
85114363d5ae5b675f2524da02595bb060686893: Bug 880596 part 8 - Rename ElementAnimation to StyleAnimation; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:28 +0900 - rev 177247
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 8 - Rename ElementAnimation to StyleAnimation; r=dbaron We need a basic representation of animations from which we can derive subclasses to represent specific cases such as transitions. For now we will retrofit ElementAnimation for that purpose hence renaming it to StyleAnimation. This patch removes the "using namespace mozilla::layers" line from AnimationCommon.cpp since the unified build system concatenates several files together before compiling making using declarations like this leak into other files potentially creating ambiguities. Previously, when we were calling ElementAnimation, 'Animation', there were ambiguities between mozilla::layers::Animation and this new 'Animation' class. In general, it is probably a good idea to limit the scope of these using declarations so I've kept that change.
a8a6af1944c6ed55981089f680e8ffc3b30cd2bb: Bug 880596 part 7 - Move ElementAnimation to AnimationCommon; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:28 +0900 - rev 177246
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 7 - Move ElementAnimation to AnimationCommon; r=dbaron This patch relocates ElementAnimation from nsAnimationManager.{h,cpp} to AnimationCommon.{h,cpp} and in the process moves it into the mozilla::css namespace.
56fb71158cbb1144f3c24a7c5ccfe644bfc5e93d: Bug 880596 part 6 - Factor out common method for adding animations and transitions to a layer; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:28 +0900 - rev 177245
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 6 - Factor out common method for adding animations and transitions to a layer; r=dbaron The loops for adding animations and transitions to a layer in nsDisplayList::AddAnimationsAndTransitionsToLayer are now identical and so can be factored out into a common method. Since it is not possible to implicitly convert from nsTArray<ElementPropertyTransition> to nsTArray<ElementAnimation> despite ElementPropertyTransition being a subclass of ElementAnimation a templated method is used. In the future, as animations and transitions share more and more code, we should be able to remove the need for templates.
762aa62425b91b71654ea89c56d19077a5147915: Bug 880596 part 5 - Make ElementAnimation::HasAnimationOfProperty no longer virtual; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:28 +0900 - rev 177244
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 5 - Make ElementAnimation::HasAnimationOfProperty no longer virtual; r=dbaron ElementAnimation::HasAnimationOfProperty doesn't seem to be overridden anywhere. I suspect it was a copy-paste mistake because the methods of the same name on ElementAnimations, ElementTransitions, and CommonElementAnimationData are virtual.
8836e0b328b7266835973a7a06a1801f78095451: Bug 880596 part 4 - Reuse ElementAnimation::HasAnimationOfProperty; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:27 +0900 - rev 177243
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 4 - Reuse ElementAnimation::HasAnimationOfProperty; r=dbaron Now that ElementTransitionProperty inherits from ElementAnimation, ElementTransitions::HasAnimationOfProperty can re-use ElementAnimation::HasAnimationOfProperty in its definition of ElementTransitions::HasAnimationOfProperty. Similarly, in nsDisplayList::AddAnimationsAndTransitionsToLayer we can use this method rather than drilling down to the appropriate segment by hand.
abd19a468375b0d970cc4cab76daf6768ee75800: Bug 880596 part 3 - Remove ElementPropertyTransition::IsRunningAt and mIsRunningOnCompositor; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:27 +0900 - rev 177242
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 3 - Remove ElementPropertyTransition::IsRunningAt and mIsRunningOnCompositor; r=dbaron Both ElementPropertyTransition and ElementAnimation specify an IsRunningAt method which have the same purpose but with two subtle differences: a) ElementPropertyTransition::IsRunningAt checks if the transition is a removed sentinel and if so returns false. This patch adds a check for a null start time to IsRunningAt since I think in future we will want to allow null times in various places to represent, for example, animations that are not connected to a timeline. (However, ultimately we will probably not allow start times on *animations* to be null, only on their associated player.) Should we later use a different mechanism for marking sentinel transitions (e.g. a boolean flag) this method should still be correct as it checks if aTime is inside the transition interval before returning true. b) ElementPropertyTransition::IsRunningAt returns false if the transition is in the delay phase, that is, waiting to start. This patch changes this behavior so that transitions are considered running even if they are in the delay phase. This brings their behavior into line with animations and removes the need for the ElementPropertyTransition::mIsRunningOnCompositor since it is only used to determine when a transition in the delay phase has begun. ElementAnimation::IsRunningAt also handles pause state and iterations but this logic should still be correct for transitions which, in this area, only use a subset of the functionality of animations since their pause state is always playing and their iteration count is 1.
e8e989773e24f284f92a98dfc045631cf0c46ad5: Bug 880596 part 2 - Make ElementPropertyTransition inherit from ElementAnimation; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:27 +0900 - rev 177241
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 2 - Make ElementPropertyTransition inherit from ElementAnimation; r=dbaron As part of moving towards more shared data structures for animation, this patch makes ElementPropertyTransition inherit from ElementAnimation. At the same time we switch from storing the target property, start/end values, start time, delay, and timing function on the transition to the corresponding location in ElementAnimation. Since nsDisplayList::AddAnimationsAndTransitionsToLayer was already doing this conversion in order to create animations to pass to the compositor thread, we can remove the conversion code from there and just use the ElementAnimation data structures as-is. A number of assertions are added to verify that transitions are set up as expected (namely, they have only a single property-animation with a single segment). As we move to more generic handling of animations and transitions these assertions should disappear.
2b7444f517c82048060fc04776e96a151b61e224: Bug 880596 part 1 - Separate delay from start time for transitions; r=dbaron
Brian Birtles <birtles@gmail.com> - Thu, 03 Apr 2014 14:57:27 +0900 - rev 177240
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 880596 part 1 - Separate delay from start time for transitions; r=dbaron As a first step towards making CSS animations and CSS transitions use the same data structures, this patch aligns their behavior with regards to start time and delay handling. Previously, ElementAnimation objects maintained separate mStartTime and mDelay members whilst ElementPropertyTransition objects maintained a single mStartTime property that incorporated the delay. This patch adds an mDelay member to ElementPropertyTransition and stores the delay and start time separately. Calculations involving ElementPropertyTransition::mStartTime are adjusted to incorporate mDelay.
64d1ccde4597ca9cc030c5083ca78f3067b4637e: Bug 990297 - Refactor table initialization code in nsCSSProps::AddRefTable. r=dbaron
Xidorn Quan <quanxunzhen@gmail.com> - Wed, 02 Apr 2014 11:47:55 -0400 - rev 177054
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 990297 - Refactor table initialization code in nsCSSProps::AddRefTable. r=dbaron
728e346fe9c910afdac8278c5e07eaf710e2b3c2: Bug 988780 - Refactor ParseGridTemplateAfterString() to not use CheckEndProperty() (layout/style/nsCSSParser.cpp). r=dbaron
Simon Sapin <simon.sapin@exyr.org> - Thu, 27 Mar 2014 02:24:00 +0100 - rev 177010
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 988780 - Refactor ParseGridTemplateAfterString() to not use CheckEndProperty() (layout/style/nsCSSParser.cpp). r=dbaron
822d8b27f4277e4c0e1d16b726831eb5123559dd: Bug 985838 - Change custom property name prefix from "var-" to "--" and allow identifiers to begin with "--". r=dbaron
Cameron McCormack <cam@mcc.id.au> - Wed, 02 Apr 2014 14:32:16 +1100 - rev 176991
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 985838 - Change custom property name prefix from "var-" to "--" and allow identifiers to begin with "--". r=dbaron
3dc94091255a09dd473db24617dc1c7a5ad151b8: Bug 989574. Enable reftests in layout/reftests/invalidation on all platforms. r=dbaron
Timothy Nikkel <tnikkel@gmail.com> - Fri, 28 Mar 2014 23:54:37 -0500 - rev 176436
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 989574. Enable reftests in layout/reftests/invalidation on all platforms. r=dbaron A mistake caused them to never be enabled (except on b2g).
acba6fd6fb2c1843beb5626308ceb31a6303fd0a: Bug 983175 - Part 0: Rename nsParsingStatus to CSSParseResult. r=dbaron
Simon Sapin <simon.sapin@exyr.org> - Thu, 27 Mar 2014 11:54:40 -0400 - rev 176060
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 983175 - Part 0: Rename nsParsingStatus to CSSParseResult. r=dbaron
d0fed85e8eca76efe2e2623ff30aa912b30c876f: Bug 987605. Call MaybeReflowForInflationScreenWidthChange on SetScrollPositionClampingScrollPortSize instead of SetDisplayPortForElement. r=dbaron
Timothy Nikkel <tnikkel@gmail.com> - Wed, 26 Mar 2014 14:59:35 -0500 - rev 175847
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 987605. Call MaybeReflowForInflationScreenWidthChange on SetScrollPositionClampingScrollPortSize instead of SetDisplayPortForElement. r=dbaron The scroll position clamping scroll port size is more closely related to the screen size then the display port.
52755193f6927b42f52719ef06dcaab77f72bff3: Bug 980247 - Add a reftest for different continuations of a sticky element having the same offsets. r=dbaron
Abel Lin <alin@mozilla.com> - Wed, 26 Mar 2014 14:46:47 -0400 - rev 175820
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 980247 - Add a reftest for different continuations of a sticky element having the same offsets. r=dbaron
becd60bbd3834b7b9eef152db27e816bdc63e4ce: Bug 980247 - Use offsets from GetNormalPosition() when updating continuations of position:sticky elements instead of assuming that they're all currently offset by the same amount. r=dbaron, r=corey
Abel Lin <alin@mozilla.com> - Wed, 26 Mar 2014 14:45:17 -0400 - rev 175819
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 980247 - Use offsets from GetNormalPosition() when updating continuations of position:sticky elements instead of assuming that they're all currently offset by the same amount. r=dbaron, r=corey
03ba1ccfb017a0fcbaaf5dbdee62d079b7fea5ff: Bug 610733. Vertically center the text in the combobox display area when a non-default height is set for the combobox. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 25 Mar 2014 22:48:46 -0400 - rev 175650
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 610733. Vertically center the text in the combobox display area when a non-default height is set for the combobox. r=dbaron
259991514082e8feb862f846530e421c60f12d0d: Bug 791480. Reenable test on Windows 7. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Tue, 25 Mar 2014 22:15:49 +1300 - rev 175537
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 791480. Reenable test on Windows 7. r=dbaron
b6c3d52bf61e595d3a80afcac0fe78735fc13277: Bug 791480. Make reftests enter print mode before reftest-wait is removed, so canvas-print-callback tests can finish drawing before the test ends. r=dbaron
Robert O'Callahan <robert@ocallahan.org> - Tue, 25 Mar 2014 22:11:27 +1300 - rev 175536
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 791480. Make reftests enter print mode before reftest-wait is removed, so canvas-print-callback tests can finish drawing before the test ends. r=dbaron
8dafd4b9969a0aba78e2376625b32901f40d5550: Bug 976365 - Make 'perspective' create a containing block for absolute and fixed positioned children. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 25 Mar 2014 11:45:43 +1300 - rev 175520
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 976365 - Make 'perspective' create a containing block for absolute and fixed positioned children. r=dbaron
cb183f7c168795c9579ccbc5661f6a7dbcedf42a: Bug 984786 part 1: Add MOZ_FINAL and private destructors to some refcounted classes in layout. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 21 Mar 2014 09:16:20 +0800 - rev 175042
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 984786 part 1: Add MOZ_FINAL and private destructors to some refcounted classes in layout. r=dbaron
1d12ab8bf5fe5b95f4b799de0591c0ad6eb6a12d: Bug 950526 - don't dump textruns within nsTextFrame::DidSetStyleContext. r=dbaron
John Daggett <jdaggett@mozilla.com> - Thu, 20 Mar 2014 14:43:29 +0800 - rev 174800
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 950526 - don't dump textruns within nsTextFrame::DidSetStyleContext. r=dbaron
44bea44e2f610342c1040db15dab36726cf2b4ab: Bug 959973 - Followup to actually run the tests. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Thu, 20 Mar 2014 15:43:37 +1100 - rev 174799
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 959973 - Followup to actually run the tests. r=dbaron