searching for reviewer(bnicholson)
4c2f39f0bcc2033c8dfdd0cfa4f32edd3d4daf72: Bug 1004160 - Make sure home banner icon is visible when image is set. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 30 Apr 2014 14:38:05 -0700 - rev 181570
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 1004160 - Make sure home banner icon is visible when image is set. r=bnicholson
f84446d45985b104eafa8e8be253a00a177281f9: Bug 1002567 - Support weighted snippets. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 30 Apr 2014 14:38:02 -0700 - rev 181569
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 1002567 - Support weighted snippets. r=bnicholson
c29c34aea5b089b43a79faac68ce7388bcbc12ef: Bug 958889 - Part 2: Miscellaneous code clean up. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Tue, 29 Apr 2014 11:21:38 -0700 - rev 181248
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 958889 - Part 2: Miscellaneous code clean up. r=bnicholson
e68c18a91f3d95e3696e827a45090c8ab5f71e69: Bug 958889 - Part 1: Move tabspanel files to new tabspanel package. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Tue, 29 Apr 2014 11:20:59 -0700 - rev 181247
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 958889 - Part 1: Move tabspanel files to new tabspanel package. r=bnicholson
6fcc6dae54098bf313ebe86e1600f378e3fcaadc: Bug 1002318 - Add UI Telemetry for sanitizing private data r=liuche, bnicholson
Mark Finkle <mfinkle@mozilla.com> - Tue, 29 Apr 2014 08:04:10 -0400 - rev 181219
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 1002318 - Add UI Telemetry for sanitizing private data r=liuche, bnicholson
08928202c32b405d1db5fc64752f5135567851cb: Bug 995347 - Allow domain auto completion when entering "h" in url bar. r=bnicholson
Anuj Sahai <sahai.anuj16@gmail.com> - Thu, 17 Apr 2014 01:23:03 +0530 - rev 179821
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 995347 - Allow domain auto completion when entering "h" in url bar. r=bnicholson
62a5caa65d45503838a232d70a2de7fc3effd789: Bug 965548 - Part 8: Guard toolbar views at runtime so tablets do not break. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Apr 2014 14:09:43 -0700 - rev 179603
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 965548 - Part 8: Guard toolbar views at runtime so tablets do not break. r=bnicholson
6a49f6cb358226b712f712b32c0159eb374b4638: Bug 965548 - Part 3: Add cancel button for phone layout. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Apr 2014 13:34:12 -0700 - rev 179598
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 965548 - Part 3: Add cancel button for phone layout. r=bnicholson
8998623049ceccadde6e9c621dc1b5e290fefe4a: Bug 965548 - Part 2.5: Make Themed* processing more robust. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Apr 2014 13:34:11 -0700 - rev 179597
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 965548 - Part 2.5: Make Themed* processing more robust. r=bnicholson
ee46cc7283c2e9967a1027b132bd0da80107ac42: Bug 965548 - Part 2: Add "cancel" string. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Apr 2014 13:34:06 -0700 - rev 179596
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 965548 - Part 2: Add "cancel" string. r=bnicholson
b9a4644f4039112740f865d7319066abb2f120e3: Bug 965548 - Part 1: Add close button image assets. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Thu, 17 Apr 2014 13:33:57 -0700 - rev 179595
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 965548 - Part 1: Add close button image assets. r=bnicholson
a5cee95d219ec9021d5b59d51dde9404293715c2: Bug 997406 - Default to Link context menu items in context menus. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Tue, 15 Apr 2014 12:49:38 -0700 - rev 179392
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 997406 - Default to Link context menu items in context menus. r=bnicholson
cd04719806d8d093f75855e15c0ad495ffcd74cb: Bug 993666 - Keep track of whether or not to send banner message to Java when a banner is added. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Tue, 15 Apr 2014 10:03:03 -0700 - rev 179083
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 993666 - Keep track of whether or not to send banner message to Java when a banner is added. r=bnicholson
4c16d08e358bb1271153fabda973eebc1ca3f458: Bug 993407 - Always show link tab as default in context menus. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Fri, 11 Apr 2014 14:19:13 -0700 - rev 178626
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 993407 - Always show link tab as default in context menus. r=bnicholson
a859178440582950b35da3abd13f2b2e21a6d46e: Bug 903535 - Tests. r=bnicholson
Chenxia Liu <liuche@mozilla.com> - Tue, 08 Apr 2014 17:29:46 -0700 - rev 178098
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 903535 - Tests. r=bnicholson
5cd3b8b0039bf9c4b51f2b834ebae46cfc6259ab: Bug 903535 - Need to update text for user visible opt in UI for cell tower and wifi data collection and reporting. r=bnicholson
Chenxia Liu <liuche@mozilla.com> - Tue, 08 Apr 2014 17:29:45 -0700 - rev 178097
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 903535 - Need to update text for user visible opt in UI for cell tower and wifi data collection and reporting. r=bnicholson
d54f7e4f84c12557cce61cd7e37d2ec3efb7c58b: Bug 991705 - Default to puzzle icon if an add-on doesn't have an icon. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Tue, 08 Apr 2014 11:13:31 -0700 - rev 178001
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 991705 - Default to puzzle icon if an add-on doesn't have an icon. r=bnicholson
46cf0150b59e6b8f20c079125e48540ca89b4e92: Bug 991256 - Rename preprocessed Gecko* -> Themed* in widget/. r=bnicholson
Michael Comella <michael.l.comella@gmail.com> - Wed, 02 Apr 2014 15:56:52 -0700 - rev 177276
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 991256 - Rename preprocessed Gecko* -> Themed* in widget/. r=bnicholson
9f527e5397c21dda07fd9b942e908599bebe2413: Bug 933739 - Trigger autocompletion even if the search term hasn't changed (r=bnicholson)
Lucas Rocha <lucasr@mozilla.com> - Wed, 02 Apr 2014 14:39:45 +0100 - rev 177177
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 933739 - Trigger autocompletion even if the search term hasn't changed (r=bnicholson)
cbbf33ba0c772b7bf78ee7743714803a90e1c101: Bug 933739 - Make mSearchTerm volatile in BrowserSearch (r=bnicholson)
Lucas Rocha <lucasr@mozilla.com> - Wed, 02 Apr 2014 14:39:44 +0100 - rev 177176
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 933739 - Make mSearchTerm volatile in BrowserSearch (r=bnicholson)
07b7da9bf7cca7f30e11e644b3fb71bf5ed36c6b: Bug 976680 - Remove landscape padding from home banner. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 26 Mar 2014 17:39:36 -0700 - rev 176489
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 976680 - Remove landscape padding from home banner. r=bnicholson
968a2848d8ab83df420f59a0dee60b44ddcc0518: Bug 933739 - Reset autocompletion state when the toolbar gets focus (r=bnicholson)
Lucas Rocha <lucasr@lucasr.org> - Fri, 28 Mar 2014 14:19:04 +0000 - rev 176405
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 933739 - Reset autocompletion state when the toolbar gets focus (r=bnicholson)
9387556cc4bf6670a27b30b842a5752ebe547a75: Bug 942270 - Fix gingerbread issues with quickshare. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Wed, 26 Mar 2014 10:18:02 -0700 - rev 175961
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 942270 - Fix gingerbread issues with quickshare. r=bnicholson
05eb52f327ac36cf40a14a5a085a00f92faac330: Bug 942270 - Use tabs for prompts with multiple contexts. r=bnicholson,margaret
Wes Johnston <wjohnston@mozilla.com> - Wed, 26 Mar 2014 10:18:02 -0700 - rev 175960
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 942270 - Use tabs for prompts with multiple contexts. r=bnicholson,margaret
c437a98128f4c9ee1ba38609691d3b9917171675: Bug 942270 - Support quickshare in context menus. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Wed, 26 Mar 2014 10:18:01 -0700 - rev 175957
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 942270 - Support quickshare in context menus. r=bnicholson
73edfcfeb6e2f6ec0add36b557119f787f32eb95: Bug 985875 - Set selected item in adapter for single select lists. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Tue, 25 Mar 2014 22:44:08 -0700 - rev 175945
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 985875 - Set selected item in adapter for single select lists. r=bnicholson
b64373b02d2d784775f2282ae9c12d19f206a297: Bug 956716 - Use exclusive bounds for substring. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Tue, 25 Mar 2014 22:43:12 -0700 - rev 175944
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 956716 - Use exclusive bounds for substring. r=bnicholson
6ad1bb2854cc0af3a74310e081dcd2560c4413ed: Bug 956716 - Crop dialog titles to 256 characters. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Tue, 25 Mar 2014 12:45:57 -0700 - rev 175936
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 956716 - Crop dialog titles to 256 characters. r=bnicholson
b4fce211dbdea20d897b78c5cf5df080b83226ee: Bug 987415 - Part 1: GeckoAppShell thread-safety. r=bnicholson
Richard Newman <rnewman@mozilla.com> - Mon, 24 Mar 2014 17:44:02 -0700 - rev 175564
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 987415 - Part 1: GeckoAppShell thread-safety. r=bnicholson
54e12e5102643b63f3c410667eaacebeb043894e: Bug 987415 - Part 0: GeckoAppShell cleanup. r=bnicholson
Richard Newman <rnewman@mozilla.com> - Mon, 24 Mar 2014 17:44:01 -0700 - rev 175563
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 987415 - Part 0: GeckoAppShell cleanup. r=bnicholson
fa54525785311c778faf0a8804bad55eb49c0b83: Bug 987294 - Unsafe access to mTabsChangedListeners in Tabs. r=bnicholson
Richard Newman <rnewman@mozilla.com> - Mon, 24 Mar 2014 14:40:54 -0700 - rev 175554
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 987294 - Unsafe access to mTabsChangedListeners in Tabs. r=bnicholson
632c0d6e86471aa97a7696faa0259d184711342b: Bug 943262 - Use CharsetMenu.jsm instead of charsetTitles.properties for Character Encoding menu items. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Mon, 24 Mar 2014 09:22:32 -0700 - rev 175507
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 943262 - Use CharsetMenu.jsm instead of charsetTitles.properties for Character Encoding menu items. r=bnicholson
6ff53816ea39df3aab8f1685d083b124c510672b: Bug 983475 - Remove shouldShowProgress method from browser.js. r=bnicholson
Vlad Tanase <vtanase.ro@gmail.com> - Wed, 19 Mar 2014 16:08:05 +0200 - rev 175498
Push 272 by pvanderbeken@mozilla.com at Mon, 05 May 2014 16:31:18 +0000
Bug 983475 - Remove shouldShowProgress method from browser.js. r=bnicholson
a134122e6411ac4ef8d06d6d7341eb376135e412: Bug 976144 - Changed the show progress bar conditions so that it is no longer shown for about pages. r=bnicholson
Vlad Tanase <vtanase.ro@gmail.com> - Wed, 19 Mar 2014 08:47:45 -0400 - rev 174824
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 976144 - Changed the show progress bar conditions so that it is no longer shown for about pages. r=bnicholson
953eea0ac46c13560bc740722dccce110d16fe67: Bug 984819 - Remove deprecated promise.js usage in Firefox for Android tests. r=bnicholson
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 19 Mar 2014 08:39:35 +0100 - rev 174685
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 984819 - Remove deprecated promise.js usage in Firefox for Android tests. r=bnicholson
387c93121a6a432a876ef4b7c091c99ae008b211: Bug 984873 - Hide banner for the rest of the session after the user has clicked on it. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Tue, 18 Mar 2014 15:39:58 -0700 - rev 174678
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 984873 - Hide banner for the rest of the session after the user has clicked on it. r=bnicholson
447791883dd4949bda1ea5b8d47ef1acfe3a95ba: Bug 983609 - Only update toolbar private mode when a new tab is selected (r=bnicholson)
Lucas Rocha <lucasr@mozilla.com> - Mon, 17 Mar 2014 13:00:11 +0000 - rev 174334
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 983609 - Only update toolbar private mode when a new tab is selected (r=bnicholson)
f785999a6144a0886c7f39d8598f68e7e6d82163: Bug 942270 - Refactor context menu code. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Fri, 21 Feb 2014 14:05:00 -0800 - rev 174221
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 942270 - Refactor context menu code. r=bnicholson
39cc22fbd6afdc1f1f049672caccc1df9524c760: Bug 981682 - Don't bother nulling dialog when its closed. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Sat, 15 Mar 2014 14:26:30 -0700 - rev 174200
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 981682 - Don't bother nulling dialog when its closed. r=bnicholson
4c8b77b42f5534d3fbc91a6803b1436ea254f5e0: Bug 942270 - Allow ActionViews in prompts. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Fri, 14 Mar 2014 14:41:20 -0700 - rev 174066
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 942270 - Allow ActionViews in prompts. r=bnicholson
6838701222096aa2d37a6b3afe71dd23820fe6cd: Bug 942270 - Add intents to PromptListItems. r=bnicholson
Wes Johnston <wjohnston@mozilla.com> - Fri, 14 Mar 2014 14:41:10 -0700 - rev 174065
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 942270 - Add intents to PromptListItems. r=bnicholson
e7f7cc81c10333623a345b77450b7b98824fdfbc: Bug 943262 - Use CharsetMenu.jsm instead of charsetTitles.properties for Character Encoding menu items. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 14 Mar 2014 11:41:47 -0700 - rev 174060
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 943262 - Use CharsetMenu.jsm instead of charsetTitles.properties for Character Encoding menu items. r=bnicholson
b4fd23f69cefa422371f503892ad5b6c406f984c: Bug 975469 - Remove sync promo banner from rotation after it has been tapped. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 07 Mar 2014 11:23:27 -0800 - rev 173019
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 975469 - Remove sync promo banner from rotation after it has been tapped. r=bnicholson
b940770772d29df495f918081d50dbdedf005d30: Bug 975239 - (Part 4) Don't show the banner again for the rest of the app lifetime after the user taps the close button. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 07 Mar 2014 11:23:27 -0800 - rev 173018
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 975239 - (Part 4) Don't show the banner again for the rest of the app lifetime after the user taps the close button. r=bnicholson
be4a906fa5fadd86537afc39cc5dd2fd662900cc: Bug 975239 - (Part 3) Refactor HomeBanner.handleMessage to handle being called multiple times. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 07 Mar 2014 11:23:27 -0800 - rev 173017
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 975239 - (Part 3) Refactor HomeBanner.handleMessage to handle being called multiple times. r=bnicholson
109d0ec8dc2770d5d574d0ce49f0ae8c99bd5a83: Bug 975239 - (Part 2) Request a home banner message when the HomePager loads. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 07 Mar 2014 11:23:27 -0800 - rev 173016
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 975239 - (Part 2) Request a home banner message when the HomePager loads. r=bnicholson
f94c24ba149667262b918035d7b6555b2fa96311: Bug 975239 - (Part 1) Choose a banner message at random instead of rotating through a queue. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 07 Mar 2014 11:23:26 -0800 - rev 173015
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 975239 - (Part 1) Choose a banner message at random instead of rotating through a queue. r=bnicholson
9be47a5684e68873224658e9c16692e247c616e0: Bug 974925 - Change snippets error message into a log message. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Thu, 06 Mar 2014 09:25:08 -0800 - rev 172783
Push 271 by pvanderbeken@mozilla.com at Mon, 24 Mar 2014 22:43:42 +0000
Bug 974925 - Change snippets error message into a log message. r=bnicholson
6de7f6039a6841c6437d7256d1a37f62016657fe: Bug 977844 - Make sure snippets response is valid JSON before caching it (or trying to use it). r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 28 Feb 2014 17:26:56 -0800 - rev 171794
Push 270 by pvanderbeken@mozilla.com at Thu, 06 Mar 2014 09:24:21 +0000
Bug 977844 - Make sure snippets response is valid JSON before caching it (or trying to use it). r=bnicholson
2fb022dbbe729a716567849a62d06f85e91d0fb2: Bug 977155 - (Part 2) Rename HomeBanner setEnabled to setActive. r=bnicholson
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 28 Feb 2014 17:26:54 -0800 - rev 171793
Push 270 by pvanderbeken@mozilla.com at Thu, 06 Mar 2014 09:24:21 +0000
Bug 977155 - (Part 2) Rename HomeBanner setEnabled to setActive. r=bnicholson