author Gregory Szorc <>
Mon, 22 Jan 2018 12:19:49 -0800
changeset 41697 b116a66bcc44ad3434b58cc58bb92a21631c23bd
parent 33263 a492610a2fc1e22408c869dc59dc4e042ff2b81d
permissions -rw-r--r--
bundle2: move version of stream clone into part name I don't like having version numbers as part parameters. It means that parts can theoretically vary wildly in their generation and processing semantics. I think that a named part should have consistent behavior over time. In other words, if you need to introduce new functionality or behavior, that should be expressed by inventing a new bundle2 part, not adding functionality to an existing part. This commit applies this advice to the just-introduced stream clone via bundle2 feature. The "version" part parameter is removed. The name of the bundle2 part is now "stream2" instead of "stream" with "version=v2". Differential Revision:

Our full contribution guidelines are in our wiki, please see:

If you just want a checklist to follow, you can go straight to

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).