Bug 1403825 Resolve sequence-point warning in widget/windows/TSFTextStore.cpp r=jimm
authorTom Ritter <tom@mozilla.com>
Thu, 28 Sep 2017 00:33:11 -0500
changeset 426662 e7ac83f1710ac5e4c151d9ca6b79ed9a4971e909
parent 426661 725654758702332ebde2d2b74a8b5bd14850218f
child 426663 0cf0a269491e2e2fecc607a4bce42991407befec
push id97
push userfmarier@mozilla.com
push dateSat, 14 Oct 2017 01:12:59 +0000
reviewersjimm
bugs1403825
milestone58.0a1
Bug 1403825 Resolve sequence-point warning in widget/windows/TSFTextStore.cpp r=jimm This warning is saying the operation may be undefined because the value of ->left is not guarenteed to be the same because of undefined order of operations. Fortunately, this seems like a typo and we actually meant to assign ->bottom MozReview-Commit-ID: H5G8fnDwIJP
widget/windows/TSFTextStore.cpp
--- a/widget/windows/TSFTextStore.cpp
+++ b/widget/windows/TSFTextStore.cpp
@@ -4418,17 +4418,17 @@ TSFTextStore::GetScreenExt(TsViewCookie 
        "null argument", this));
     return E_INVALIDARG;
   }
 
   if (mDestroyed) {
     MOZ_LOG(sTextStoreLog, LogLevel::Error,
       ("0x%p   TSFTextStore::GetScreenExt() returns empty rect "
        "due to already destroyed", this));
-    prc->left = prc->top = prc->right = prc->left = 0;
+    prc->left = prc->top = prc->right = prc->bottom = 0;
     return S_OK;
   }
 
   if (!GetScreenExtInternal(*prc)) {
     MOZ_LOG(sTextStoreLog, LogLevel::Error,
       ("0x%p   TSFTextStore::GetScreenExt() FAILED due to "
        "GetScreenExtInternal() failure", this));
     return E_FAIL;