Bug 1410351 - Make it more obvious when requests are paused in the netmonitor; r=rickychien
☠☠ backed out by 8dde15bbb4d8 ☠ ☠
authorJan Odvarko <odvarko@gmail.com>
Thu, 09 Nov 2017 14:01:59 +0100
changeset 436094 e18bb1a3d0958fe7e6f05524c417005680cb37ed
parent 436093 d94d71ae256f437b75785d899769d561b41d62a4
child 436095 8dde15bbb4d8a70816e421e25d44d558c7c9ccb9
push id117
push userfmarier@mozilla.com
push dateTue, 28 Nov 2017 20:17:16 +0000
reviewersrickychien
bugs1410351
milestone59.0a1
Bug 1410351 - Make it more obvious when requests are paused in the netmonitor; r=rickychien MozReview-Commit-ID: FlHVxePSbqg
devtools/client/jar.mn
devtools/client/netmonitor/src/assets/icons/pause.svg
devtools/client/netmonitor/src/assets/icons/play.svg
devtools/client/netmonitor/src/assets/styles/variables.css
--- a/devtools/client/jar.mn
+++ b/devtools/client/jar.mn
@@ -2,27 +2,17 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 devtools.jar:
 %   content devtools %content/
     content/shared/vendor/d3.js (shared/vendor/d3.js)
     content/shared/vendor/dagre-d3.js (shared/vendor/dagre-d3.js)
     content/shared/widgets/widgets.css (shared/widgets/widgets.css)
-    content/netmonitor/src/assets/styles/httpi.css (netmonitor/src/assets/styles/httpi.css)
-    content/netmonitor/src/assets/styles/MdnLink.css (netmonitor/src/assets/styles/MdnLink.css)
-    content/netmonitor/src/assets/styles/netmonitor.css (netmonitor/src/assets/styles/netmonitor.css)
-    content/netmonitor/src/assets/styles/NetworkDetailsPanel.css (netmonitor/src/assets/styles/NetworkDetailsPanel.css)
-    content/netmonitor/src/assets/styles/RequestList.css (netmonitor/src/assets/styles/RequestList.css)
-    content/netmonitor/src/assets/styles/StatisticsPanel.css (netmonitor/src/assets/styles/StatisticsPanel.css)
-    content/netmonitor/src/assets/styles/StatusBar.css (netmonitor/src/assets/styles/StatusBar.css)
-    content/netmonitor/src/assets/styles/Toolbar.css (netmonitor/src/assets/styles/Toolbar.css)
-    content/netmonitor/src/assets/styles/variables.css (netmonitor/src/assets/styles/variables.css)
     content/shared/widgets/VariablesView.xul (shared/widgets/VariablesView.xul)
-    content/netmonitor/index.html (netmonitor/index.html)
     content/webconsole/webconsole.html (webconsole/webconsole.html)
     content/webconsole/webconsole.xul (webconsole/webconsole.xul)
     content/scratchpad/scratchpad.xul (scratchpad/scratchpad.xul)
     content/scratchpad/scratchpad.js (scratchpad/scratchpad.js)
     content/shared/splitview.css (shared/splitview.css)
     content/shared/theme-switching.js (shared/theme-switching.js)
     content/shared/frame-script-utils.js (shared/frame-script-utils.js)
     content/styleeditor/styleeditor.xul (styleeditor/styleeditor.xul)
@@ -313,8 +303,22 @@ devtools.jar:
     skin/images/debugger/folder.svg (themes/images/debugger/folder.svg)
     skin/images/debugger/pause-exceptions.svg (themes/images/debugger/pause-exceptions.svg)
     skin/images/debugger/pause.svg (themes/images/debugger/pause.svg)
     skin/images/debugger/prettyPrint.svg (themes/images/debugger/prettyPrint.svg)
     skin/images/debugger/resume.svg (themes/images/debugger/resume.svg)
     skin/images/debugger/stepIn.svg (themes/images/debugger/stepIn.svg)
     skin/images/debugger/stepOut.svg (themes/images/debugger/stepOut.svg)
     skin/images/debugger/stepOver.svg (themes/images/debugger/stepOver.svg)
+
+    # Netmonitor
+    content/netmonitor/src/assets/styles/httpi.css (netmonitor/src/assets/styles/httpi.css)
+    content/netmonitor/src/assets/styles/MdnLink.css (netmonitor/src/assets/styles/MdnLink.css)
+    content/netmonitor/src/assets/styles/netmonitor.css (netmonitor/src/assets/styles/netmonitor.css)
+    content/netmonitor/src/assets/styles/NetworkDetailsPanel.css (netmonitor/src/assets/styles/NetworkDetailsPanel.css)
+    content/netmonitor/src/assets/styles/RequestList.css (netmonitor/src/assets/styles/RequestList.css)
+    content/netmonitor/src/assets/styles/StatisticsPanel.css (netmonitor/src/assets/styles/StatisticsPanel.css)
+    content/netmonitor/src/assets/styles/StatusBar.css (netmonitor/src/assets/styles/StatusBar.css)
+    content/netmonitor/src/assets/styles/Toolbar.css (netmonitor/src/assets/styles/Toolbar.css)
+    content/netmonitor/src/assets/styles/variables.css (netmonitor/src/assets/styles/variables.css)
+    content/netmonitor/src/assets/icons/play.svg (netmonitor/src/assets/icons/play.svg)
+    content/netmonitor/src/assets/icons/pause.svg (netmonitor/src/assets/icons/pause.svg)
+    content/netmonitor/index.html (netmonitor/index.html)
new file mode 100644
--- /dev/null
+++ b/devtools/client/netmonitor/src/assets/icons/pause.svg
@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" fill="context-fill #0b0b0b">
+  <path d="M5 12.503l.052-9a.5.5 0 0 0-1-.006l-.052 9a.5.5 0 0 0 1 .006zM12 12.497l-.05-9A.488.488 0 0 0 11.474 3a.488.488 0 0 0-.473.503l.05 9a.488.488 0 0 0 .477.497.488.488 0 0 0 .473-.503z"/>
+</svg>
new file mode 100644
--- /dev/null
+++ b/devtools/client/netmonitor/src/assets/icons/play.svg
@@ -0,0 +1,8 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg width="10" height="12" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" fill="context-fill #0b0b0b">
+    <g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
+        <polygon id="Triangle-2" fill="#0A84FF" points="14 6 4 12 4 0"></polygon>
+    </g>
+</svg>
--- a/devtools/client/netmonitor/src/assets/styles/variables.css
+++ b/devtools/client/netmonitor/src/assets/styles/variables.css
@@ -36,11 +36,11 @@
 
 :root.theme-firebug {
   --sort-ascending-image: url(chrome://devtools/skin/images/firebug/arrow-up.svg);
   --sort-descending-image: url(chrome://devtools/skin/images/firebug/arrow-down.svg);
 }
 
 /* Icons */
 :root {
-  --play-icon-url: url("chrome://devtools/skin/images/play.svg");
-  --pause-icon-url: url("chrome://devtools/skin/images/pause.svg");
+  --play-icon-url: url("chrome://devtools/content/netmonitor/src/assets/icons/play.svg");
+  --pause-icon-url: url("chrome://devtools/content/netmonitor/src/assets/icons/pause.svg");
 }