Bug 1486476 [wpt PR 12692] - Grid properties should not accept unitless length quirk, a=testonly
authorHwanseung Lee <hs1217.lee@samsung.com>
Wed, 29 Aug 2018 22:46:23 +0000
changeset 482581 b515e74c573ca62ca78a2b42e6b7f19e1d25625b
parent 482580 069971381d90dae4091924fdce90db18b16846c9
child 482582 6d522d902be759cdf08a65917b14ebd84a9a9ae1
push id232
push userfmarier@mozilla.com
push dateWed, 05 Sep 2018 20:45:54 +0000
reviewerstestonly
bugs1486476, 12692, 876704, 1190045, 586513
milestone63.0a1
Bug 1486476 [wpt PR 12692] - Grid properties should not accept unitless length quirk, a=testonly Automatic update from web-platform-testsGrid properties should not accept unitless length quirk The following properties are currently accepting unit lengths in quirks mode, contrary to spec[1]. - grid-auto-columns - grid-auto-rows - grid-template-columns - grid-template-rows so it should disallow. [1]https://quirks.spec.whatwg.org/#the-unitless-length-quirk Bug: 876704 Change-Id: I3af3d01f96efb3b3f788ca02893b12c7ae683c20 Reviewed-on: https://chromium-review.googlesource.com/1190045 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#586513} -- wpt-commits: a1b0ed075d51485a0a7f56b83f45f8feae66f863 wpt-pr: 12692
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/quirks/unitless-length/excluded-properties.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -621613,17 +621613,17 @@
    "4e2a3f45547e4f887d6d377e33f602ba311b54dd",
    "support"
   ],
   "quirks/text-decoration-doesnt-propagate-into-tables/standards.html": [
    "6b1c8a72751a6233eb0a07a8bb7df5e116fac724",
    "reftest"
   ],
   "quirks/unitless-length/excluded-properties.html": [
-   "a1de182770aafaab2ee4a8a335b34870388abacc",
+   "aa76b2c382d76a4af77b15541e75f7e8e366d2a9",
    "testharness"
   ],
   "quirks/unitless-length/limited-quirks.html": [
    "fab0b3b805bad3670ffce46f627ad4134c55a027",
    "testharness"
   ],
   "quirks/unitless-length/no-quirks.html": [
    "cd192029df4907dc8fd959828e8d4accb6ddf01b",
--- a/testing/web-platform/tests/quirks/unitless-length/excluded-properties.html
+++ b/testing/web-platform/tests/quirks/unitless-length/excluded-properties.html
@@ -10,16 +10,20 @@
 </head>
 <body>
 <div id="target"></div>
 <script>
 'use strict';
 
 var properties = [
     'block-size',
+    'grid-auto-columns',
+    'grid-auto-rows',
+    'grid-template-columns',
+    'grid-template-rows',
     'inline-size',
     'margin-block-end',
     'margin-block-start',
     'margin-inline-end',
     'margin-inline-start',
     'min-block-size',
     'min-inline-size',
     'offset-distance',