Bug 1420129 - Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane, r=nhnt11.
authorFlorian Quèze <florian@queze.net>
Thu, 23 Nov 2017 13:38:06 +0100
changeset 437862 a9e5bc0c80e8f4f7dbcfbbfe0d73033b7026dfe5
parent 437861 72fd7816dd7711b8e8d867e50299dbc6fee1bb13
child 437863 c6aa3b06c0b2071fdc88657ef15c3f00cc9148c0
push id117
push userfmarier@mozilla.com
push dateTue, 28 Nov 2017 20:17:16 +0000
reviewersnhnt11
bugs1420129
milestone59.0a1
Bug 1420129 - Clicking the 'Settings page' link on about:searchreset should go directly to the Search pref pane, r=nhnt11.
browser/components/search/content/searchReset.xhtml
browser/components/search/test/browser_aboutSearchReset.js
--- a/browser/components/search/content/searchReset.xhtml
+++ b/browser/components/search/content/searchReset.xhtml
@@ -36,17 +36,17 @@
       <div class="title">
         <h1 class="title-text">&searchreset.pageTitle;</h1>
       </div>
 
       <div class="description">
         <p>&searchreset.pageInfo1;</p>
         <p>&searchreset.selector.label;<span id="defaultEngine"/></p>
 
-        <p>&searchreset.beforelink.pageInfo2;<a id="linkSettingsPage" href="about:preferences">&searchreset.link.pageInfo2;</a>&searchreset.afterlink.pageInfo2;</p>
+        <p>&searchreset.beforelink.pageInfo2;<a id="linkSettingsPage" href="about:preferences#search">&searchreset.link.pageInfo2;</a>&searchreset.afterlink.pageInfo2;</p>
       </div>
 
       <div class="button-container">
         <xul:button id="searchResetKeepCurrent"
                     label="&searchreset.noChangeButton;"
                     accesskey="&searchreset.noChangeButton.access;"
                     oncommand="keepCurrentEngine();"/>
         <xul:button class="primary"
--- a/browser/components/search/test/browser_aboutSearchReset.js
+++ b/browser/components/search/test/browser_aboutSearchReset.js
@@ -110,17 +110,17 @@ var gTests = [
 },
 
 {
   desc: "Click the settings link.",
   async run() {
     Services.prefs.setCharPref(kStatusPref, "pending");
     let loadPromise = BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser,
                                                      false,
-                                                     "about:preferences");
+                                                     "about:preferences#search");
     // eslint-disable-next-line mozilla/no-cpows-in-tests
     gBrowser.contentDocument.getElementById("linkSettingsPage").click();
     await loadPromise;
 
     checkTelemetryRecords(TELEMETRY_RESULT_ENUM.OPENED_SETTINGS);
     is(Services.prefs.getCharPref(kStatusPref), "customized");
   }
 },