Bug 1448077 - Rename client/preferences/devtools.js to devtools-client.js;r=jryans
☠☠ backed out by daa5f1f165ed ☠ ☠
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 06 Apr 2018 12:13:56 +0200
changeset 457376 a826e8871e9f2c0970a36ce7b4e2b7a48d3e237b
parent 457375 42b4ccfcb9c431576a38c9a4602bbcba4d11e1f7
child 457377 456166433c7162fc37bcbb29fa9938d287c4c4cb
push id153
push userfmarier@mozilla.com
push dateTue, 10 Apr 2018 02:28:40 +0000
reviewersjryans
bugs1448077
milestone61.0a1
Bug 1448077 - Rename client/preferences/devtools.js to devtools-client.js;r=jryans We will be moving existing generic preferences for devtools from libpref/init/all.js to a new preferences file that will be devtools/preferences/devtools.js and that will always be shipped. We rename the current devtools.js to devtools-client.js to avoid conflicts when packaging the preference file to @RESPATH@/browser/@PREF_DIR@/devtools.js MozReview-Commit-ID: INnqWGBoIAF
browser/installer/package-manifest.in
devtools/client/performance/test/helpers/prefs.js
devtools/client/preferences/devtools-client.js
devtools/client/preferences/devtools.js
devtools/client/preferences/moz.build
devtools/docs/preferences.md
--- a/browser/installer/package-manifest.in
+++ b/browser/installer/package-manifest.in
@@ -425,17 +425,17 @@
 ; [DevTools Startup Files]
 @RESPATH@/browser/chrome/devtools-startup@JAREXT@
 @RESPATH@/browser/chrome/devtools-startup.manifest
 @RESPATH@/browser/@PREF_DIR@/devtools-startup.js
 
 ; DevTools
 @RESPATH@/browser/chrome/devtools@JAREXT@
 @RESPATH@/browser/chrome/devtools.manifest
-@RESPATH@/browser/@PREF_DIR@/devtools.js
+@RESPATH@/browser/@PREF_DIR@/devtools-client.js
 @RESPATH@/browser/@PREF_DIR@/debugger.js
 
 ; shell icons
 #ifdef XP_UNIX
 #ifndef XP_MACOSX
 #ifdef MOZ_UPDATER
 ; updater icon
 @RESPATH@/icons/updater.png
--- a/devtools/client/performance/test/helpers/prefs.js
+++ b/devtools/client/performance/test/helpers/prefs.js
@@ -1,17 +1,17 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/ */
 "use strict";
 
 const Services = require("Services");
 const { Preferences } = require("resource://gre/modules/Preferences.jsm");
 
 // Prefs to revert to default once tests finish. Keep these in sync with
-// all the preferences defined in devtools/client/preferences/devtools.js.
+// all the preferences defined in devtools/client/preferences/devtools-client.js.
 exports.MEMORY_SAMPLE_PROB_PREF = "devtools.performance.memory.sample-probability";
 exports.MEMORY_MAX_LOG_LEN_PREF = "devtools.performance.memory.max-log-length";
 exports.PROFILER_BUFFER_SIZE_PREF = "devtools.performance.profiler.buffer-size";
 exports.PROFILER_SAMPLE_RATE_PREF = "devtools.performance.profiler.sample-frequency-khz";
 
 exports.UI_EXPERIMENTAL_PREF = "devtools.performance.ui.experimental";
 exports.UI_INVERT_CALL_TREE_PREF = "devtools.performance.ui.invert-call-tree";
 exports.UI_INVERT_FLAME_PREF = "devtools.performance.ui.invert-flame-graph";
rename from devtools/client/preferences/devtools.js
rename to devtools/client/preferences/devtools-client.js
--- a/devtools/client/preferences/moz.build
+++ b/devtools/client/preferences/moz.build
@@ -1,13 +1,13 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 JS_PREFERENCE_PP_FILES += [
-    'devtools.js'
+    'devtools-client.js'
 ]
 
 JS_PREFERENCE_FILES += [
     'debugger.js',
 ]
--- a/devtools/docs/preferences.md
+++ b/devtools/docs/preferences.md
@@ -65,21 +65,21 @@ preference cannot be found and you didn'
 value does not match the preference type!
 
 These APIs are very similar for each preference type.
 
 ## Create a new preference
 
 To create a new preference, it should be assigned a default value. Default preferences are
 defined in preferences files such as:
-- devtools/client/preferences/devtools.js
+- devtools/client/preferences/devtools-client.js
 - devtools/client/preferences/debugger.js
 - devtools/startup/preferences/devtools-startup.js
 
-Most new preferences should go in devtools/client/preferences/devtools.js. Debugger
+Most new preferences should go in devtools/client/preferences/devtools-client.js. Debugger
 specific preferences should go in devtools/client/preferences/debugger.js. Finally if a
 preference needs to be available very early during the Firefox startup sequence, it should
 go in devtools/startup/preferences/devtools-startup.js.
 
 ### Projects using Launchpad
 
 At the time of writing this doc, projects using Launchpad have to duplicate the default
 definition of a preference.